mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-11-01 17:08:10 +00:00
5a53881580
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit
|
||
|---|---|---|
| .. | ||
| altera-cvp.c | ||
| altera-fpga2sdram.c | ||
| altera-freeze-bridge.c | ||
| altera-hps2fpga.c | ||
| altera-pr-ip-core-plat.c | ||
| altera-pr-ip-core.c | ||
| altera-ps-spi.c | ||
| dfl-afu-dma-region.c | ||
| dfl-afu-error.c | ||
| dfl-afu-main.c | ||
| dfl-afu-region.c | ||
| dfl-afu.h | ||
| dfl-fme-br.c | ||
| dfl-fme-error.c | ||
| dfl-fme-main.c | ||
| dfl-fme-mgr.c | ||
| dfl-fme-pr.c | ||
| dfl-fme-pr.h | ||
| dfl-fme-region.c | ||
| dfl-fme.h | ||
| dfl-pci.c | ||
| dfl.c | ||
| dfl.h | ||
| fpga-bridge.c | ||
| fpga-mgr.c | ||
| fpga-region.c | ||
| ice40-spi.c | ||
| Kconfig | ||
| machxo2-spi.c | ||
| Makefile | ||
| of-fpga-region.c | ||
| socfpga-a10.c | ||
| socfpga.c | ||
| stratix10-soc.c | ||
| ts73xx-fpga.c | ||
| xilinx-pr-decoupler.c | ||
| xilinx-spi.c | ||
| zynq-fpga.c | ||
| zynqmp-fpga.c | ||