Jakub Kicinski 5ab8c41cef netlink: support extack in dump ->start() ... Commit 4a19edb60d ("netlink: Pass extack to dump handlers") added extack support to netlink dumps. It was focused on rtnl and since rtnl does not use ->start(), ->done() callbacks it ignored those. Genetlink on the other hand uses ->start() extensively, for parsing and input validation. Pass the extact in via struct netlink_dump_control and link it to cb for the time of ->start(). Both struct netlink_dump_control and extack itself live on the stack so we can't keep the same extack for the duration of the dump. This means that the extack visible in ->start() and each ->dump() callbacks will be different. Corner cases like reporting a warning message in DONE across dump calls are still not supported. We could put the extack (for dumps) in the socket struct, but layering makes it slightly awkward (extack pointer is decided before the DO / DUMP split). The genetlink dump error extacks are now surfaced: $ cli.py --spec netlink/specs/ethtool.yaml --dump channels-get lib.ynl.NlError: Netlink error: Invalid argument nl_len = 64 (48) nl_flags = 0x300 nl_type = 2 error: -22 extack: {'msg': 'request header missing'} Previously extack was missing: $ cli.py --spec netlink/specs/ethtool.yaml --dump channels-get lib.ynl.NlError: Netlink error: Invalid argument nl_len = 36 (20) nl_flags = 0x100 nl_type = 2 error: -22 Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>		2023-06-12 11:32:44 +01:00
..
af_netlink.c	netlink: support extack in dump ->start()	2023-06-12 11:32:44 +01:00
af_netlink.h	netlink: remove unused 'compare' function	2023-03-09 23:11:09 -08:00
diag.c
genetlink.c	netlink: support extack in dump ->start()	2023-06-12 11:32:44 +01:00
Kconfig
Makefile
policy.c	net: genl: fix error path memory leak in policy dumping	2022-08-18 10:20:48 -07:00