linux-stable/fs/f2fs
Damien Le Moal 70d33cce97 f2fs: Fix use of number of devices
commit 0916878da3 upstream.

For a single device mount using a zoned block device, the zone
information for the device is stored in the sbi->devs single entry
array and sbi->s_ndevs is set to 1. This differs from a single device
mount using a regular block device which does not allocate sbi->devs
and sets sbi->s_ndevs to 0.

However, sbi->s_devs == 0 condition is used throughout the code to
differentiate a single device mount from a multi-device mount where
sbi->s_ndevs is always larger than 1. This results in problems with
single zoned block device volumes as these are treated as multi-device
mounts but do not have the start_blk and end_blk information set. One
of the problem observed is skipping of zone discard issuing resulting in
write commands being issued to full zones or unaligned to a zone write
pointer.

Fix this problem by simply treating the cases sbi->s_ndevs == 0 (single
regular block device mount) and sbi->s_ndevs == 1 (single zoned block
device mount) in the same manner. This is done by introducing the
helper function f2fs_is_multi_device() and using this helper in place
of direct tests of sbi->s_ndevs value, improving code readability.

Fixes: 7bb3a371d1 ("f2fs: Fix zoned block device support")
Cc: <stable@vger.kernel.org>
Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-05-31 06:46:00 -07:00
..
acl.c f2fs: fix wrong return value of f2fs_acl_create 2019-02-12 19:47:02 +01:00
acl.h f2fs: remove dead code f2fs_check_acl 2016-09-14 16:52:36 -07:00
checkpoint.c f2fs: fix to flush all dirty inodes recovered in readonly fs 2018-11-13 11:08:38 -08:00
data.c f2fs: Fix use of number of devices 2019-05-31 06:46:00 -07:00
debug.c f2fs: fix to avoid NULL pointer dereference on se->discard_map 2019-04-20 09:16:00 +02:00
dir.c f2fs: rework fault injection handling to avoid a warning 2018-08-14 09:49:15 -07:00
extent_cache.c f2fs: avoid sleeping under spin_lock 2018-11-13 11:08:37 -08:00
f2fs.h f2fs: Fix use of number of devices 2019-05-31 06:46:00 -07:00
file.c f2fs: Fix use of number of devices 2019-05-31 06:46:00 -07:00
gc.c f2fs: Fix use of number of devices 2019-05-31 06:46:00 -07:00
gc.h f2fs: introduce sbi->gc_mode to determine the policy 2018-05-31 11:31:51 -07:00
hash.c f2fs: check entire encrypted bigname when finding a dentry 2017-05-04 11:44:35 -04:00
inline.c f2fs: fix to avoid deadlock in f2fs_read_inline_dir() 2019-04-05 22:32:56 +02:00
inode.c f2fs: fix to recover cold bit of inode block during POR 2018-11-13 11:08:39 -08:00
Kconfig fs/*/Kconfig: drop links to 404-compliant http://acl.bestbits.at 2018-01-01 12:45:37 -07:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
namei.c f2fs: Replace strncpy with memcpy 2018-07-28 18:26:08 -07:00
node.c f2fs: read page index before freeing 2019-01-09 17:38:46 +01:00
node.h f2fs: let checkpoint flush dnode page of regular 2018-08-01 11:52:36 -07:00
recovery.c f2fs: cleanup dirty pages if recover failed 2019-04-20 09:16:02 +02:00
segment.c f2fs: Fix use of number of devices 2019-05-31 06:46:00 -07:00
segment.h f2fs: avoid fi->i_gc_rwsem[WRITE] lock in f2fs_gc 2018-08-20 23:13:42 -07:00
shrinker.c f2fs: fix sbi->extent_list corruption issue 2019-02-12 19:47:17 +01:00
super.c f2fs: cleanup dirty pages if recover failed 2019-04-20 09:16:02 +02:00
sysfs.c f2fs: UBSAN: set boolean value iostat_enable correctly 2019-04-05 22:33:14 +02:00
trace.c f2fs: do not use mutex lock in atomic context 2019-04-05 22:32:59 +02:00
trace.h
xattr.c f2fs: fix to adapt small inline xattr space in __find_inline_xattr() 2019-04-05 22:32:55 +02:00
xattr.h f2fs: guard macro variables with braces 2017-04-10 19:48:10 -07:00