Bob Peterson 04dd45d977 gfs2: assign rgrp glock before compute_bitstructs ... commit 428f651cb8 upstream. Before this patch, function read_rindex_entry called compute_bitstructs before it allocated a glock for the rgrp. But if compute_bitstructs found a problem with the rgrp, it called gfs2_consist_rgrpd, and that called gfs2_dump_glock for rgd->rd_gl which had not yet been assigned. read_rindex_entry compute_bitstructs gfs2_consist_rgrpd gfs2_dump_glock <---------rgd->rd_gl was not set. This patch changes read_rindex_entry so it assigns an rgrp glock before calling compute_bitstructs so gfs2_dump_glock does not reference an unassigned pointer. If an error is discovered, the glock must also be put, so a new goto and label were added. Reported-by: syzbot+c6fd14145e2f62ca0784@syzkaller.appspotmail.com Signed-off-by: Bob Peterson <rpeterso@redhat.com> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-04-27 13:53:46 +02:00
..
acl.c	gfs2: Change inode qa_data to allow multiple users	2020-03-27 14:08:04 -05:00
acl.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 398	2019-06-05 17:37:12 +02:00
aops.c	gfs2: Fix case in which ail writes are done to jdata holes	2020-11-12 18:55:20 +01:00
aops.h	gfs2: mark stuffed_readpage static	2019-07-03 14:45:18 +02:00
bmap.c	gfs2: gfs2_setattr_size error path fix	2022-04-13 21:00:54 +02:00
bmap.h	gfs2: use iomap for buffered I/O in ordered and writeback mode	2020-10-14 23:54:42 +02:00
dentry.c	gfs2: untangle the logic in gfs2_drevalidate	2019-09-03 09:42:41 +02:00
dir.c	mm: remove the pgprot argument to __vmalloc	2020-06-02 10:59:11 -07:00
dir.h	gfs2: Delete an unnecessary check before brelse()	2019-09-04 20:22:17 +02:00
export.c	gfs2: Minor gfs2_lookup_by_inum cleanup	2020-06-05 20:19:21 +02:00
file.c	gfs2: gfs2_setattr_size error path fix	2022-04-13 21:00:54 +02:00
gfs2.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 398	2019-06-05 17:37:12 +02:00
glock.c	gfs2: Fix glock_hash_walk bugs	2021-11-18 14:04:00 +01:00
glock.h	Merge branch 'gfs2-iopen' into for-next	2020-06-05 21:25:36 +02:00
glops.c	gfs2: Fix glock recursion in freeze_go_xmote_bh	2021-09-18 13:40:25 +02:00
glops.h	gfs2: Split up gfs2_meta_sync into inode and rgrp versions	2020-10-29 22:16:46 +01:00
incore.h	gfs2: set lockdep subclass for iopen glocks	2020-11-24 23:45:58 +01:00
inode.c	gfs2: gfs2_setattr_size error path fix	2022-04-13 21:00:54 +02:00
inode.h	gfs2: Minor gfs2_lookup_by_inum cleanup	2020-06-05 20:19:21 +02:00
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
lock_dlm.c	gfs2: Don't call dlm after protocol is unmounted	2021-09-18 13:40:30 +02:00
log.c	treewide: Change list_sort to use const pointers	2021-09-30 10:11:04 +02:00
log.h	gfs2: Wipe jdata and ail1 in gfs2_journal_wipe, formerly gfs2_meta_wipe	2020-10-15 14:29:03 +02:00
lops.c	treewide: Change list_sort to use const pointers	2021-09-30 10:11:04 +02:00
lops.h	gfs2: Split up gfs2_meta_sync into inode and rgrp versions	2020-10-29 22:16:46 +01:00
main.c	gfs2: eliminate GIF_ORDERED in favor of list_empty	2020-07-03 12:05:34 +02:00
Makefile
meta_io.c	gfs2: Wipe jdata and ail1 in gfs2_journal_wipe, formerly gfs2_meta_wipe	2020-10-15 14:29:03 +02:00
meta_io.h	gfs2: Wipe jdata and ail1 in gfs2_journal_wipe, formerly gfs2_meta_wipe	2020-10-15 14:29:03 +02:00
ops_fstype.c	gfs2: init system threads before freeze lock	2021-09-15 09:50:42 +02:00
quota.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
quota.h	gfs2: move privileged user check to gfs2_quota_lock_check	2020-05-08 18:47:58 +02:00
recovery.c	gfs2: Add common helper for holding and releasing the freeze glock	2021-03-25 09:04:14 +01:00
recovery.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 398	2019-06-05 17:37:12 +02:00
rgrp.c	gfs2: assign rgrp glock before compute_bitstructs	2022-04-27 13:53:46 +02:00
rgrp.h	gfs2: gfs2_setattr_size error path fix	2022-04-13 21:00:54 +02:00
super.c	gfs2: gfs2_setattr_size error path fix	2022-04-13 21:00:54 +02:00
super.h	gfs2: lookup local statfs inodes prior to journal recovery	2020-10-23 15:47:14 +02:00
sys.c	gfs2: use-after-free in sysfs deregistration	2020-10-14 23:54:43 +02:00
sys.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 398	2019-06-05 17:37:12 +02:00
trace_gfs2.h	gfs2: eliminate GLF_QUEUED flag in favor of list_empty(gl_holders)	2020-10-15 17:04:53 +02:00
trans.c	gfs2: fix use-after-free in trans_drain	2021-03-30 14:31:49 +02:00
trans.h	gfs2: new slab for transactions	2020-06-05 21:24:25 +02:00
util.c	gfs2: bypass signal_our_withdraw if no journal	2021-03-25 09:04:14 +01:00
util.h	gfs2: Add common helper for holding and releasing the freeze glock	2021-03-25 09:04:14 +01:00
xattr.c	gfs2: Change inode qa_data to allow multiple users	2020-03-27 14:08:04 -05:00
xattr.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 398	2019-06-05 17:37:12 +02:00