Lukas Wunner 4c79dd14c1 serial: 8250: Avoid error message on reprobe ... commit e0a851fe6b upstream. If the call to uart_add_one_port() in serial8250_register_8250_port() fails, a half-initialized entry in the serial_8250ports[] array is left behind. A subsequent reprobe of the same serial port causes that entry to be reused. Because uart->port.dev is set, uart_remove_one_port() is called for the half-initialized entry and bails out with an error message: bcm2835-aux-uart 3f215040.serial: Removing wrong port: (null) != (ptrval) The same happens on failure of mctrl_gpio_init() since commit 4a96895f74 ("tty/serial/8250: use mctrl_gpio helpers"). Fix by zeroing the uart->port.dev pointer in the probe error path. The bug was introduced in v2.6.10 by historical commit befff6f5bf5f ("[SERIAL] Add new port registration/unregistration functions."): https://git.kernel.org/tglx/history/c/befff6f5bf5f The commit added an unconditional call to uart_remove_one_port() in serial8250_register_port(). In v3.7, commit 835d844d1a ("8250_pnp: do pnp probe before legacy probe") made that call conditional on uart->port.dev which allows me to fix the issue by zeroing that pointer in the error path. Thus, the present commit will fix the problem as far back as v3.7 whereas still older versions need to also cherry-pick 835d844d1a. Fixes: 835d844d1a ("8250_pnp: do pnp probe before legacy probe") Signed-off-by: Lukas Wunner <lukas@wunner.de> Cc: stable@vger.kernel.org # v2.6.10 Cc: stable@vger.kernel.org # v2.6.10: 835d844d1a: 8250_pnp: do pnp probe before legacy Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/b4a072013ee1a1d13ee06b4325afb19bda57ca1b.1589285873.git.lukas@wunner.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-06-22 09:31:18 +02:00
..
hvc	tty: hvc_console, fix crashes on parallel open/close	2020-06-10 20:24:56 +02:00
ipwireless
serdev	serdev: ttyport: restore client ops on deregistration	2020-02-28 17:22:19 +01:00
serial	serial: 8250: Avoid error message on reprobe	2020-06-22 09:31:18 +02:00
vt	vt: keyboard: avoid signed integer overflow in k_ascii	2020-06-10 20:24:56 +02:00
amiserial.c
cyclades.c
ehv_bytechan.c	tty: evh_bytechan: Fix out of bounds accesses	2020-04-23 10:36:44 +02:00
goldfish.c
isicom.c
Kconfig
Makefile
mips_ejtag_fdc.c
moxa.c
moxa.h
mxser.c
mxser.h
n_gsm.c	tty: n_gsm: avoid recursive locking with async port hangup	2019-09-04 12:43:56 +02:00
n_hdlc.c	tty: n_hdlc: fix build on SPARC	2019-10-04 15:14:20 +02:00
n_null.c
n_r3964.c
n_tracerouter.c
n_tracesink.c
n_tracesink.h
n_tty.c
nozomi.c
pty.c
rocket.c	tty: rocket, avoid OOB access	2020-04-29 16:33:17 +02:00
rocket.h
rocket_int.h
synclink.c
synclink_gt.c	tty: synclink_gt: Adjust indentation in several functions	2020-02-24 08:36:47 +01:00
synclinkmp.c	tty: synclinkmp: Adjust indentation in several functions	2020-02-24 08:36:47 +01:00
sysrq.c
tty_audit.c
tty_baudrate.c
tty_buffer.c
tty_io.c	tty: fix compat TIOCGSERIAL checking wrong function ptr	2020-03-25 08:25:52 +01:00
tty_ioctl.c
tty_jobctrl.c
tty_ldisc.c
tty_ldsem.c
tty_mutex.c
tty_port.c	serdev: ttyport: restore client ops on deregistration	2020-02-28 17:22:19 +01:00
ttynull.c
vcc.c