mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-28 05:12:49 +00:00
e552b7be12
If the kernel exposes a new perf_event_attr field in a format attr, perf
will return an error stating the specified PMU can't be found. For
example, a format attr with 'config3:0-63' causes an error as config3 is
unknown to perf. This causes a compatibility issue between a newer
kernel with older perf tool.
Before this change with a kernel adding 'config3' I get:
$ perf record -e arm_spe// -- true
event syntax error: 'arm_spe//'
\___ Cannot find PMU `arm_spe'. Missing kernel support?
Run 'perf list' for a list of valid events
Usage: perf record [<options>] [<command>]
or: perf record [<options>] -- <command> [<options>]
-e, --event <event> event selector. use 'perf list' to list
available events
After this change, I get:
$ perf record -e arm_spe// -- true
WARNING: 'arm_spe_0' format 'inv_event_filter' requires 'perf_event_attr::config3' which is not supported by this version of perf!
[ perf record: Woken up 2 times to write data ]
[ perf record: Captured and wrote 0.091 MB perf.data ]
To support unknown configN formats, rework the YACC implementation to
pass any config[0-9]+ format to perf_pmu__new_format() to handle with a
warning.
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Tested-by: Leo Yan <leo.yan@linaro.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20220914-arm-perf-tool-spe1-2-v2-v4-1-83c098e6212e@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
83 lines
1.1 KiB
Text
83 lines
1.1 KiB
Text
|
|
%parse-param {struct list_head *format}
|
|
%parse-param {char *name}
|
|
|
|
%{
|
|
|
|
#include <linux/compiler.h>
|
|
#include <linux/list.h>
|
|
#include <linux/bitmap.h>
|
|
#include <string.h>
|
|
#include "pmu.h"
|
|
|
|
#define ABORT_ON(val) \
|
|
do { \
|
|
if (val) \
|
|
YYABORT; \
|
|
} while (0)
|
|
|
|
%}
|
|
|
|
%token PP_CONFIG
|
|
%token PP_VALUE PP_ERROR
|
|
%type <num> PP_VALUE
|
|
%type <bits> bit_term
|
|
%type <bits> bits
|
|
|
|
%union
|
|
{
|
|
unsigned long num;
|
|
DECLARE_BITMAP(bits, PERF_PMU_FORMAT_BITS);
|
|
}
|
|
|
|
%%
|
|
|
|
format:
|
|
format format_term
|
|
|
|
|
format_term
|
|
|
|
format_term:
|
|
PP_CONFIG ':' bits
|
|
{
|
|
ABORT_ON(perf_pmu__new_format(format, name,
|
|
PERF_PMU_FORMAT_VALUE_CONFIG,
|
|
$3));
|
|
}
|
|
|
|
|
PP_CONFIG PP_VALUE ':' bits
|
|
{
|
|
ABORT_ON(perf_pmu__new_format(format, name,
|
|
$2,
|
|
$4));
|
|
}
|
|
|
|
bits:
|
|
bits ',' bit_term
|
|
{
|
|
bitmap_or($$, $1, $3, 64);
|
|
}
|
|
|
|
|
bit_term
|
|
{
|
|
memcpy($$, $1, sizeof($1));
|
|
}
|
|
|
|
bit_term:
|
|
PP_VALUE '-' PP_VALUE
|
|
{
|
|
perf_pmu__set_format($$, $1, $3);
|
|
}
|
|
|
|
|
PP_VALUE
|
|
{
|
|
perf_pmu__set_format($$, $1, 0);
|
|
}
|
|
|
|
%%
|
|
|
|
void perf_pmu_error(struct list_head *list __maybe_unused,
|
|
char *name __maybe_unused,
|
|
char const *msg __maybe_unused)
|
|
{
|
|
}
|