mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-08-28 03:40:04 +00:00
Code Issues Releases Wiki Activity
linux-stable/drivers/interconnect/qcom
History
Mike Tipton 9c0c54a8da interconnect: qcom: Fix uninitialized tcs_cmd::wait 
Currently, if tcs_cmd_gen is called with commit=false, then
tcs_cmd::wait is left uninitialized. Since the tcs_cmd structures passed
to this function aren't zero-initialized, then we're left with random
wait values. This results in waiting for completion for more commands
than is necessary, depending on what's on the stack at the time.

Removing the unnecessary if-condition fixes this, but add an explicit
memset of the tcs_cmd structure as well to ensure predictable behavior
if more tcs_cmd members are added in the future.

Fixes: 976daac4a1 ("interconnect: qcom: Consolidate interconnect RPMh support")
Signed-off-by: Mike Tipton <mdtipton@codeaurora.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20200319231021.18108-1-mdtipton@codeaurora.org
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
Link: https://lore.kernel.org/r/20200415130327.23059-2-georgi.djakov@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-04-23 16:18:07 +02:00
..
bcm-voter.c interconnect: qcom: Fix uninitialized tcs_cmd::wait 2020-04-23 16:18:07 +02:00
bcm-voter.h interconnect: qcom: Consolidate interconnect RPMh support 2020-02-28 12:11:40 +02:00
icc-rpmh.c interconnect: qcom: Consolidate interconnect RPMh support 2020-02-28 12:11:40 +02:00
icc-rpmh.h interconnect: qcom: Consolidate interconnect RPMh support 2020-02-28 12:11:40 +02:00
Kconfig interconnect: qcom: Add OSM L3 interconnect provider support 2020-03-03 19:02:52 +02:00
Makefile interconnect: qcom: Add OSM L3 interconnect provider support 2020-03-03 19:02:52 +02:00
msm8916.c interconnect: qcom: Add MSM8916 interconnect provider driver 2020-01-07 09:30:09 +02:00
msm8974.c interconnect: qcom: Use the standard aggregate function 2019-12-16 09:25:24 +02:00
osm-l3.c interconnect: qcom: Add OSM L3 support on SC7180 2020-03-03 19:02:52 +02:00
qcs404.c interconnect: qcom: Use the standard aggregate function 2019-12-16 09:25:24 +02:00
sc7180.c interconnect: qcom: Add SC7180 interconnect provider driver 2020-03-03 19:02:52 +02:00
sc7180.h interconnect: qcom: Add OSM L3 support on SC7180 2020-03-03 19:02:52 +02:00
sdm845.c interconnect: qcom: Allow icc node to be used across icc providers 2020-03-03 19:02:52 +02:00
sdm845.h interconnect: qcom: Add OSM L3 interconnect provider support 2020-03-03 19:02:52 +02:00
smd-rpm.c interconnect: qcom: Add interconnect RPM over SMD driver 2019-08-13 23:06:40 +03:00
smd-rpm.h interconnect: qcom: Add interconnect RPM over SMD driver 2019-08-13 23:06:40 +03:00