mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 00:10:09 +00:00
e190a0c389
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Alain Volmat <alain.volmat@foss.st.com> Acked-by: Ard Biesheuvel <ardb@kernel.org> Acked-by: Baruch Siach <baruch@tkos.co.il> Acked-by: Florian Fainelli <f.fainelli@gmail.com> Acked-by: Heiko Stuebner <heiko@sntech.de> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Acked-by: Jochen Friedrich <jochen@scram.de> Acked-by: Peter Rosin <peda@axentia.se> Acked-by: Vadim Pasternak <vadimp@nvidia.com> Reviewed-by: Asmaa Mnebhi <asnaa@nvidia.com> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz> Reviewed-by: Chris Pringle <chris.pringle@phabrix.com> Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Jean Delvare <jdelvare@suse.de> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com> Reviewed-by: Tali Perry <tali.perry@nuvoton.com> Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com> Signed-off-by: Wolfram Sang <wsa@kernel.org>
155 lines
3.1 KiB
C
155 lines
3.1 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) 2005 Simtec Electronics
|
|
* Ben Dooks <ben@simtec.co.uk>
|
|
*
|
|
* Simtec Generic I2C Controller
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/io.h>
|
|
|
|
#include <linux/i2c.h>
|
|
#include <linux/i2c-algo-bit.h>
|
|
|
|
struct simtec_i2c_data {
|
|
struct resource *ioarea;
|
|
void __iomem *reg;
|
|
struct i2c_adapter adap;
|
|
struct i2c_algo_bit_data bit;
|
|
};
|
|
|
|
#define CMD_SET_SDA (1<<2)
|
|
#define CMD_SET_SCL (1<<3)
|
|
|
|
#define STATE_SDA (1<<0)
|
|
#define STATE_SCL (1<<1)
|
|
|
|
/* i2c bit-bus functions */
|
|
|
|
static void simtec_i2c_setsda(void *pw, int state)
|
|
{
|
|
struct simtec_i2c_data *pd = pw;
|
|
writeb(CMD_SET_SDA | (state ? STATE_SDA : 0), pd->reg);
|
|
}
|
|
|
|
static void simtec_i2c_setscl(void *pw, int state)
|
|
{
|
|
struct simtec_i2c_data *pd = pw;
|
|
writeb(CMD_SET_SCL | (state ? STATE_SCL : 0), pd->reg);
|
|
}
|
|
|
|
static int simtec_i2c_getsda(void *pw)
|
|
{
|
|
struct simtec_i2c_data *pd = pw;
|
|
return readb(pd->reg) & STATE_SDA ? 1 : 0;
|
|
}
|
|
|
|
static int simtec_i2c_getscl(void *pw)
|
|
{
|
|
struct simtec_i2c_data *pd = pw;
|
|
return readb(pd->reg) & STATE_SCL ? 1 : 0;
|
|
}
|
|
|
|
/* device registration */
|
|
|
|
static int simtec_i2c_probe(struct platform_device *dev)
|
|
{
|
|
struct simtec_i2c_data *pd;
|
|
struct resource *res;
|
|
int size;
|
|
int ret;
|
|
|
|
pd = kzalloc(sizeof(struct simtec_i2c_data), GFP_KERNEL);
|
|
if (pd == NULL)
|
|
return -ENOMEM;
|
|
|
|
platform_set_drvdata(dev, pd);
|
|
|
|
res = platform_get_resource(dev, IORESOURCE_MEM, 0);
|
|
if (res == NULL) {
|
|
dev_err(&dev->dev, "cannot find IO resource\n");
|
|
ret = -ENOENT;
|
|
goto err;
|
|
}
|
|
|
|
size = resource_size(res);
|
|
|
|
pd->ioarea = request_mem_region(res->start, size, dev->name);
|
|
if (pd->ioarea == NULL) {
|
|
dev_err(&dev->dev, "cannot request IO\n");
|
|
ret = -ENXIO;
|
|
goto err;
|
|
}
|
|
|
|
pd->reg = ioremap(res->start, size);
|
|
if (pd->reg == NULL) {
|
|
dev_err(&dev->dev, "cannot map IO\n");
|
|
ret = -ENXIO;
|
|
goto err_res;
|
|
}
|
|
|
|
/* setup the private data */
|
|
|
|
pd->adap.owner = THIS_MODULE;
|
|
pd->adap.algo_data = &pd->bit;
|
|
pd->adap.dev.parent = &dev->dev;
|
|
|
|
strscpy(pd->adap.name, "Simtec I2C", sizeof(pd->adap.name));
|
|
|
|
pd->bit.data = pd;
|
|
pd->bit.setsda = simtec_i2c_setsda;
|
|
pd->bit.setscl = simtec_i2c_setscl;
|
|
pd->bit.getsda = simtec_i2c_getsda;
|
|
pd->bit.getscl = simtec_i2c_getscl;
|
|
pd->bit.timeout = HZ;
|
|
pd->bit.udelay = 20;
|
|
|
|
ret = i2c_bit_add_bus(&pd->adap);
|
|
if (ret)
|
|
goto err_all;
|
|
|
|
return 0;
|
|
|
|
err_all:
|
|
iounmap(pd->reg);
|
|
|
|
err_res:
|
|
release_mem_region(pd->ioarea->start, size);
|
|
|
|
err:
|
|
kfree(pd);
|
|
return ret;
|
|
}
|
|
|
|
static void simtec_i2c_remove(struct platform_device *dev)
|
|
{
|
|
struct simtec_i2c_data *pd = platform_get_drvdata(dev);
|
|
|
|
i2c_del_adapter(&pd->adap);
|
|
|
|
iounmap(pd->reg);
|
|
release_mem_region(pd->ioarea->start, resource_size(pd->ioarea));
|
|
kfree(pd);
|
|
}
|
|
|
|
/* device driver */
|
|
|
|
static struct platform_driver simtec_i2c_driver = {
|
|
.driver = {
|
|
.name = "simtec-i2c",
|
|
},
|
|
.probe = simtec_i2c_probe,
|
|
.remove_new = simtec_i2c_remove,
|
|
};
|
|
|
|
module_platform_driver(simtec_i2c_driver);
|
|
|
|
MODULE_DESCRIPTION("Simtec Generic I2C Bus driver");
|
|
MODULE_AUTHOR("Ben Dooks <ben@simtec.co.uk>");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_ALIAS("platform:simtec-i2c");
|