mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 16:29:59 +00:00
![Ian Rogers](/assets/img/avatar_default.png)
The code required threads to be deleted before machine__exit was called or the threads would be leaked. This was error prone so move the delete_threads into machine__exit. Signed-off-by: Ian Rogers <irogers@google.com> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Ali Saidi <alisaidi@amazon.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com> Cc: Brian Robbins <brianrob@linux.microsoft.com> Cc: Changbin Du <changbin.du@huawei.com> Cc: Dmitrii Dolgov <9erthalion6@gmail.com> Cc: Fangrui Song <maskray@google.com> Cc: German Gomez <german.gomez@arm.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Ivan Babrou <ivan@cloudflare.com> Cc: James Clark <james.clark@arm.com> Cc: Jing Zhang <renyu.zj@linux.alibaba.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: John Garry <john.g.garry@oracle.com> Cc: K Prateek Nayak <kprateek.nayak@amd.com> Cc: Kan Liang <kan.liang@linux.intel.com> Cc: Leo Yan <leo.yan@linaro.org> Cc: Liam Howlett <liam.howlett@oracle.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Miguel Ojeda <ojeda@kernel.org> Cc: Mike Leach <mike.leach@linaro.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Ravi Bangoria <ravi.bangoria@amd.com> Cc: Sean Christopherson <seanjc@google.com> Cc: Steinar H. Gunderson <sesse@google.com> Cc: Suzuki Poulouse <suzuki.poulose@arm.com> Cc: Wenyu Liu <liuwenyu7@huawei.com> Cc: Will Deacon <will@kernel.org> Cc: Yang Jihong <yangjihong1@huawei.com> Cc: Ye Xingchen <ye.xingchen@zte.com.cn> Cc: Yuan Can <yuancan@huawei.com> Cc: coresight@lists.linaro.org Cc: linux-arm-kernel@lists.infradead.org Link: https://lore.kernel.org/r/20230608232823.4027869-9-irogers@google.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
152 lines
3 KiB
C
152 lines
3 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include <linux/compiler.h>
|
|
#include <linux/string.h>
|
|
#include <sys/mman.h>
|
|
#include <limits.h>
|
|
#include "debug.h"
|
|
#include "dso.h"
|
|
#include "machine.h"
|
|
#include "thread.h"
|
|
#include "symbol.h"
|
|
#include "map.h"
|
|
#include "util.h"
|
|
#include "tests.h"
|
|
|
|
struct test_info {
|
|
struct machine *machine;
|
|
struct thread *thread;
|
|
};
|
|
|
|
static int init_test_info(struct test_info *ti)
|
|
{
|
|
ti->machine = machine__new_host();
|
|
if (!ti->machine) {
|
|
pr_debug("machine__new_host() failed!\n");
|
|
return TEST_FAIL;
|
|
}
|
|
|
|
/* Create a dummy thread */
|
|
ti->thread = machine__findnew_thread(ti->machine, 100, 100);
|
|
if (!ti->thread) {
|
|
pr_debug("machine__findnew_thread() failed!\n");
|
|
return TEST_FAIL;
|
|
}
|
|
|
|
return TEST_OK;
|
|
}
|
|
|
|
static void exit_test_info(struct test_info *ti)
|
|
{
|
|
thread__put(ti->thread);
|
|
machine__delete(ti->machine);
|
|
}
|
|
|
|
static void get_test_dso_filename(char *filename, size_t max_sz)
|
|
{
|
|
if (dso_to_test)
|
|
strlcpy(filename, dso_to_test, max_sz);
|
|
else
|
|
perf_exe(filename, max_sz);
|
|
}
|
|
|
|
static int create_map(struct test_info *ti, char *filename, struct map **map_p)
|
|
{
|
|
/* Create a dummy map at 0x100000 */
|
|
*map_p = map__new(ti->machine, 0x100000, 0xffffffff, 0, NULL,
|
|
PROT_EXEC, 0, NULL, filename, ti->thread);
|
|
if (!*map_p) {
|
|
pr_debug("Failed to create map!");
|
|
return TEST_FAIL;
|
|
}
|
|
|
|
return TEST_OK;
|
|
}
|
|
|
|
static int test_dso(struct dso *dso)
|
|
{
|
|
struct symbol *last_sym = NULL;
|
|
struct rb_node *nd;
|
|
int ret = TEST_OK;
|
|
|
|
/* dso__fprintf() prints all the symbols */
|
|
if (verbose > 1)
|
|
dso__fprintf(dso, stderr);
|
|
|
|
for (nd = rb_first_cached(&dso->symbols); nd; nd = rb_next(nd)) {
|
|
struct symbol *sym = rb_entry(nd, struct symbol, rb_node);
|
|
|
|
if (sym->type != STT_FUNC && sym->type != STT_GNU_IFUNC)
|
|
continue;
|
|
|
|
/* Check for overlapping function symbols */
|
|
if (last_sym && sym->start < last_sym->end) {
|
|
pr_debug("Overlapping symbols:\n");
|
|
symbol__fprintf(last_sym, stderr);
|
|
symbol__fprintf(sym, stderr);
|
|
ret = TEST_FAIL;
|
|
}
|
|
/* Check for zero-length function symbol */
|
|
if (sym->start == sym->end) {
|
|
pr_debug("Zero-length symbol:\n");
|
|
symbol__fprintf(sym, stderr);
|
|
ret = TEST_FAIL;
|
|
}
|
|
last_sym = sym;
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int test_file(struct test_info *ti, char *filename)
|
|
{
|
|
struct map *map = NULL;
|
|
int ret, nr;
|
|
struct dso *dso;
|
|
|
|
pr_debug("Testing %s\n", filename);
|
|
|
|
ret = create_map(ti, filename, &map);
|
|
if (ret != TEST_OK)
|
|
return ret;
|
|
|
|
dso = map__dso(map);
|
|
nr = dso__load(dso, map);
|
|
if (nr < 0) {
|
|
pr_debug("dso__load() failed!\n");
|
|
ret = TEST_FAIL;
|
|
goto out_put;
|
|
}
|
|
|
|
if (nr == 0) {
|
|
pr_debug("DSO has no symbols!\n");
|
|
ret = TEST_SKIP;
|
|
goto out_put;
|
|
}
|
|
|
|
ret = test_dso(dso);
|
|
out_put:
|
|
map__put(map);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int test__symbols(struct test_suite *test __maybe_unused, int subtest __maybe_unused)
|
|
{
|
|
char filename[PATH_MAX];
|
|
struct test_info ti;
|
|
int ret;
|
|
|
|
ret = init_test_info(&ti);
|
|
if (ret != TEST_OK)
|
|
return ret;
|
|
|
|
get_test_dso_filename(filename, sizeof(filename));
|
|
|
|
ret = test_file(&ti, filename);
|
|
|
|
exit_test_info(&ti);
|
|
|
|
return ret;
|
|
}
|
|
|
|
DEFINE_SUITE("Symbols", symbols);
|