mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-10 18:53:38 +00:00
4a92602aa1
Operations with the GENL_ADMIN_PERM flag fail permissions checks because
this flag means we call netlink_capable, which uses the init user ns.
Instead, let's introduce a new flag, GENL_UNS_ADMIN_PERM for operations
which should be allowed inside a user namespace.
The motivation for this is to be able to run openvswitch in unprivileged
containers. I've tested this and it seems to work, but I really have no
idea about the security consequences of this patch, so thoughts would be
much appreciated.
v2: use the GENL_UNS_ADMIN_PERM flag instead of a check in each function
v3: use separate ifs for UNS_ADMIN_PERM and ADMIN_PERM, instead of one
massive one
Reported-by: James Page <james.page@canonical.com>
Signed-off-by: Tycho Andersen <tycho.andersen@canonical.com>
CC: Eric Biederman <ebiederm@xmission.com>
CC: Pravin Shelar <pshelar@ovn.org>
CC: Justin Pettit <jpettit@nicira.com>
CC: "David S. Miller" <davem@davemloft.net>
Acked-by: Pravin B Shelar <pshelar@ovn.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
87 lines
1.8 KiB
C
87 lines
1.8 KiB
C
#ifndef _UAPI__LINUX_GENERIC_NETLINK_H
|
|
#define _UAPI__LINUX_GENERIC_NETLINK_H
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/netlink.h>
|
|
|
|
#define GENL_NAMSIZ 16 /* length of family name */
|
|
|
|
#define GENL_MIN_ID NLMSG_MIN_TYPE
|
|
#define GENL_MAX_ID 1023
|
|
|
|
struct genlmsghdr {
|
|
__u8 cmd;
|
|
__u8 version;
|
|
__u16 reserved;
|
|
};
|
|
|
|
#define GENL_HDRLEN NLMSG_ALIGN(sizeof(struct genlmsghdr))
|
|
|
|
#define GENL_ADMIN_PERM 0x01
|
|
#define GENL_CMD_CAP_DO 0x02
|
|
#define GENL_CMD_CAP_DUMP 0x04
|
|
#define GENL_CMD_CAP_HASPOL 0x08
|
|
#define GENL_UNS_ADMIN_PERM 0x10
|
|
|
|
/*
|
|
* List of reserved static generic netlink identifiers:
|
|
*/
|
|
#define GENL_ID_GENERATE 0
|
|
#define GENL_ID_CTRL NLMSG_MIN_TYPE
|
|
#define GENL_ID_VFS_DQUOT (NLMSG_MIN_TYPE + 1)
|
|
#define GENL_ID_PMCRAID (NLMSG_MIN_TYPE + 2)
|
|
|
|
/**************************************************************************
|
|
* Controller
|
|
**************************************************************************/
|
|
|
|
enum {
|
|
CTRL_CMD_UNSPEC,
|
|
CTRL_CMD_NEWFAMILY,
|
|
CTRL_CMD_DELFAMILY,
|
|
CTRL_CMD_GETFAMILY,
|
|
CTRL_CMD_NEWOPS,
|
|
CTRL_CMD_DELOPS,
|
|
CTRL_CMD_GETOPS,
|
|
CTRL_CMD_NEWMCAST_GRP,
|
|
CTRL_CMD_DELMCAST_GRP,
|
|
CTRL_CMD_GETMCAST_GRP, /* unused */
|
|
__CTRL_CMD_MAX,
|
|
};
|
|
|
|
#define CTRL_CMD_MAX (__CTRL_CMD_MAX - 1)
|
|
|
|
enum {
|
|
CTRL_ATTR_UNSPEC,
|
|
CTRL_ATTR_FAMILY_ID,
|
|
CTRL_ATTR_FAMILY_NAME,
|
|
CTRL_ATTR_VERSION,
|
|
CTRL_ATTR_HDRSIZE,
|
|
CTRL_ATTR_MAXATTR,
|
|
CTRL_ATTR_OPS,
|
|
CTRL_ATTR_MCAST_GROUPS,
|
|
__CTRL_ATTR_MAX,
|
|
};
|
|
|
|
#define CTRL_ATTR_MAX (__CTRL_ATTR_MAX - 1)
|
|
|
|
enum {
|
|
CTRL_ATTR_OP_UNSPEC,
|
|
CTRL_ATTR_OP_ID,
|
|
CTRL_ATTR_OP_FLAGS,
|
|
__CTRL_ATTR_OP_MAX,
|
|
};
|
|
|
|
#define CTRL_ATTR_OP_MAX (__CTRL_ATTR_OP_MAX - 1)
|
|
|
|
enum {
|
|
CTRL_ATTR_MCAST_GRP_UNSPEC,
|
|
CTRL_ATTR_MCAST_GRP_NAME,
|
|
CTRL_ATTR_MCAST_GRP_ID,
|
|
__CTRL_ATTR_MCAST_GRP_MAX,
|
|
};
|
|
|
|
#define CTRL_ATTR_MCAST_GRP_MAX (__CTRL_ATTR_MCAST_GRP_MAX - 1)
|
|
|
|
|
|
#endif /* _UAPI__LINUX_GENERIC_NETLINK_H */
|