Cong Wang 543e28206b bpf, sock_map: Move cancel_work_sync() out of sock lock ... [ Upstream commit 8bbabb3fdd ] Stanislav reported a lockdep warning, which is caused by the cancel_work_sync() called inside sock_map_close(), as analyzed below by Jakub: psock->work.func = sk_psock_backlog() ACQUIRE psock->work_mutex sk_psock_handle_skb() skb_send_sock() __skb_send_sock() sendpage_unlocked() kernel_sendpage() sock->ops->sendpage = inet_sendpage() sk->sk_prot->sendpage = tcp_sendpage() ACQUIRE sk->sk_lock tcp_sendpage_locked() RELEASE sk->sk_lock RELEASE psock->work_mutex sock_map_close() ACQUIRE sk->sk_lock sk_psock_stop() sk_psock_clear_state(psock, SK_PSOCK_TX_ENABLED) cancel_work_sync() __cancel_work_timer() __flush_work() // wait for psock->work to finish RELEASE sk->sk_lock We can move the cancel_work_sync() out of the sock lock protection, but still before saved_close() was called. Fixes: 799aa7f98d ("skmsg: Avoid lock_sock() in sk_psock_backlog()") Reported-by: Stanislav Fomichev <sdf@google.com> Signed-off-by: Cong Wang <cong.wang@bytedance.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Tested-by: Jakub Sitnicki <jakub@cloudflare.com> Acked-by: John Fastabend <john.fastabend@gmail.com> Acked-by: Jakub Sitnicki <jakub@cloudflare.com> Link: https://lore.kernel.org/bpf/20221102043417.279409-1-xiyou.wangcong@gmail.com Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-11-16 10:03:52 +01:00
..
acpi	ACPI: APEI: Fix integer overflow in ghes_estatus_pool_init()	2022-11-10 18:17:24 +01:00
asm-generic	arm64 fixes for -rc7	2022-09-23 15:28:51 -07:00
clocksource
crypto
drm	drm/edid: Handle EDID 1.4 range descriptor h/vfreq offsets	2022-09-02 16:38:51 +03:00
dt-bindings	dt-bindings: clock: exynosautov9: correct clock numbering of peric0/c1	2022-10-21 12:38:32 +02:00
keys
kunit	kunit: fix assert_type for comparison macros	2022-09-01 13:00:32 -06:00
kvm
linux	bpf, sock_map: Move cancel_work_sync() out of sock lock	2022-11-16 10:03:52 +01:00
math-emu
media	media: v4l: subdev: Fail graciously when getting try data for NULL state	2022-11-10 18:17:24 +01:00
memory
misc
net	net: remove SOCK_SUPPORT_ZC from sockmap	2022-11-10 18:17:35 +01:00
pcmcia
ras	mm, hwpoison: enable memory error handling on 1GB hugepage	2022-08-08 18:06:44 -07:00
rdma
rv
scsi	scsi: stex: Properly zero out the passthrough command structure	2022-10-15 08:02:56 +02:00
soc	AT91 fixes for 6.0	2022-09-02 11:29:03 +02:00
sound	ASoC: Intel: common: add ACPI matching tables for Raptor Lake	2022-11-04 00:00:28 +09:00
target
trace	ARM: SoC fixes for 6.0-rc6	2022-09-22 11:10:11 -07:00
uapi	media: videodev2.h: V4L2_DV_BT_BLANKING_HEIGHT should check 'interlaced'	2022-11-04 00:00:32 +09:00
ufs	scsi: ufs: core: Enable link lost interrupt	2022-08-11 22:04:32 -04:00
vdso
video
xen	x86/xen: Add support for HVMOP_set_evtchn_upcall_vector	2022-08-12 11:28:21 +02:00