mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-27 04:47:05 +00:00
c1e07a80cf
skel->links.oncpu is leaked in one case. This causes test perf_branches
fails when it runs after get_stackid_cannot_attach:
./test_progs -t get_stackid_cannot_attach,perf_branches
84 get_stackid_cannot_attach:OK
test_perf_branches_common:PASS:test_perf_branches_load 0 nsec
test_perf_branches_common:PASS:attach_perf_event 0 nsec
test_perf_branches_common:PASS:set_affinity 0 nsec
check_good_sample:FAIL:output not valid no valid sample from prog
146/1 perf_branches/perf_branches_hw:FAIL
146/2 perf_branches/perf_branches_no_hw:OK
146 perf_branches:FAIL
All error logs:
test_perf_branches_common:PASS:test_perf_branches_load 0 nsec
test_perf_branches_common:PASS:attach_perf_event 0 nsec
test_perf_branches_common:PASS:set_affinity 0 nsec
check_good_sample:FAIL:output not valid no valid sample from prog
146/1 perf_branches/perf_branches_hw:FAIL
146 perf_branches:FAIL
Summary: 1/1 PASSED, 0 SKIPPED, 1 FAILED
Fix this by adding the missing bpf_link__destroy().
Fixes: 346938e938 ("selftests/bpf: Add get_stackid_cannot_attach")
Signed-off-by: Song Liu <song@kernel.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20230412210423.900851-3-song@kernel.org
89 lines
2.7 KiB
C
89 lines
2.7 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
// Copyright (c) 2020 Facebook
|
|
#include <test_progs.h>
|
|
#include "test_stacktrace_build_id.skel.h"
|
|
|
|
void test_get_stackid_cannot_attach(void)
|
|
{
|
|
struct perf_event_attr attr = {
|
|
/* .type = PERF_TYPE_SOFTWARE, */
|
|
.type = PERF_TYPE_HARDWARE,
|
|
.config = PERF_COUNT_HW_CPU_CYCLES,
|
|
.precise_ip = 1,
|
|
.sample_type = PERF_SAMPLE_IP | PERF_SAMPLE_BRANCH_STACK,
|
|
.branch_sample_type = PERF_SAMPLE_BRANCH_USER |
|
|
PERF_SAMPLE_BRANCH_NO_FLAGS |
|
|
PERF_SAMPLE_BRANCH_NO_CYCLES |
|
|
PERF_SAMPLE_BRANCH_CALL_STACK,
|
|
.sample_period = 5000,
|
|
.size = sizeof(struct perf_event_attr),
|
|
};
|
|
struct test_stacktrace_build_id *skel;
|
|
__u32 duration = 0;
|
|
int pmu_fd, err;
|
|
|
|
skel = test_stacktrace_build_id__open();
|
|
if (CHECK(!skel, "skel_open", "skeleton open failed\n"))
|
|
return;
|
|
|
|
/* override program type */
|
|
bpf_program__set_type(skel->progs.oncpu, BPF_PROG_TYPE_PERF_EVENT);
|
|
|
|
err = test_stacktrace_build_id__load(skel);
|
|
if (CHECK(err, "skel_load", "skeleton load failed: %d\n", err))
|
|
goto cleanup;
|
|
|
|
pmu_fd = syscall(__NR_perf_event_open, &attr, -1 /* pid */,
|
|
0 /* cpu 0 */, -1 /* group id */,
|
|
0 /* flags */);
|
|
if (pmu_fd < 0 && (errno == ENOENT || errno == EOPNOTSUPP)) {
|
|
printf("%s:SKIP:cannot open PERF_COUNT_HW_CPU_CYCLES with precise_ip > 0\n",
|
|
__func__);
|
|
test__skip();
|
|
goto cleanup;
|
|
}
|
|
if (CHECK(pmu_fd < 0, "perf_event_open", "err %d errno %d\n",
|
|
pmu_fd, errno))
|
|
goto cleanup;
|
|
|
|
skel->links.oncpu = bpf_program__attach_perf_event(skel->progs.oncpu,
|
|
pmu_fd);
|
|
ASSERT_ERR_PTR(skel->links.oncpu, "attach_perf_event_no_callchain");
|
|
close(pmu_fd);
|
|
|
|
/* add PERF_SAMPLE_CALLCHAIN, attach should succeed */
|
|
attr.sample_type |= PERF_SAMPLE_CALLCHAIN;
|
|
|
|
pmu_fd = syscall(__NR_perf_event_open, &attr, -1 /* pid */,
|
|
0 /* cpu 0 */, -1 /* group id */,
|
|
0 /* flags */);
|
|
|
|
if (CHECK(pmu_fd < 0, "perf_event_open", "err %d errno %d\n",
|
|
pmu_fd, errno))
|
|
goto cleanup;
|
|
|
|
skel->links.oncpu = bpf_program__attach_perf_event(skel->progs.oncpu,
|
|
pmu_fd);
|
|
ASSERT_OK_PTR(skel->links.oncpu, "attach_perf_event_callchain");
|
|
bpf_link__destroy(skel->links.oncpu);
|
|
close(pmu_fd);
|
|
|
|
/* add exclude_callchain_kernel, attach should fail */
|
|
attr.exclude_callchain_kernel = 1;
|
|
|
|
pmu_fd = syscall(__NR_perf_event_open, &attr, -1 /* pid */,
|
|
0 /* cpu 0 */, -1 /* group id */,
|
|
0 /* flags */);
|
|
|
|
if (CHECK(pmu_fd < 0, "perf_event_open", "err %d errno %d\n",
|
|
pmu_fd, errno))
|
|
goto cleanup;
|
|
|
|
skel->links.oncpu = bpf_program__attach_perf_event(skel->progs.oncpu,
|
|
pmu_fd);
|
|
ASSERT_ERR_PTR(skel->links.oncpu, "attach_perf_event_exclude_callchain_kernel");
|
|
close(pmu_fd);
|
|
|
|
cleanup:
|
|
test_stacktrace_build_id__destroy(skel);
|
|
}
|