linux-stable/sound
Takashi Iwai 5fadc941d0 ALSA: usb-audio: Fix init call orders for UAC1
There have been reports of USB-audio driver spewing errors at the
probe time on a few devices like Jabra and Logitech.  The suggested
fix there couldn't be applied as is, unfortunately, because it'll
likely break other devices.

But, the patch suggested an interesting point: looking at the current
init code in stream.c, one may notice that it does initialize
differently from the device setup in endpoint.c.  Namely, for UAC1, we
should call snd_usb_init_pitch() and snd_usb_init_sample_rate() after
setting the interface, while the init sequence at parsing calls them
before setting the interface blindly.

This patch changes the init sequence at parsing for UAC1 (and other
devices that need a similar behavior) to be aligned with the rest of
the code, setting the interface at first.  And, this fixes the
long-standing problems on a few UAC1 devices like Jabra / Logitech,
as reported, too.

Reported-and-tested-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
Closes: https://lore.kernel.org/r/202bbbc0f51522e8545783c4c5577d12a8e2d56d.camel@infinera.com
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20230821111857.28926-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2023-08-21 16:20:25 +02:00
..
ac97 ALSA: ac97: set variables dev_attr_vendor_id to static 2023-08-02 09:27:39 +02:00
aoa ALSA: aoa: Fix typos in PCM fix patch 2023-08-18 09:09:39 +02:00
arm ARM: pxa: fix missing-prototypes warnings 2023-05-26 13:33:05 +02:00
atmel ALSA: Explicitly include correct DT includes 2023-07-16 14:50:56 +02:00
core ALSA: pcm: Drop obsoleted PCM copy_user and copy_kernel ops 2023-08-18 12:19:19 +02:00
drivers ALSA: pcmtest: Update comment about PCM copy ops 2023-08-18 12:18:26 +02:00
firewire ALSA: dice: add stream format parameters for Weiss devices 2023-08-10 10:10:34 +02:00
hda ALSA: hda: intel-dsp-cfg: Add Chromebook quirk to ADL/RPL 2023-08-16 08:37:40 +02:00
i2c
isa ALSA: emu8000: Convert to generic PCM copy ops 2023-08-18 12:18:19 +02:00
mips
oss
parisc
pci ALSA: hda/realtek: Fix spelling mistake "powe" -> "power" 2023-08-21 12:40:55 +02:00
pcmcia ALSA: add HAS_IOPORT dependencies 2023-05-22 16:43:47 +02:00
ppc ALSA: Explicitly include correct DT includes 2023-07-16 14:50:56 +02:00
sh ALSA: sh: Convert to generic PCM copy ops 2023-08-18 12:18:24 +02:00
soc ASoC: pcm: Drop obsoleted PCM copy_user ops 2023-08-18 12:19:19 +02:00
sparc ALSA: Explicitly include correct DT includes 2023-07-16 14:50:56 +02:00
spi
synth ALSA: emu10k1: fix synthesizer pitch for E-MU cards at 44.1 kHz 2023-06-13 07:42:08 +02:00
usb ALSA: usb-audio: Fix init call orders for UAC1 2023-08-21 16:20:25 +02:00
virtio
x86
xen ALSA: xen: Convert to generic PCM copy ops 2023-08-18 12:18:25 +02:00
ac97_bus.c
Kconfig ALSA: Enable build with UML 2023-07-18 15:19:01 +01:00
last.c
Makefile
sound_core.c sound: make all 'class' structures const 2023-06-21 07:29:10 +02:00