mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-17 16:15:18 +00:00
424953cf3c
Now that SCM can be a loadable module, we have to add another dependency to avoid link failures when ipa or adreno-gpu are built-in: aarch64-linux-ld: drivers/net/ipa/ipa_main.o: in function `ipa_probe': ipa_main.c:(.text+0xfc4): undefined reference to `qcom_scm_is_available' ld.lld: error: undefined symbol: qcom_scm_is_available >>> referenced by adreno_gpu.c >>> gpu/drm/msm/adreno/adreno_gpu.o:(adreno_zap_shader_load) in archive drivers/built-in.a This can happen when CONFIG_ARCH_QCOM is disabled and we don't select QCOM_MDT_LOADER, but some other module selects QCOM_SCM. Ideally we'd use a similar dependency here to what we have for QCOM_RPROC_COMMON, but that causes dependency loops from other things selecting QCOM_SCM. This appears to be an endless problem, so try something different this time: - CONFIG_QCOM_SCM becomes a hidden symbol that nothing 'depends on' but that is simply selected by all of its users - All the stubs in include/linux/qcom_scm.h can go away - arm-smccc.h needs to provide a stub for __arm_smccc_smc() to allow compile-testing QCOM_SCM on all architectures. - To avoid a circular dependency chain involving RESET_CONTROLLER and PINCTRL_SUNXI, drop the 'select RESET_CONTROLLER' statement. According to my testing this still builds fine, and the QCOM platform selects this symbol already. Acked-by: Kalle Valo <kvalo@codeaurora.org> Acked-by: Alex Elder <elder@linaro.org> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
21 lines
781 B
Text
21 lines
781 B
Text
config QCOM_IPA
|
|
tristate "Qualcomm IPA support"
|
|
depends on NET && QCOM_SMEM
|
|
depends on ARCH_QCOM || COMPILE_TEST
|
|
depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST)
|
|
select QCOM_MDT_LOADER if ARCH_QCOM
|
|
select QCOM_SCM
|
|
select QCOM_QMI_HELPERS
|
|
help
|
|
Choose Y or M here to include support for the Qualcomm
|
|
IP Accelerator (IPA), a hardware block present in some
|
|
Qualcomm SoCs. The IPA is a programmable protocol processor
|
|
that is capable of generic hardware handling of IP packets,
|
|
including routing, filtering, and NAT. Currently the IPA
|
|
driver supports only basic transport of network traffic
|
|
between the AP and modem.
|
|
|
|
Note that if selected, the selection type must match that
|
|
of QCOM_Q6V5_COMMON (Y or M).
|
|
|
|
If unsure, say N.
|