mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-10 02:29:01 +00:00
Code Issues Releases Wiki Activity
linux-stable/net/llc
History
Eric Biggers 255aba7762 llc: fix sk_buff refcounting in llc_conn_state_process() 
[ Upstream commit 36453c8528 ]

If llc_conn_state_process() sees that llc_conn_service() put the skb on
a list, it will drop one fewer references to it.  This is wrong because
the current behavior is that llc_conn_service() never consumes a
reference to the skb.

The code also makes the number of skb references being dropped
conditional on which of ind_prim and cfm_prim are nonzero, yet neither
of these affects how many references are *acquired*.  So there is extra
code that tries to fix this up by sometimes taking another reference.

Remove the unnecessary/broken refcounting logic and instead just add an
skb_get() before the only two places where an extra reference is
actually consumed.

Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-01-27 14:51:17 +01:00
..
af_llc.c llc: fix another potential sk_buff leak in llc_ui_sendmsg() 2020-01-27 14:51:16 +01:00
Kconfig llc: fix whitespace issues 2018-07-24 14:10:42 -07:00
llc_c_ac.c llc: fix sk_buff leak in llc_conn_service() 2019-11-06 13:06:23 +01:00
llc_c_ev.c
llc_c_st.c
llc_conn.c llc: fix sk_buff refcounting in llc_conn_state_process() 2020-01-27 14:51:17 +01:00
llc_core.c llc: avoid blocking in llc_sap_close() 2019-11-20 18:46:35 +01:00
llc_if.c llc: fix another potential sk_buff leak in llc_ui_sendmsg() 2020-01-27 14:51:16 +01:00
llc_input.c locking/atomics: COCCINELLE/treewide: Convert trivial ACCESS_ONCE() patterns to READ_ONCE()/WRITE_ONCE() 2017-10-25 11:01:08 +02:00
llc_output.c llc: fix skb leak in llc_build_and_send_ui_pkt() 2019-06-04 08:02:31 +02:00
llc_pdu.c
llc_proc.c proc: introduce proc_create_seq{,_data} 2018-05-16 07:23:35 +02:00
llc_s_ac.c llc: fix sk_buff leak in llc_sap_state_process() 2019-11-06 13:06:23 +01:00
llc_s_ev.c
llc_s_st.c
llc_sap.c llc: fix sk_buff leak in llc_sap_state_process() 2019-11-06 13:06:23 +01:00
llc_station.c llc2: Fix return statement of llc_stat_ev_rx_null_dsap_xid_c (and _test_c) 2020-01-12 12:17:23 +01:00
Makefile llc: fix whitespace issues 2018-07-24 14:10:42 -07:00
sysctl_net_llc.c License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00