mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 13:53:33 +00:00
ce6201c456
Previously, the journal read path used a linked list for storing the journal entries we read from disk. But there's been a bug that's been causing journal_flush_delay to incorrectly be set to 0, leading to far more journal entries than is normal being written out, which then means filesystems are no longer able to start due to the O(n^2) behaviour of inserting into/searching that linked list. Fix this by switching to a radix tree. Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
59 lines
1.5 KiB
C
59 lines
1.5 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _BCACHEFS_JOURNAL_IO_H
|
|
#define _BCACHEFS_JOURNAL_IO_H
|
|
|
|
/*
|
|
* Only used for holding the journal entries we read in btree_journal_read()
|
|
* during cache_registration
|
|
*/
|
|
struct journal_replay {
|
|
struct journal_ptr {
|
|
u8 dev;
|
|
u32 bucket;
|
|
u32 bucket_offset;
|
|
u64 sector;
|
|
} ptrs[BCH_REPLICAS_MAX];
|
|
unsigned nr_ptrs;
|
|
|
|
/* checksum error, but we may want to try using it anyways: */
|
|
bool bad;
|
|
bool ignore;
|
|
/* must be last: */
|
|
struct jset j;
|
|
};
|
|
|
|
static inline struct jset_entry *__jset_entry_type_next(struct jset *jset,
|
|
struct jset_entry *entry, unsigned type)
|
|
{
|
|
while (entry < vstruct_last(jset)) {
|
|
if (entry->type == type)
|
|
return entry;
|
|
|
|
entry = vstruct_next(entry);
|
|
}
|
|
|
|
return NULL;
|
|
}
|
|
|
|
#define for_each_jset_entry_type(entry, jset, type) \
|
|
for (entry = (jset)->start; \
|
|
(entry = __jset_entry_type_next(jset, entry, type)); \
|
|
entry = vstruct_next(entry))
|
|
|
|
#define for_each_jset_key(k, _n, entry, jset) \
|
|
for_each_jset_entry_type(entry, jset, BCH_JSET_ENTRY_btree_keys) \
|
|
vstruct_for_each_safe(entry, k, _n)
|
|
|
|
int bch2_journal_entry_validate(struct bch_fs *, const char *,
|
|
struct jset_entry *, unsigned, int, int);
|
|
void bch2_journal_entry_to_text(struct printbuf *, struct bch_fs *,
|
|
struct jset_entry *);
|
|
|
|
void bch2_journal_ptrs_to_text(struct printbuf *, struct bch_fs *,
|
|
struct journal_replay *);
|
|
|
|
int bch2_journal_read(struct bch_fs *, u64 *, u64 *);
|
|
|
|
void bch2_journal_write(struct closure *);
|
|
|
|
#endif /* _BCACHEFS_JOURNAL_IO_H */
|