linux-stable/drivers/vhost
Gautam Dawar 5ad8d44873 vhost-vdpa: free iommu domain after last use during cleanup
[ Upstream commit 5a52215009 ]

Currently vhost_vdpa_cleanup() unmaps the DMA mappings by calling
`iommu_unmap(v->domain, map->start, map->size);`
from vhost_vdpa_general_unmap() when the parent vDPA driver doesn't
provide DMA config operations.

However, the IOMMU domain referred to by `v->domain` is freed in
vhost_vdpa_free_domain() before vhost_vdpa_cleanup() in
vhost_vdpa_release() which results in NULL pointer de-reference.
Accordingly, moving the call to vhost_vdpa_free_domain() in
vhost_vdpa_cleanup() would makes sense. This will also help
detaching the dma device in error handling of vhost_vdpa_alloc_domain().

This issue was observed on terminating QEMU with SIGQUIT.

Fixes: 037d430556 ("vhost-vdpa: call vhost_vdpa_cleanup during the release")
Signed-off-by: Gautam Dawar <gautam.dawar@amd.com>
Message-Id: <20230301163203.29883-1-gautam.dawar@amd.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-03-22 13:37:46 +01:00
..
Kconfig vhost_vdpa: implement IRQ offloading in vhost_vdpa 2020-08-05 11:08:42 -04:00
Makefile vhost: introduce vDPA-based backend 2020-04-02 10:41:40 -04:00
iotlb.c vhost_iotlb: split out IOTLB initialization 2022-05-31 12:44:28 -04:00
net.c vhost/net: Clear the pending messages when the backend is removed 2023-01-27 06:18:41 -05:00
scsi.c vhost-scsi: unbreak any layout for response 2023-01-27 06:18:41 -05:00
test.c vhost: rename vhost_work_dev_flush 2022-05-31 12:45:10 -04:00
test.h tools/virtio: Add --reset 2020-06-22 12:34:21 -04:00
vdpa.c vhost-vdpa: free iommu domain after last use during cleanup 2023-03-22 13:37:46 +01:00
vhost.c vhost/net: Clear the pending messages when the backend is removed 2023-01-27 06:18:41 -05:00
vhost.h vhost/net: Clear the pending messages when the backend is removed 2023-01-27 06:18:41 -05:00
vringh.c vringh: fix range used in iotlb_translate() 2022-12-28 05:28:10 -05:00
vsock.c vhost/vsock: Fix error handling in vhost_vsock_init() 2022-12-28 05:28:10 -05:00