linux-stable/drivers/scsi/libsas
Xingui Yang 52c266b486 scsi: libsas: Fix the failure of adding phy with zero-address to port
[ Upstream commit 06036a0a5d ]

As of commit 7d1d865181 ("[SCSI] libsas: fix false positive 'device
attached' conditions"), reset the phy->entacted_sas_addr address to a
zero-address when the link rate is less than 1.5G.

Currently we find that when a new device is attached, and the link rate is
less than 1.5G, but the device type is not NO_DEVICE, for example: the link
rate is SAS_PHY_RESET_IN_PROGRESS and the device type is stp. After setting
the phy->entacted_sas_addr address to the zero address, the port will
continue to be created for the phy with the zero-address, and other phys
with the zero-address will be tried to be added to the new port:

[562240.051197] sas: ex 500e004aaaaaaa1f phy19:U:0 attached: 0000000000000000 (no device)
// phy19 is deleted but still on the parent port's phy_list
[562240.062536] sas: ex 500e004aaaaaaa1f phy0 new device attached
[562240.062616] sas: ex 500e004aaaaaaa1f phy00:U:5 attached: 0000000000000000 (stp)
[562240.062680] port-7:7:0: trying to add phy phy-7:7:19 fails: it's already part of another port

Therefore, it should be the same as sas_get_phy_attached_dev(). Only when
device_type is SAS_PHY_UNUSED, sas_address is set to the 0 address.

Fixes: 7d1d865181 ("[SCSI] libsas: fix false positive 'device attached' conditions")
Signed-off-by: Xingui Yang <yangxingui@huawei.com>
Link: https://lore.kernel.org/r/20240312141103.31358-5-yangxingui@huawei.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-06-12 11:11:42 +02:00
..
Kconfig
Makefile
sas_ata.c ata changes for 6.6 2023-09-05 12:37:28 -07:00
sas_discover.c ata changes for 6.6 2023-09-05 12:37:28 -07:00
sas_event.c scsi: libsas: Use bool for queue_work() return code 2022-02-27 21:48:30 -05:00
sas_expander.c scsi: libsas: Fix the failure of adding phy with zero-address to port 2024-06-12 11:11:42 +02:00
sas_host_smp.c scsi: libsas: Delete struct scsi_core 2023-08-21 17:50:58 -04:00
sas_init.c scsi: libsas: Delete struct scsi_core 2023-08-21 17:50:58 -04:00
sas_internal.h scsi: libsas: Delete enum sas_class 2023-08-21 17:50:57 -04:00
sas_phy.c scsi: libsas: Delete struct scsi_core 2023-08-21 17:50:58 -04:00
sas_port.c scsi: libsas: Delete struct scsi_core 2023-08-21 17:50:58 -04:00
sas_scsi_host.c scsi: libsas: Simplify sas_queue_reset() and remove unused code 2023-08-30 21:24:50 -04:00
sas_task.c scsi: libsas: Use enum for response frame DATAPRES field 2022-02-19 15:59:34 -05:00