Tejun Heo 35963b3182 memcg: fix possible use-after-free in memcg_write_event_control() ... commit 4a7ba45b1a upstream. memcg_write_event_control() accesses the dentry->d_name of the specified control fd to route the write call. As a cgroup interface file can't be renamed, it's safe to access d_name as long as the specified file is a regular cgroup file. Also, as these cgroup interface files can't be removed before the directory, it's safe to access the parent too. Prior to 347c4a8747 ("memcg: remove cgroup_event->cft"), there was a call to __file_cft() which verified that the specified file is a regular cgroupfs file before further accesses. The cftype pointer returned from __file_cft() was no longer necessary and the commit inadvertently dropped the file type check with it allowing any file to slip through. With the invarients broken, the d_name and parent accesses can now race against renames and removals of arbitrary files and cause use-after-free's. Fix the bug by resurrecting the file type check in __file_cft(). Now that cgroupfs is implemented through kernfs, checking the file operations needs to go through a layer of indirection. Instead, let's check the superblock and dentry type. Link: https://lkml.kernel.org/r/Y5FRm/cfcKPGzWwl@slm.duckdns.org Fixes: 347c4a8747 ("memcg: remove cgroup_event->cft") Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Jann Horn <jannh@google.com> Acked-by: Roman Gushchin <roman.gushchin@linux.dev> Acked-by: Johannes Weiner <hannes@cmpxchg.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Michal Hocko <mhocko@kernel.org> Cc: Muchun Song <songmuchun@bytedance.com> Cc: Shakeel Butt <shakeelb@google.com> Cc: <stable@vger.kernel.org> [3.14+] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-12-14 11:30:43 +01:00
..
bpf	bpf: Ensure correct locking around vulnerable function find_vpid()	2022-10-26 13:22:24 +02:00
cgroup	memcg: fix possible use-after-free in memcg_write_event_control()	2022-12-14 11:30:43 +01:00
configs
debug	lockdown: also lock down previous kgdb use	2022-06-06 08:33:48 +02:00
dma	dma-debug: make things less spammy under memory pressure	2022-06-22 14:11:19 +02:00
events	perf/core: Fix data race between perf_event_set_output() and perf_mmap_close()	2022-07-29 17:14:10 +02:00
gcov	gcov: clang: fix the buffer overflow issue	2022-12-08 11:23:00 +01:00
irq	genirq: Don't return error on missing optional irq_request_resources()	2022-08-25 11:17:29 +02:00
livepatch	livepatch: fix race between fork and KLP transition	2022-10-26 13:22:18 +02:00
locking	locking/lockdep: Avoid RCU-induced noinstr fail	2021-11-17 09:48:28 +01:00
power	PM: hibernate: Allow hybrid sleep to work with s2idle	2022-11-03 23:56:55 +09:00
printk	printk: fix return value of printk.devkmsg __setup handler	2022-04-15 14:18:08 +02:00
rcu	rcu: Don't deboost before reporting expedited quiescent state	2022-03-28 08:46:48 +02:00
sched	sched/deadline: Fix priority inheritance with multiple scheduling classes	2022-09-05 10:27:39 +02:00
time	timekeeping: contribute wall clock to rng on time change	2022-08-25 11:18:15 +02:00
trace	tracing/ring-buffer: Have polling block on watermark	2022-12-08 11:23:05 +01:00
.gitignore	kbuild: update config_data.gz only when the content of .config is changed	2021-05-11 14:04:16 +02:00
acct.c
async.c	Revert "module, async: async_synchronize_full() on module init iff async is used"	2022-02-23 11:59:56 +01:00
audit.c	audit: improve audit queue handling when "audit=1" on cmdline	2022-02-08 18:24:26 +01:00
audit.h	audit: log AUDIT_TIME_* records only from rules	2022-04-15 14:18:04 +02:00
audit_fsnotify.c	audit: fix potential double free on error path from fsnotify_add_inode_mark	2022-09-05 10:27:38 +02:00
audit_tree.c	audit: move put_tree() to avoid trim_trees refcount underflow and UAF	2021-09-03 10:08:16 +02:00
audit_watch.c	audit: CONFIG_CHANGE don't log internal bookkeeping as an event	2020-10-01 13:17:32 +02:00
auditfilter.c	audit: fix a net reference leak in audit_list_rules_send()	2020-06-22 09:30:59 +02:00
auditsc.c	audit: log AUDIT_TIME_* records only from rules	2022-04-15 14:18:04 +02:00
backtracetest.c
bounds.c
capability.c
compat.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
configs.c	kernel/configs: Replace GPL boilerplate code with SPDX identifier	2019-07-30 18:34:15 +02:00
context_tracking.c
cpu.c	random: clear fast pool, crng, and batches in cpuhp bring up	2022-06-22 14:11:12 +02:00
cpu_pm.c	kernel/cpu_pm: Fix uninitted local in cpu_pm	2020-06-22 09:31:22 +02:00
crash_core.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 230	2019-06-19 17:09:06 +02:00
crash_dump.c
cred.c	keys: Fix request_key() cache	2020-01-17 19:48:42 +01:00
delayacct.c
dma.c
exec_domain.c
exit.c	don't dump the threads that had been already exiting when zapped.	2020-11-18 19:20:31 +01:00
extable.c	extable: Add function to search only kernel exception table	2019-08-21 22:23:48 +10:00
fail_function.c	fail_function: Remove a redundant mutex unlock	2020-11-24 13:29:18 +01:00
fork.c	copy_process(): Move fd_install() out of sighand->siglock critical section	2022-02-23 12:00:00 +01:00
freezer.c	Revert "libata, freezer: avoid block device removal while system is frozen"	2019-10-06 09:11:37 -06:00
futex.c	mm, futex: fix shared futex pgoff on shmem huge page	2021-06-30 08:47:55 -04:00
gen_kheaders.sh	kbuild: add variables for compression tools	2020-09-03 11:27:10 +02:00
groups.c
hung_task.c
iomem.c	mm/nvdimm: add is_ioremap_addr and use that to check ioremap address	2019-07-12 11:05:40 -07:00
irq_work.c
jump_label.c	jump_label: Don't warn on __exit jump entries	2019-08-29 15:10:10 +01:00
kallsyms.c	kallsyms: Refactor kallsyms_show_value() to take cred	2020-07-16 08:16:44 +02:00
kcmp.c	exec: Transform exec_update_mutex into a rw_semaphore	2021-01-09 13:44:55 +01:00
Kconfig.freezer
Kconfig.hz
Kconfig.locks
Kconfig.preempt	sched/rt, Kconfig: Unbreak def/oldconfig with CONFIG_PREEMPT=y	2019-07-22 18:05:11 +02:00
kcov.c
kexec.c	kexec_load: Disable at runtime if the kernel is locked down	2019-08-19 21:54:15 -07:00
kexec_core.c	kernel: kexec: remove the lock operation of system_transition_mutex	2021-02-03 23:25:56 +01:00
kexec_elf.c	kexec_elf: support 32 bit ELF files	2019-09-06 23:58:44 +02:00
kexec_file.c	kexec_file: drop weak attribute from arch_kexec_apply_relocations[_add]	2022-07-02 16:28:50 +02:00
kexec_internal.h
kheaders.c
kmod.c	kmod: make request_module() return an error when autoloading is disabled	2020-04-17 10:50:22 +02:00
kprobes.c	kprobes: Skip clearing aggrprobe's post_handler in kprobe-on-ftrace case	2022-11-25 17:42:21 +01:00
ksysfs.c
kthread.c	kthread: Fix PF_KTHREAD vs to_kthread() race	2021-09-12 08:56:39 +02:00
latencytop.c
Makefile	kbuild: update config_data.gz only when the content of .config is changed	2021-05-11 14:04:16 +02:00
module-internal.h
module.c	module/ftrace: handle patchable-function-entry	2022-02-23 11:59:56 +01:00
module_signature.c	module: harden ELF info handling	2021-04-07 14:47:38 +02:00
module_signing.c	module: harden ELF info handling	2021-04-07 14:47:38 +02:00
notifier.c	kernel/notifier.c: intercept duplicate registrations to avoid infinite loops	2020-10-01 13:17:23 +02:00
nsproxy.c
padata.c	padata: add separate cpuhp node for CPUHP_PADATA_DEAD	2020-06-17 16:40:22 +02:00
panic.c	panic: ensure preemption is disabled during panic()	2019-10-07 15:47:19 -07:00
params.c	lockdown: Lock down module params that specify hardware parameters (eg. ioport)	2019-08-19 21:54:16 -07:00
pid.c	kernel/pid.c: convert struct pid count to refcount_t	2019-07-16 19:23:24 -07:00
pid_namespace.c	memcg: enable accounting for pids in nested pid namespaces	2021-09-22 12:26:37 +02:00
profile.c	profiling: fix shift too large makes kernel panic	2022-08-25 11:18:02 +02:00
ptrace.c	ptrace: Reimplement PTRACE_KILL by always sending SIGKILL	2022-06-14 18:11:24 +02:00
range.c
reboot.c	reboot: fix overflow parsing reboot cpu number	2020-11-18 19:20:30 +01:00
relay.c	kernel/relay.c: fix memleak on destroy relay channel	2020-08-26 10:40:51 +02:00
resource.c	/dev/mem: Revoke mappings when a driver claims the region	2020-06-24 17:50:35 +02:00
rseq.c
seccomp.c	seccomp: Invalidate seccomp mode to catch death failures	2022-02-16 12:52:53 +01:00
signal.c	signal handling: don't use BUG_ON() for debugging	2022-07-21 20:59:27 +02:00
smp.c	smp: Fix offline cpu check in flush_smp_call_function_queue()	2022-04-20 09:19:39 +02:00
smpboot.c	kthread: Extract KTHREAD_IS_PER_CPU	2021-02-07 15:35:49 +01:00
smpboot.h
softirq.c	Merge branch 'irq-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-07-08 11:01:13 -07:00
stackleak.c
stacktrace.c	stacktrace: Don't skip first entry on noncurrent tasks	2019-11-04 21:19:25 +01:00
stop_machine.c	stop_machine: Avoid potential race behaviour	2019-10-17 12:47:12 +02:00
sys.c	prctl: allow to setup brk for et_dyn executables	2021-09-26 14:07:08 +02:00
sys_ni.c	kernel/sys_ni: add compat entry for fadvise64_64	2022-09-05 10:27:38 +02:00
sysctl-test.c	kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()	2020-10-01 13:17:10 +02:00
sysctl.c	proc: proc_skip_spaces() shouldn't think it is working on C strings	2022-12-08 11:23:06 +01:00
sysctl_binary.c
task_work.c
taskstats.c	taskstats: fix data-race	2020-01-09 10:19:54 +01:00
test_kprobes.c
torture.c	torture: Remove exporting of internal functions	2019-08-01 14:30:22 -07:00
tracepoint.c	tracepoint: Add tracepoint_probe_register_may_exist() for BPF tracing	2021-07-14 16:53:08 +02:00
tsacct.c	taskstats: Cleanup the use of task->exit_code	2022-02-23 11:59:57 +01:00
ucount.c	proc/sysctl: add shared variables for range check	2019-07-18 17:08:07 -07:00
uid16.c
uid16.h
umh.c	usermodehelper: reset umask to default before executing user process	2020-10-14 10:32:58 +02:00
up.c	smp: Fix smp_call_function_single_async prototype	2021-05-14 09:44:33 +02:00
user-return-notifier.c
user.c	Keyrings namespacing	2019-07-08 19:36:47 -07:00
user_namespace.c	Keyrings namespacing	2019-07-08 19:36:47 -07:00
utsname.c
utsname_sysctl.c
watchdog.c	watchdog: export lockup_detector_reconfigure	2022-08-25 11:18:37 +02:00
watchdog_hld.c
workqueue.c	workqueue: don't skip lockdep work dependency in cancel_work_sync()	2022-09-28 11:04:09 +02:00
workqueue_internal.h