Adrian Hunter 62942e9fda perf script: Fix hex dump character output ... Using grep -C with perf script -D can give erroneous results as grep loses lines due to non-printable characters, for example, below the 0020, 0060 and 0070 lines are missing: $ perf script -D | grep -C10 AUX | head . 0010: 08 00 00 00 00 00 00 00 1f 00 00 00 00 00 00 00 ................ . 0030: 01 00 00 00 00 00 00 00 00 04 00 00 00 00 00 00 ................ . 0040: 00 08 00 00 00 00 00 00 02 00 00 00 00 00 00 00 ................ . 0050: 00 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 ................ . 0080: 02 00 00 00 00 00 00 00 1b 00 00 00 00 00 00 00 ................ . 0090: 00 00 00 00 00 00 00 00 ........ 0 0 0x450 [0x98]: PERF_RECORD_AUXTRACE_INFO type: 1 PMU Type 8 Time Shift 31 perf's isprint() is a custom implementation from the kernel, but the kernel's _ctype appears to include characters from Latin-1 Supplement which is not compatible with, for example, UTF-8. Fix by checking also isascii(). After: $ tools/perf/perf script -D | grep -C10 AUX | head . 0010: 08 00 00 00 00 00 00 00 1f 00 00 00 00 00 00 00 ................ . 0020: 03 84 32 2f 00 00 00 00 63 7c 4f d2 fa ff ff ff ..2/....c|O..... . 0030: 01 00 00 00 00 00 00 00 00 04 00 00 00 00 00 00 ................ . 0040: 00 08 00 00 00 00 00 00 02 00 00 00 00 00 00 00 ................ . 0050: 00 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 ................ . 0060: 00 02 00 00 00 00 00 00 00 c0 03 00 00 00 00 00 ................ . 0070: e2 00 00 00 00 00 00 00 02 00 00 00 00 00 00 00 ................ . 0080: 02 00 00 00 00 00 00 00 1b 00 00 00 00 00 00 00 ................ . 0090: 00 00 00 00 00 00 00 00 ........ Fixes: 3052ba56bc ("tools perf: Move from sane_ctype.h obtained from git to the Linux's original") Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Cc: Jiri Olsa <jolsa@redhat.com> Link: http://lore.kernel.org/lkml/20220112085057.277205-1-adrian.hunter@intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>		2022-01-12 14:28:21 -03:00
..
accounting
arch	tools headers UAPI: Sync x86's asm/kvm.h with the kernel sources	2021-11-18 10:08:07 -03:00
bootconfig	bootconfig: Cleanup dummy headers in tools/bootconfig	2021-10-10 22:16:02 -04:00
bpf	tools/resolve_btfids: Skip unresolved symbol warning for empty BTF sets	2021-12-02 13:39:46 -08:00
build	tools build: Enable warnings through HOSTCFLAGS	2021-12-07 22:18:23 -03:00
cgroup
counter	tools/counter: Create Counter tools	2021-10-17 10:54:16 +01:00
debugging
edid
firewire
firmware
gpio
hv
iio
include	tools headers UAPI: Add new macros for mem_hops field to perf_event.h	2021-12-22 09:34:43 -03:00
io_uring
kvm/kvm_stat	KVM: kvm_stat: do not show halt_wait_ns	2021-10-18 14:07:18 -04:00
laptop
leds
lib	libperf tests: Fix a spelling mistake "Runnnig" -> "Running"	2021-12-16 12:18:12 -03:00
memory-model
objtool	objtool: Fix pv_ops noinstr validation	2021-12-03 09:11:42 +01:00
pci
pcmcia
perf	perf script: Fix hex dump character output	2022-01-12 14:28:21 -03:00
power	ACPI: tools: Fix compilation when output directory is not present	2021-12-08 15:10:27 +01:00
rcu
scripts	tools, build: Add RISC-V to HOSTARCH parsing	2021-11-01 17:08:21 +01:00
spi
testing	- Add support for handling hw errors in SGX pages: poisoning, recovering	2022-01-10 09:44:09 -08:00
thermal/tmon
time
tracing	tools/latency-collector: Use correct size when writing queue_full_warning	2021-10-25 22:27:19 -04:00
usb
virtio
vm	tools/vm/page-types.c: print file offset in hexadecimal	2021-11-06 13:30:40 -07:00
wmi
Makefile	tools/lib/lockdep: drop liblockdep	2021-11-12 11:07:17 -08:00