mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-29 23:53:32 +00:00
3f649ab728
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. In preparation for removing[2] the[3] macro[4], remove all remaining needless uses with the following script: git grep '\buninitialized_var\b' | cut -d: -f1 | sort -u | \ xargs perl -pi -e \ 's/\buninitialized_var\(([^\)]+)\)/\1/g; s:\s*/\* (GCC be quiet|to make compiler happy) \*/$::g;' drivers/video/fbdev/riva/riva_hw.c was manually tweaked to avoid pathological white-space. No outstanding warnings were found building allmodconfig with GCC 9.3.0 for x86_64, i386, arm64, arm, powerpc, powerpc64le, s390x, mips, sparc64, alpha, and m68k. [1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.com/ [2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/ [3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/ [4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/ Reviewed-by: Leon Romanovsky <leonro@mellanox.com> # drivers/infiniband and mlx4/mlx5 Acked-by: Jason Gunthorpe <jgg@mellanox.com> # IB Acked-by: Kalle Valo <kvalo@codeaurora.org> # wireless drivers Reviewed-by: Chao Yu <yuchao0@huawei.com> # erofs Signed-off-by: Kees Cook <keescook@chromium.org>
143 lines
3.2 KiB
C
143 lines
3.2 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include <linux/kernel.h>
|
|
#include <linux/ide.h>
|
|
|
|
char *ide_media_string(ide_drive_t *drive)
|
|
{
|
|
switch (drive->media) {
|
|
case ide_disk:
|
|
return "disk";
|
|
case ide_cdrom:
|
|
return "cdrom";
|
|
case ide_tape:
|
|
return "tape";
|
|
case ide_floppy:
|
|
return "floppy";
|
|
case ide_optical:
|
|
return "optical";
|
|
default:
|
|
return "UNKNOWN";
|
|
}
|
|
}
|
|
|
|
static ssize_t media_show(struct device *dev, struct device_attribute *attr,
|
|
char *buf)
|
|
{
|
|
ide_drive_t *drive = to_ide_device(dev);
|
|
return sprintf(buf, "%s\n", ide_media_string(drive));
|
|
}
|
|
static DEVICE_ATTR_RO(media);
|
|
|
|
static ssize_t drivename_show(struct device *dev, struct device_attribute *attr,
|
|
char *buf)
|
|
{
|
|
ide_drive_t *drive = to_ide_device(dev);
|
|
return sprintf(buf, "%s\n", drive->name);
|
|
}
|
|
static DEVICE_ATTR_RO(drivename);
|
|
|
|
static ssize_t modalias_show(struct device *dev, struct device_attribute *attr,
|
|
char *buf)
|
|
{
|
|
ide_drive_t *drive = to_ide_device(dev);
|
|
return sprintf(buf, "ide:m-%s\n", ide_media_string(drive));
|
|
}
|
|
static DEVICE_ATTR_RO(modalias);
|
|
|
|
static ssize_t model_show(struct device *dev, struct device_attribute *attr,
|
|
char *buf)
|
|
{
|
|
ide_drive_t *drive = to_ide_device(dev);
|
|
return sprintf(buf, "%s\n", (char *)&drive->id[ATA_ID_PROD]);
|
|
}
|
|
static DEVICE_ATTR_RO(model);
|
|
|
|
static ssize_t firmware_show(struct device *dev, struct device_attribute *attr,
|
|
char *buf)
|
|
{
|
|
ide_drive_t *drive = to_ide_device(dev);
|
|
return sprintf(buf, "%s\n", (char *)&drive->id[ATA_ID_FW_REV]);
|
|
}
|
|
static DEVICE_ATTR_RO(firmware);
|
|
|
|
static ssize_t serial_show(struct device *dev, struct device_attribute *attr,
|
|
char *buf)
|
|
{
|
|
ide_drive_t *drive = to_ide_device(dev);
|
|
return sprintf(buf, "%s\n", (char *)&drive->id[ATA_ID_SERNO]);
|
|
}
|
|
static DEVICE_ATTR(serial, 0400, serial_show, NULL);
|
|
|
|
static DEVICE_ATTR(unload_heads, 0644, ide_park_show, ide_park_store);
|
|
|
|
static struct attribute *ide_attrs[] = {
|
|
&dev_attr_media.attr,
|
|
&dev_attr_drivename.attr,
|
|
&dev_attr_modalias.attr,
|
|
&dev_attr_model.attr,
|
|
&dev_attr_firmware.attr,
|
|
&dev_attr_serial.attr,
|
|
&dev_attr_unload_heads.attr,
|
|
NULL,
|
|
};
|
|
|
|
static const struct attribute_group ide_attr_group = {
|
|
.attrs = ide_attrs,
|
|
};
|
|
|
|
const struct attribute_group *ide_dev_groups[] = {
|
|
&ide_attr_group,
|
|
NULL,
|
|
};
|
|
|
|
static ssize_t store_delete_devices(struct device *portdev,
|
|
struct device_attribute *attr,
|
|
const char *buf, size_t n)
|
|
{
|
|
ide_hwif_t *hwif = dev_get_drvdata(portdev);
|
|
|
|
if (strncmp(buf, "1", n))
|
|
return -EINVAL;
|
|
|
|
ide_port_unregister_devices(hwif);
|
|
|
|
return n;
|
|
};
|
|
|
|
static DEVICE_ATTR(delete_devices, S_IWUSR, NULL, store_delete_devices);
|
|
|
|
static ssize_t store_scan(struct device *portdev,
|
|
struct device_attribute *attr,
|
|
const char *buf, size_t n)
|
|
{
|
|
ide_hwif_t *hwif = dev_get_drvdata(portdev);
|
|
|
|
if (strncmp(buf, "1", n))
|
|
return -EINVAL;
|
|
|
|
ide_port_unregister_devices(hwif);
|
|
ide_port_scan(hwif);
|
|
|
|
return n;
|
|
};
|
|
|
|
static DEVICE_ATTR(scan, S_IWUSR, NULL, store_scan);
|
|
|
|
static struct device_attribute *ide_port_attrs[] = {
|
|
&dev_attr_delete_devices,
|
|
&dev_attr_scan,
|
|
NULL
|
|
};
|
|
|
|
int ide_sysfs_register_port(ide_hwif_t *hwif)
|
|
{
|
|
int i, rc;
|
|
|
|
for (i = 0; ide_port_attrs[i]; i++) {
|
|
rc = device_create_file(hwif->portdev, ide_port_attrs[i]);
|
|
if (rc)
|
|
break;
|
|
}
|
|
|
|
return rc;
|
|
}
|