Jeff Mahoney 64c12921e1 btrfs: account for non-CoW'd blocks in btrfs_abort_transaction ... The test for !trans->blocks_used in btrfs_abort_transaction is insufficient to determine whether it's safe to drop the transaction handle on the floor. btrfs_cow_block, informed by should_cow_block, can return blocks that have already been CoW'd in the current transaction. trans->blocks_used is only incremented for new block allocations. If an operation overlaps the blocks in the current transaction entirely and must abort the transaction, we'll happily let it clean up the trans handle even though it may have modified the blocks and will commit an incomplete operation. In the long-term, I'd like to do closer tracking of when the fs is actually modified so we can still recover as gracefully as possible, but that approach will need some discussion. In the short term, since this is the only code using trans->blocks_used, let's just switch it to a bool indicating whether any blocks were used and set it when should_cow_block returns false. Cc: stable@vger.kernel.org # 3.4+ Signed-off-by: Jeff Mahoney <jeffm@suse.com> Reviewed-by: Filipe Manana <fdmanana@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>		2016-06-17 18:32:40 +02:00
..
tests	Btrfs: self-tests: Fix extent buffer bitmap test fail on BE system	2016-06-06 17:17:12 +02:00
acl.c	Merge branch 'for-linus-4.5' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs	2016-01-18 12:44:40 -08:00
async-thread.c	btrfs: async-thread: Fix a use-after-free error for trace	2016-01-25 16:50:26 -08:00
async-thread.h
backref.c	Merge branch 'cleanups-4.7' into for-chris-4.7-20160525	2016-05-25 22:51:03 +02:00
backref.h
btrfs_inode.h	Merge branch 'cleanups-4.7' into for-chris-4.7-20160525	2016-05-25 22:51:03 +02:00
check-integrity.c	btrfs: Use correct format specifier	2016-06-17 18:32:40 +02:00
check-integrity.h
compression.c	btrfs: make find_workspace warn if there are no workspaces	2016-05-10 09:46:16 +02:00
compression.h	btrfs: move btrfs_compression_type to compression.h	2016-03-11 17:12:46 +01:00
ctree.c	btrfs: account for non-CoW'd blocks in btrfs_abort_transaction	2016-06-17 18:32:40 +02:00
ctree.h	Merge branch 'cleanups-4.7' into for-chris-4.7-20160525	2016-05-25 22:51:03 +02:00
delayed-inode.c	btrfs: GFP_NOFS does not GFP_HIGHMEM	2016-05-10 09:44:21 +02:00
delayed-inode.h	btrfs: properly set the termination value of ctx->pos in readdir	2016-02-11 07:01:59 -08:00
delayed-ref.c	btrfs: drop null testing before destroy functions	2016-02-18 11:46:03 +01:00
delayed-ref.h	btrfs: fix string and comment grammatical issues and typos	2016-05-25 22:35:14 +02:00
dev-replace.c	Merge branch 'cleanups-4.7' into for-chris-4.7-20160525	2016-05-25 22:51:03 +02:00
dev-replace.h	btrfs: refactor btrfs_dev_replace_start for reuse	2016-04-28 10:59:13 +02:00
dir-item.c
disk-io.c	Btrfs: check if extent buffer is aligned to sectorsize	2016-06-17 18:32:40 +02:00
disk-io.h	Btrfs: self-tests: Support non-4k page size	2016-06-02 19:23:14 +02:00
export.c
export.h
extent-tree.c	btrfs: account for non-CoW'd blocks in btrfs_abort_transaction	2016-06-17 18:32:40 +02:00
extent_io.c	Btrfs: check if extent buffer is aligned to sectorsize	2016-06-17 18:32:40 +02:00
extent_io.h	Btrfs: self-tests: Support non-4k page size	2016-06-02 19:23:14 +02:00
extent_map.c	btrfs: fix string and comment grammatical issues and typos	2016-05-25 22:35:14 +02:00
extent_map.h	btrfs: cleanup, stop casting for extent_map->lookup everywhere	2016-01-15 19:22:28 +01:00
file-item.c	btrfs: sink gfp parameter to set_extent_bits	2016-04-29 11:01:47 +02:00
file.c	Btrfs: fix handling of faults from btrfs_copy_from_user	2016-05-26 13:23:59 -07:00
free-space-cache.c	Btrfs: self-tests: Support non-4k page size	2016-06-02 19:23:14 +02:00
free-space-cache.h	btrfs: fix string and comment grammatical issues and typos	2016-05-25 22:35:14 +02:00
free-space-tree.c	Revert "btrfs: synchronize incompat feature bits with sysfs files"	2016-01-29 08:19:37 -08:00
free-space-tree.h	Btrfs: implement the free space B-tree	2015-12-17 12:16:47 -08:00
hash.c	btrfs: advertise which crc32c implementation is being used at module load	2016-06-06 14:08:28 +02:00
hash.h	btrfs: advertise which crc32c implementation is being used at module load	2016-06-06 14:08:28 +02:00
inode-item.c	btrfs: rename btrfs_std_error to btrfs_handle_fs_error	2016-04-28 10:36:54 +02:00
inode-map.c	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
inode-map.h	Btrfs: Initialize btrfs_root->highest_objectid when loading tree root and subvolume roots	2016-01-15 19:25:02 +01:00
inode.c	Btrfs: deal with duplciates during extent_map insertion in btrfs_get_extent	2016-06-03 12:32:34 -07:00
ioctl.c	Merge branch 'cleanups-4.7' into for-chris-4.7-20160525	2016-05-25 22:51:03 +02:00
Kconfig
locking.c	btrfs: cleanup, remove stray return statements	2016-01-07 14:30:52 +01:00
locking.h
lzo.c	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
Makefile	Btrfs: add free space tree sanity tests	2015-12-17 12:16:47 -08:00
math.h
ordered-data.c	Btrfs: fix race setting block group readonly during device replace	2016-05-30 12:58:21 +01:00
ordered-data.h	Btrfs: fix race setting block group readonly during device replace	2016-05-30 12:58:21 +01:00
orphan.c
print-tree.c	btrfs: teach print_leaf about temporary item subtypes	2016-02-11 16:15:43 +01:00
print-tree.h
props.c	btrfs: move btrfs_compression_type to compression.h	2016-03-11 17:12:46 +01:00
props.h
qgroup.c	btrfs: fix string and comment grammatical issues and typos	2016-05-25 22:35:14 +02:00
qgroup.h	btrfs: qgroup: Check if qgroup reserved space leaked	2015-10-21 18:41:10 -07:00
raid56.c	btrfs: fix string and comment grammatical issues and typos	2016-05-25 22:35:14 +02:00
raid56.h
rcu-string.h
reada.c	Btrfs: fix race between readahead and device replace/removal	2016-05-30 12:58:18 +01:00
relocation.c	Merge branch 'cleanups-4.7' into for-chris-4.7-20160525	2016-05-25 22:51:03 +02:00
root-tree.c	Merge branch 'cleanups-4.7' into for-chris-4.7-20160525	2016-05-25 22:51:03 +02:00
scrub.c	Btrfs: fix race setting block group back to RW mode during device replace	2016-05-30 12:58:24 +01:00
send.c	Merge branch 'cleanups-4.7' into for-chris-4.7-20160525	2016-05-25 22:51:03 +02:00
send.h	Btrfs: use linux/sizes.h to represent constants	2016-01-07 14:38:02 +01:00
struct-funcs.c	btrfs: fix string and comment grammatical issues and typos	2016-05-25 22:35:14 +02:00
super.c	btrfs: account for non-CoW'd blocks in btrfs_abort_transaction	2016-06-17 18:32:40 +02:00
sysfs.c	btrfs: sysfs: protect reading label by lock	2016-05-06 15:22:49 +02:00
sysfs.h	btrfs: sysfs: introduce helper for syncing bits with sysfs files	2016-01-21 18:50:40 +01:00
transaction.c	Merge branch 'cleanups-4.7' into for-chris-4.7-20160525	2016-05-25 22:51:03 +02:00
transaction.h	btrfs: account for non-CoW'd blocks in btrfs_abort_transaction	2016-06-17 18:32:40 +02:00
tree-defrag.c	Btrfs: fix locking bugs when defragging leaves	2015-12-18 02:51:32 +00:00
tree-log.c	Btrfs: check if extent buffer is aligned to sectorsize	2016-06-17 18:32:40 +02:00
tree-log.h	Btrfs: fix unreplayable log after snapshot delete + parent dir fsync	2016-03-01 08:23:25 -08:00
ulist.c	btrfs: fix string and comment grammatical issues and typos	2016-05-25 22:35:14 +02:00
ulist.h
uuid-tree.c
volumes.c	Btrfs: check if extent buffer is aligned to sectorsize	2016-06-17 18:32:40 +02:00
volumes.h	Merge branch 'foreign/jeffm/uapi' into for-chris-4.7-20160516	2016-05-16 15:46:29 +02:00
xattr.c	Btrfs: fix listxattrs not listing all xattrs packed in the same item	2016-03-01 08:23:41 -08:00
xattr.h	btrfs: Use xattr handler infrastructure	2015-12-06 21:34:14 -05:00
zlib.c	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00