mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-02 15:18:19 +00:00
87875c1084
The caller of this function (parisc_driver_remove() in arch/parisc/kernel/drivers.c) ignores the return value, so better don't return any value at all to not wake wrong expectations in driver authors. The only function that could return a non-zero value before was ipmi_parisc_remove() which returns the return value of ipmi_si_remove_by_dev(). Make this function return void, too, as for all other callers the value is ignored, too. Also fold in a small checkpatch fix for: WARNING: Unnecessary space before function pointer arguments + void (*remove) (struct parisc_device *dev); Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> (for drivers/input) Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Acked-by: Jiri Slaby <jirislaby@kernel.org> Signed-off-by: Helge Deller <deller@gmx.de>
61 lines
1.3 KiB
C
61 lines
1.3 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
|
|
#include <linux/module.h>
|
|
#include <asm/hardware.h> /* for register_parisc_driver() stuff */
|
|
#include <asm/parisc-device.h>
|
|
#include "ipmi_si.h"
|
|
|
|
static bool parisc_registered;
|
|
|
|
static int __init ipmi_parisc_probe(struct parisc_device *dev)
|
|
{
|
|
struct si_sm_io io;
|
|
|
|
memset(&io, 0, sizeof(io));
|
|
|
|
io.si_type = SI_KCS;
|
|
io.addr_source = SI_DEVICETREE;
|
|
io.addr_space = IPMI_MEM_ADDR_SPACE;
|
|
io.addr_data = dev->hpa.start;
|
|
io.regsize = 1;
|
|
io.regspacing = 1;
|
|
io.regshift = 0;
|
|
io.irq = 0; /* no interrupt */
|
|
io.irq_setup = NULL;
|
|
io.dev = &dev->dev;
|
|
|
|
dev_dbg(&dev->dev, "addr 0x%lx\n", io.addr_data);
|
|
|
|
return ipmi_si_add_smi(&io);
|
|
}
|
|
|
|
static void __exit ipmi_parisc_remove(struct parisc_device *dev)
|
|
{
|
|
ipmi_si_remove_by_dev(&dev->dev);
|
|
}
|
|
|
|
static const struct parisc_device_id ipmi_parisc_tbl[] __initconst = {
|
|
{ HPHW_MC, HVERSION_REV_ANY_ID, 0x004, 0xC0 },
|
|
{ 0, }
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(parisc, ipmi_parisc_tbl);
|
|
|
|
static struct parisc_driver ipmi_parisc_driver __refdata = {
|
|
.name = "ipmi",
|
|
.id_table = ipmi_parisc_tbl,
|
|
.probe = ipmi_parisc_probe,
|
|
.remove = __exit_p(ipmi_parisc_remove),
|
|
};
|
|
|
|
void ipmi_si_parisc_init(void)
|
|
{
|
|
register_parisc_driver(&ipmi_parisc_driver);
|
|
parisc_registered = true;
|
|
}
|
|
|
|
void ipmi_si_parisc_shutdown(void)
|
|
{
|
|
if (parisc_registered)
|
|
unregister_parisc_driver(&ipmi_parisc_driver);
|
|
}
|