David Hildenbrand 2c8d6e2493 drivers/virt/acrn: fix PFNMAP PTE checks in acrn_vm_ram_map() ... [ Upstream commit 3d6586008f ] Patch series "mm: follow_pte() improvements and acrn follow_pte() fixes". Patch #1 fixes a bunch of issues I spotted in the acrn driver. It compiles, that's all I know. I'll appreciate some review and testing from acrn folks. Patch #2+#3 improve follow_pte(), passing a VMA instead of the MM, adding more sanity checks, and improving the documentation. Gave it a quick test on x86-64 using VM_PAT that ends up using follow_pte(). This patch (of 3): We currently miss handling various cases, resulting in a dangerous follow_pte() (previously follow_pfn()) usage. (1) We're not checking PTE write permissions. Maybe we should simply always require pte_write() like we do for pin_user_pages_fast(FOLL_WRITE)? Hard to tell, so let's check for ACRN_MEM_ACCESS_WRITE for now. (2) We're not rejecting refcounted pages. As we are not using MMU notifiers, messing with refcounted pages is dangerous and can result in use-after-free. Let's make sure to reject them. (3) We are only looking at the first PTE of a bigger range. We only lookup a single PTE, but memmap->len may span a larger area. Let's loop over all involved PTEs and make sure the PFN range is actually contiguous. Reject everything else: it couldn't have worked either way, and rather made use access PFNs we shouldn't be accessing. Link: https://lkml.kernel.org/r/20240410155527.474777-1-david@redhat.com Link: https://lkml.kernel.org/r/20240410155527.474777-2-david@redhat.com Fixes: 8a6e85f75a ("virt: acrn: obtain pa from VMA with PFNMAP flag") Signed-off-by: David Hildenbrand <david@redhat.com> Cc: Alex Williamson <alex.williamson@redhat.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Fei Li <fei1.li@intel.com> Cc: Gerald Schaefer <gerald.schaefer@linux.ibm.com> Cc: Heiko Carstens <hca@linux.ibm.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Yonghua Huang <yonghua.huang@intel.com> Cc: Sean Christopherson <seanjc@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-05-30 09:44:58 +02:00
..
acrn_drv.h	virt: acrn: Annotate struct vm_memory_region_batch with __counted_by	2023-10-08 22:46:04 -07:00
hsm.c	x86/cpu: Encapsulate topology information in cpuinfo_x86	2023-10-10 14:38:17 +02:00
hypercall.h	virt: acrn: Introduce interfaces for virtual device creating/destroying	2021-10-05 16:14:10 +02:00
ioeventfd.c	eventfd: simplify eventfd_signal()	2023-11-28 14:08:38 +01:00
ioreq.c	minmax: add in_range() macro	2023-08-24 16:20:18 -07:00
irqfd.c	virt: acrn: Remove unsued acrn_irqfds_mutex.	2022-03-18 13:49:49 +01:00
Kconfig	virt: acrn: Introduce ioeventfd	2021-02-09 10:58:19 +01:00
Makefile	virt: acrn: Introduce irqfd	2021-02-09 10:58:19 +01:00
mm.c	drivers/virt/acrn: fix PFNMAP PTE checks in acrn_vm_ram_map()	2024-05-30 09:44:58 +02:00
vm.c	virt: acrn: Do hcall_destroy_vm() before resource release	2021-07-27 16:48:45 +02:00