Kuninori Morimoto 6618e7a740 ASoC: simple-card: fixup asoc_simple_probe() error handling ... [ Upstream commit 41bae58df4 ] asoc_simple_probe() is used for both "DT probe" (A) and "platform probe" (B). It uses "goto err" when error case, but it is not needed for "platform probe" case (B). Thus it is using "return" directly there. static int asoc_simple_probe(...) { ^ if (...) { | ... (A) if (ret < 0) | goto err; v } else { ^ ... | if (ret < 0) (B) return -Exxx; v } ... ^ if (ret < 0) (C) goto err; v ... err: (D) simple_util_clean_reference(card); return ret; } Both case are using (C) part, and it calls (D) when err case. But (D) will do nothing for (B) case. Because of these behavior, current code itself is not wrong, but is confusable, and more, static analyzing tool will warning on (B) part (should use goto err). To avoid static analyzing tool warning, this patch uses "goto err" on (B) part. Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Link: https://lore.kernel.org/r/87o7hy7mlh.wl-kuninori.morimoto.gx@renesas.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-11-08 14:10:57 +01:00
..
audio-graph-card.c	ASoC: audio-graph-card: fix refcount leak of cpu_ep in __graph_for_each_link()	2022-12-31 13:33:06 +01:00
audio-graph-card2-custom-sample.c	ASoC: add Audio Graph Card2 Custom Sample	2021-10-15 16:10:43 +01:00
audio-graph-card2-custom-sample.dtsi	ASoC: audio-graph-card2-custom-sample.dtsi: add verbose explanation	2022-07-08 11:51:44 +01:00
audio-graph-card2.c	ASoC: audio-graph-card2: Add of_node_put() in fail path	2022-07-22 21:27:55 +01:00
Kconfig	ASoC: add Audio Graph Card2 Custom Sample	2021-10-15 16:10:43 +01:00
Makefile	ASoC: add Audio Graph Card2 Custom Sample	2021-10-15 16:10:43 +01:00
simple-card-utils.c	ASoC: simple-card-utils: fixup simple_util_startup() error handling	2023-10-19 23:08:51 +02:00
simple-card.c	ASoC: simple-card: fixup asoc_simple_probe() error handling	2023-11-08 14:10:57 +01:00
test-component.c	ASoC: test-component: Remove now redundant non_legacy_dai_naming flag	2022-06-27 13:16:53 +01:00