mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-09 10:09:11 +00:00
af6bdc2a85
commit82f2bc2fcc
upstream. Clang's -Wpointer-to-int-cast deviates from GCC in that it warns when casting to enums. The kernel does this in certain places, such as device tree matches to set the version of the device being used, which allows the kernel to avoid using a gigantic union. https://elixir.bootlin.com/linux/v5.5.8/source/drivers/ata/ahci_brcm.c#L428 https://elixir.bootlin.com/linux/v5.5.8/source/drivers/ata/ahci_brcm.c#L402 https://elixir.bootlin.com/linux/v5.5.8/source/include/linux/mod_devicetable.h#L264 To avoid a ton of false positive warnings, disable this particular part of the warning, which has been split off into a separate diagnostic so that the entire warning does not need to be turned off for clang. It will be visible under W=1 in case people want to go about fixing these easily and enabling the warning treewide. Cc: stable@vger.kernel.org Link: https://github.com/ClangBuiltLinux/linux/issues/887 Link:2a41b31fcd
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
77 lines
2.8 KiB
Makefile
77 lines
2.8 KiB
Makefile
# SPDX-License-Identifier: GPL-2.0
|
|
# ==========================================================================
|
|
#
|
|
# make W=... settings
|
|
#
|
|
# W=1 - warnings that may be relevant and does not occur too often
|
|
# W=2 - warnings that occur quite often but may still be relevant
|
|
# W=3 - the more obscure warnings, can most likely be ignored
|
|
#
|
|
# $(call cc-option, -W...) handles gcc -W.. options which
|
|
# are not supported by all versions of the compiler
|
|
# ==========================================================================
|
|
|
|
KBUILD_CFLAGS += $(call cc-disable-warning, packed-not-aligned)
|
|
|
|
ifeq ("$(origin W)", "command line")
|
|
export KBUILD_ENABLE_EXTRA_GCC_CHECKS := $(W)
|
|
endif
|
|
|
|
ifdef KBUILD_ENABLE_EXTRA_GCC_CHECKS
|
|
warning- := $(empty)
|
|
|
|
warning-1 := -Wextra -Wunused -Wno-unused-parameter
|
|
warning-1 += -Wmissing-declarations
|
|
warning-1 += -Wmissing-format-attribute
|
|
warning-1 += $(call cc-option, -Wmissing-prototypes)
|
|
warning-1 += -Wold-style-definition
|
|
warning-1 += $(call cc-option, -Wmissing-include-dirs)
|
|
warning-1 += $(call cc-option, -Wunused-but-set-variable)
|
|
warning-1 += $(call cc-option, -Wunused-const-variable)
|
|
warning-1 += $(call cc-option, -Wpacked-not-aligned)
|
|
warning-1 += $(call cc-disable-warning, missing-field-initializers)
|
|
warning-1 += $(call cc-disable-warning, sign-compare)
|
|
|
|
warning-2 := -Waggregate-return
|
|
warning-2 += -Wcast-align
|
|
warning-2 += -Wdisabled-optimization
|
|
warning-2 += -Wnested-externs
|
|
warning-2 += -Wshadow
|
|
warning-2 += $(call cc-option, -Wlogical-op)
|
|
warning-2 += $(call cc-option, -Wmissing-field-initializers)
|
|
warning-2 += $(call cc-option, -Wsign-compare)
|
|
warning-2 += $(call cc-option, -Wmaybe-uninitialized)
|
|
warning-2 += $(call cc-option, -Wunused-macros)
|
|
|
|
warning-3 := -Wbad-function-cast
|
|
warning-3 += -Wcast-qual
|
|
warning-3 += -Wconversion
|
|
warning-3 += -Wpacked
|
|
warning-3 += -Wpadded
|
|
warning-3 += -Wpointer-arith
|
|
warning-3 += -Wredundant-decls
|
|
warning-3 += -Wswitch-default
|
|
warning-3 += $(call cc-option, -Wpacked-bitfield-compat)
|
|
warning-3 += $(call cc-option, -Wvla)
|
|
|
|
warning := $(warning-$(findstring 1, $(KBUILD_ENABLE_EXTRA_GCC_CHECKS)))
|
|
warning += $(warning-$(findstring 2, $(KBUILD_ENABLE_EXTRA_GCC_CHECKS)))
|
|
warning += $(warning-$(findstring 3, $(KBUILD_ENABLE_EXTRA_GCC_CHECKS)))
|
|
|
|
ifeq ("$(strip $(warning))","")
|
|
$(error W=$(KBUILD_ENABLE_EXTRA_GCC_CHECKS) is unknown)
|
|
endif
|
|
|
|
KBUILD_CFLAGS += $(warning)
|
|
else
|
|
|
|
ifeq ($(cc-name),clang)
|
|
KBUILD_CFLAGS += $(call cc-disable-warning, initializer-overrides)
|
|
KBUILD_CFLAGS += $(call cc-disable-warning, unused-value)
|
|
KBUILD_CFLAGS += $(call cc-disable-warning, format)
|
|
KBUILD_CFLAGS += $(call cc-disable-warning, sign-compare)
|
|
KBUILD_CFLAGS += $(call cc-disable-warning, format-zero-length)
|
|
KBUILD_CFLAGS += $(call cc-disable-warning, uninitialized)
|
|
KBUILD_CFLAGS += $(call cc-disable-warning, pointer-to-enum-cast)
|
|
endif
|
|
endif
|