mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-13 22:25:03 +00:00
d9dba91be7
It was discovered that MGMT_DATA2 can contain up to 28 bytes of data
instead of the 12 bytes written in the Documentation by accounting the
limit of 16 bytes declared in Documentation subtracting the first 4 byte
in the packet header.
Update the define with the real world value.
Tested-by: Ronald Wahl <ronald.wahl@raritan.com>
Fixes: c2ee8181fd ("net: dsa: tag_qca: add define for handling mgmt Ethernet packet")
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Cc: stable@vger.kernel.org # v5.18+
Signed-off-by: David S. Miller <davem@davemloft.net>
87 lines
2.5 KiB
C
87 lines
2.5 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
|
|
#ifndef __TAG_QCA_H
|
|
#define __TAG_QCA_H
|
|
|
|
#include <linux/types.h>
|
|
|
|
struct dsa_switch;
|
|
struct sk_buff;
|
|
|
|
#define QCA_HDR_LEN 2
|
|
#define QCA_HDR_VERSION 0x2
|
|
|
|
#define QCA_HDR_RECV_VERSION GENMASK(15, 14)
|
|
#define QCA_HDR_RECV_PRIORITY GENMASK(13, 11)
|
|
#define QCA_HDR_RECV_TYPE GENMASK(10, 6)
|
|
#define QCA_HDR_RECV_FRAME_IS_TAGGED BIT(3)
|
|
#define QCA_HDR_RECV_SOURCE_PORT GENMASK(2, 0)
|
|
|
|
/* Packet type for recv */
|
|
#define QCA_HDR_RECV_TYPE_NORMAL 0x0
|
|
#define QCA_HDR_RECV_TYPE_MIB 0x1
|
|
#define QCA_HDR_RECV_TYPE_RW_REG_ACK 0x2
|
|
|
|
#define QCA_HDR_XMIT_VERSION GENMASK(15, 14)
|
|
#define QCA_HDR_XMIT_PRIORITY GENMASK(13, 11)
|
|
#define QCA_HDR_XMIT_CONTROL GENMASK(10, 8)
|
|
#define QCA_HDR_XMIT_FROM_CPU BIT(7)
|
|
#define QCA_HDR_XMIT_DP_BIT GENMASK(6, 0)
|
|
|
|
/* Packet type for xmit */
|
|
#define QCA_HDR_XMIT_TYPE_NORMAL 0x0
|
|
#define QCA_HDR_XMIT_TYPE_RW_REG 0x1
|
|
|
|
/* Check code for a valid mgmt packet. Switch will ignore the packet
|
|
* with this wrong.
|
|
*/
|
|
#define QCA_HDR_MGMT_CHECK_CODE_VAL 0x5
|
|
|
|
/* Specific define for in-band MDIO read/write with Ethernet packet */
|
|
#define QCA_HDR_MGMT_SEQ_LEN 4 /* 4 byte for the seq */
|
|
#define QCA_HDR_MGMT_COMMAND_LEN 4 /* 4 byte for the command */
|
|
#define QCA_HDR_MGMT_DATA1_LEN 4 /* First 4 byte for the mdio data */
|
|
#define QCA_HDR_MGMT_HEADER_LEN (QCA_HDR_MGMT_SEQ_LEN + \
|
|
QCA_HDR_MGMT_COMMAND_LEN + \
|
|
QCA_HDR_MGMT_DATA1_LEN)
|
|
|
|
#define QCA_HDR_MGMT_DATA2_LEN 28 /* Other 28 byte for the mdio data */
|
|
#define QCA_HDR_MGMT_PADDING_LEN 18 /* Padding to reach the min Ethernet packet */
|
|
|
|
#define QCA_HDR_MGMT_PKT_LEN (QCA_HDR_MGMT_HEADER_LEN + \
|
|
QCA_HDR_LEN + \
|
|
QCA_HDR_MGMT_DATA2_LEN + \
|
|
QCA_HDR_MGMT_PADDING_LEN)
|
|
|
|
#define QCA_HDR_MGMT_SEQ_NUM GENMASK(31, 0) /* 63, 32 */
|
|
#define QCA_HDR_MGMT_CHECK_CODE GENMASK(31, 29) /* 31, 29 */
|
|
#define QCA_HDR_MGMT_CMD BIT(28) /* 28 */
|
|
#define QCA_HDR_MGMT_LENGTH GENMASK(23, 20) /* 23, 20 */
|
|
#define QCA_HDR_MGMT_ADDR GENMASK(18, 0) /* 18, 0 */
|
|
|
|
/* Special struct emulating a Ethernet header */
|
|
struct qca_mgmt_ethhdr {
|
|
__le32 command; /* command bit 31:0 */
|
|
__le32 seq; /* seq 63:32 */
|
|
__le32 mdio_data; /* first 4byte mdio */
|
|
__be16 hdr; /* qca hdr */
|
|
} __packed;
|
|
|
|
enum mdio_cmd {
|
|
MDIO_WRITE = 0x0,
|
|
MDIO_READ
|
|
};
|
|
|
|
struct mib_ethhdr {
|
|
__le32 data[3]; /* first 3 mib counter */
|
|
__be16 hdr; /* qca hdr */
|
|
} __packed;
|
|
|
|
struct qca_tagger_data {
|
|
void (*rw_reg_ack_handler)(struct dsa_switch *ds,
|
|
struct sk_buff *skb);
|
|
void (*mib_autocast_handler)(struct dsa_switch *ds,
|
|
struct sk_buff *skb);
|
|
};
|
|
|
|
#endif /* __TAG_QCA_H */
|