mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-30 08:02:30 +00:00
a9ae9c526c
The PXA platform has a number of configurations that end up with a warning like these when building with W=1: drivers/hwmon/max1111.c:83:5: error: no previous prototype for 'max1111_read_channel' [-Werror=missing-prototypes] arch/arm/mach-pxa/reset.c:86:6: error: no previous prototype for 'pxa_restart' [-Werror=missing-prototypes] arch/arm/mach-pxa/mfp-pxa2xx.c:254:5: error: no previous prototype for 'keypad_set_wake' [-Werror=missing-prototypes] drivers/clk/pxa/clk-pxa25x.c:70:14: error: no previous prototype for 'pxa25x_get_clk_frequency_khz' [-Werror=missing-prototypes] drivers/clk/pxa/clk-pxa25x.c:325:12: error: no previous prototype for 'pxa25x_clocks_init' [-Werror=missing-prototypes] drivers/clk/pxa/clk-pxa27x.c:74:14: error: no previous prototype for 'pxa27x_get_clk_frequency_khz' [-Werror=missing-prototypes] drivers/clk/pxa/clk-pxa27x.c:102:6: error: no previous prototype for 'pxa27x_is_ppll_disabled' [-Werror=missing-prototypes] drivers/clk/pxa/clk-pxa27x.c:470:12: error: no previous prototype for 'pxa27x_clocks_init' [-Werror=missing-prototypes] arch/arm/mach-pxa/pxa27x.c:44:6: error: no previous prototype for 'pxa27x_clear_otgph' [-Werror=missing-prototypes] arch/arm/mach-pxa/pxa27x.c:58:6: error: no previous prototype for 'pxa27x_configure_ac97reset' [-Werror=missing-prototypes] arch/arm/mach-pxa/spitz_pm.c:170:15: error: no previous prototype for 'spitzpm_read_devdata' [-Werror=missing-prototypes] The problem is that there is a declaration for each of these, but it's only seen by the caller and not the callee. Moving these into appropriate header files ensures that both use the same calling conventions and it avoids the warnings. Acked-by: Stephen Boyd <sboyd@kernel.org> Link: https://lore.kernel.org/r/20230516153109.514251-11-arnd@kernel.org Signed-off-by: Arnd Bergmann <arnd@arndb.de>
32 lines
1,023 B
C
32 lines
1,023 B
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef __SOC_PXA_AUDIO_H__
|
|
#define __SOC_PXA_AUDIO_H__
|
|
|
|
#include <sound/core.h>
|
|
#include <sound/pcm.h>
|
|
#include <sound/ac97_codec.h>
|
|
|
|
/*
|
|
* @reset_gpio: AC97 reset gpio (normally gpio113 or gpio95)
|
|
* a -1 value means no gpio will be used for reset
|
|
* @codec_pdata: AC97 codec platform_data
|
|
|
|
* reset_gpio should only be specified for pxa27x CPUs where a silicon
|
|
* bug prevents correct operation of the reset line. If not specified,
|
|
* the default behaviour on these CPUs is to consider gpio 113 as the
|
|
* AC97 reset line, which is the default on most boards.
|
|
*/
|
|
typedef struct {
|
|
int (*startup)(struct snd_pcm_substream *, void *);
|
|
void (*shutdown)(struct snd_pcm_substream *, void *);
|
|
void (*suspend)(void *);
|
|
void (*resume)(void *);
|
|
void *priv;
|
|
int reset_gpio;
|
|
void *codec_pdata[AC97_BUS_MAX_DEVICES];
|
|
} pxa2xx_audio_ops_t;
|
|
|
|
extern void pxa_set_ac97_info(pxa2xx_audio_ops_t *ops);
|
|
extern void pxa27x_configure_ac97reset(int reset_gpio, bool to_gpio);
|
|
|
|
#endif
|