mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-30 08:02:30 +00:00
06de2cd788
An spi or i2c remove callback is only called for devices that probed successfully. In this case this implies that __max730x_probe() set a non-NULL driver data. So the check ts == NULL is never true. With this check dropped, __max730x_remove() returns zero unconditionally. Make it return void instead which makes it easier to see in the callers that there is no error to handle. Also the return value of i2c and spi remove callbacks is ignored anyway. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
36 lines
947 B
C
36 lines
947 B
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef LINUX_SPI_MAX7301_H
|
|
#define LINUX_SPI_MAX7301_H
|
|
|
|
#include <linux/gpio/driver.h>
|
|
|
|
/*
|
|
* Some registers must be read back to modify.
|
|
* To save time we cache them here in memory
|
|
*/
|
|
struct max7301 {
|
|
struct mutex lock;
|
|
u8 port_config[8]; /* field 0 is unused */
|
|
u32 out_level; /* cached output levels */
|
|
u32 input_pullup_active;
|
|
struct gpio_chip chip;
|
|
struct device *dev;
|
|
int (*write)(struct device *dev, unsigned int reg, unsigned int val);
|
|
int (*read)(struct device *dev, unsigned int reg);
|
|
};
|
|
|
|
struct max7301_platform_data {
|
|
/* number assigned to the first GPIO */
|
|
unsigned base;
|
|
/*
|
|
* bitmask controlling the pullup configuration,
|
|
*
|
|
* _note_ the 4 lowest bits are unused, because the first 4
|
|
* ports of the controller are not used, too.
|
|
*/
|
|
u32 input_pullup_active;
|
|
};
|
|
|
|
extern void __max730x_remove(struct device *dev);
|
|
extern int __max730x_probe(struct max7301 *ts);
|
|
#endif
|