mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-13 22:25:03 +00:00
91f88a0ac8
perf_event__read_stat_config will assign values based on number of tags and tag values. Initialize the structs to zero before they are assigned so that no uninitialized values can be seen. This potential error was reported by GCC with LTO enabled. Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Ian Rogers <irogers@google.com> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Carsten Haitzler <carsten.haitzler@arm.com> Cc: Fangrui Song <maskray@google.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: James Clark <james.clark@arm.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Kan Liang <kan.liang@linux.intel.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Nathan Chancellor <nathan@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Ravi Bangoria <ravi.bangoria@amd.com> Cc: Tom Rix <trix@redhat.com> Cc: Xing Zhengjun <zhengjun.xing@linux.intel.com> Cc: Yang Jihong <yangjihong1@huawei.com> Cc: bpf@vger.kernel.org Cc: llvm@lists.linux.dev Link: https://lore.kernel.org/r/20230724201247.748146-2-irogers@google.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
119 lines
3.5 KiB
C
119 lines
3.5 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include <linux/compiler.h>
|
|
#include "event.h"
|
|
#include "tests.h"
|
|
#include "stat.h"
|
|
#include "counts.h"
|
|
#include "debug.h"
|
|
#include "util/synthetic-events.h"
|
|
|
|
static bool has_term(struct perf_record_stat_config *config,
|
|
u64 tag, u64 val)
|
|
{
|
|
unsigned i;
|
|
|
|
for (i = 0; i < config->nr; i++) {
|
|
if ((config->data[i].tag == tag) &&
|
|
(config->data[i].val == val))
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
static int process_stat_config_event(struct perf_tool *tool __maybe_unused,
|
|
union perf_event *event,
|
|
struct perf_sample *sample __maybe_unused,
|
|
struct machine *machine __maybe_unused)
|
|
{
|
|
struct perf_record_stat_config *config = &event->stat_config;
|
|
struct perf_stat_config stat_config = {};
|
|
|
|
#define HAS(term, val) \
|
|
has_term(config, PERF_STAT_CONFIG_TERM__##term, val)
|
|
|
|
TEST_ASSERT_VAL("wrong nr", config->nr == PERF_STAT_CONFIG_TERM__MAX);
|
|
TEST_ASSERT_VAL("wrong aggr_mode", HAS(AGGR_MODE, AGGR_CORE));
|
|
TEST_ASSERT_VAL("wrong scale", HAS(SCALE, 1));
|
|
TEST_ASSERT_VAL("wrong interval", HAS(INTERVAL, 1));
|
|
|
|
#undef HAS
|
|
|
|
perf_event__read_stat_config(&stat_config, config);
|
|
|
|
TEST_ASSERT_VAL("wrong aggr_mode", stat_config.aggr_mode == AGGR_CORE);
|
|
TEST_ASSERT_VAL("wrong scale", stat_config.scale == 1);
|
|
TEST_ASSERT_VAL("wrong interval", stat_config.interval == 1);
|
|
return 0;
|
|
}
|
|
|
|
static int test__synthesize_stat_config(struct test_suite *test __maybe_unused,
|
|
int subtest __maybe_unused)
|
|
{
|
|
struct perf_stat_config stat_config = {
|
|
.aggr_mode = AGGR_CORE,
|
|
.scale = 1,
|
|
.interval = 1,
|
|
};
|
|
|
|
TEST_ASSERT_VAL("failed to synthesize stat_config",
|
|
!perf_event__synthesize_stat_config(NULL, &stat_config, process_stat_config_event, NULL));
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int process_stat_event(struct perf_tool *tool __maybe_unused,
|
|
union perf_event *event,
|
|
struct perf_sample *sample __maybe_unused,
|
|
struct machine *machine __maybe_unused)
|
|
{
|
|
struct perf_record_stat *st = &event->stat;
|
|
|
|
TEST_ASSERT_VAL("wrong cpu", st->cpu == 1);
|
|
TEST_ASSERT_VAL("wrong thread", st->thread == 2);
|
|
TEST_ASSERT_VAL("wrong id", st->id == 3);
|
|
TEST_ASSERT_VAL("wrong val", st->val == 100);
|
|
TEST_ASSERT_VAL("wrong run", st->ena == 200);
|
|
TEST_ASSERT_VAL("wrong ena", st->run == 300);
|
|
return 0;
|
|
}
|
|
|
|
static int test__synthesize_stat(struct test_suite *test __maybe_unused, int subtest __maybe_unused)
|
|
{
|
|
struct perf_counts_values count;
|
|
|
|
count.val = 100;
|
|
count.ena = 200;
|
|
count.run = 300;
|
|
|
|
TEST_ASSERT_VAL("failed to synthesize stat_config",
|
|
!perf_event__synthesize_stat(NULL, (struct perf_cpu){.cpu = 1}, 2, 3,
|
|
&count, process_stat_event, NULL));
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int process_stat_round_event(struct perf_tool *tool __maybe_unused,
|
|
union perf_event *event,
|
|
struct perf_sample *sample __maybe_unused,
|
|
struct machine *machine __maybe_unused)
|
|
{
|
|
struct perf_record_stat_round *stat_round = &event->stat_round;
|
|
|
|
TEST_ASSERT_VAL("wrong time", stat_round->time == 0xdeadbeef);
|
|
TEST_ASSERT_VAL("wrong type", stat_round->type == PERF_STAT_ROUND_TYPE__INTERVAL);
|
|
return 0;
|
|
}
|
|
|
|
static int test__synthesize_stat_round(struct test_suite *test __maybe_unused, int subtest __maybe_unused)
|
|
{
|
|
TEST_ASSERT_VAL("failed to synthesize stat_config",
|
|
!perf_event__synthesize_stat_round(NULL, 0xdeadbeef, PERF_STAT_ROUND_TYPE__INTERVAL,
|
|
process_stat_round_event, NULL));
|
|
|
|
return 0;
|
|
}
|
|
|
|
DEFINE_SUITE("Synthesize stat config", synthesize_stat_config);
|
|
DEFINE_SUITE("Synthesize stat", synthesize_stat);
|
|
DEFINE_SUITE("Synthesize stat round", synthesize_stat_round);
|