mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-24 11:25:43 +00:00
eccc489ef6
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Make simatic_ipc_leds_gpio_remove() return void instead of returning zero unconditionally. After that the three remove callbacks that use this function were trivial to convert to return void, too. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230916164516.1063380-1-u.kleine-koenig@pengutronix.de Signed-off-by: Lee Jones <lee@kernel.org>
66 lines
2.1 KiB
C
66 lines
2.1 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Siemens SIMATIC IPC driver for GPIO based LEDs
|
|
*
|
|
* Copyright (c) Siemens AG, 2023
|
|
*
|
|
* Author:
|
|
* Henning Schild <henning.schild@siemens.com>
|
|
*/
|
|
|
|
#include <linux/gpio/machine.h>
|
|
#include <linux/gpio/consumer.h>
|
|
#include <linux/leds.h>
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/platform_data/x86/simatic-ipc-base.h>
|
|
|
|
#include "simatic-ipc-leds-gpio.h"
|
|
|
|
static struct gpiod_lookup_table simatic_ipc_led_gpio_table = {
|
|
.dev_id = "leds-gpio",
|
|
.table = {
|
|
GPIO_LOOKUP_IDX("gpio-f7188x-2", 0, NULL, 0, GPIO_ACTIVE_LOW),
|
|
GPIO_LOOKUP_IDX("gpio-f7188x-2", 1, NULL, 1, GPIO_ACTIVE_LOW),
|
|
GPIO_LOOKUP_IDX("gpio-f7188x-2", 2, NULL, 2, GPIO_ACTIVE_LOW),
|
|
GPIO_LOOKUP_IDX("gpio-f7188x-2", 3, NULL, 3, GPIO_ACTIVE_LOW),
|
|
GPIO_LOOKUP_IDX("gpio-f7188x-2", 4, NULL, 4, GPIO_ACTIVE_LOW),
|
|
GPIO_LOOKUP_IDX("gpio-f7188x-2", 5, NULL, 5, GPIO_ACTIVE_LOW),
|
|
{} /* Terminating entry */
|
|
},
|
|
};
|
|
|
|
static struct gpiod_lookup_table simatic_ipc_led_gpio_table_extra = {
|
|
.dev_id = NULL, /* Filled during initialization */
|
|
.table = {
|
|
GPIO_LOOKUP_IDX("gpio-f7188x-3", 6, NULL, 6, GPIO_ACTIVE_HIGH),
|
|
GPIO_LOOKUP_IDX("gpio-f7188x-3", 7, NULL, 7, GPIO_ACTIVE_HIGH),
|
|
{} /* Terminating entry */
|
|
},
|
|
};
|
|
|
|
static int simatic_ipc_leds_gpio_f7188x_probe(struct platform_device *pdev)
|
|
{
|
|
return simatic_ipc_leds_gpio_probe(pdev, &simatic_ipc_led_gpio_table,
|
|
&simatic_ipc_led_gpio_table_extra);
|
|
}
|
|
|
|
static void simatic_ipc_leds_gpio_f7188x_remove(struct platform_device *pdev)
|
|
{
|
|
simatic_ipc_leds_gpio_remove(pdev, &simatic_ipc_led_gpio_table,
|
|
&simatic_ipc_led_gpio_table_extra);
|
|
}
|
|
|
|
static struct platform_driver simatic_ipc_led_gpio_driver = {
|
|
.probe = simatic_ipc_leds_gpio_f7188x_probe,
|
|
.remove_new = simatic_ipc_leds_gpio_f7188x_remove,
|
|
.driver = {
|
|
.name = KBUILD_MODNAME,
|
|
},
|
|
};
|
|
module_platform_driver(simatic_ipc_led_gpio_driver);
|
|
|
|
MODULE_LICENSE("GPL v2");
|
|
MODULE_ALIAS("platform:" KBUILD_MODNAME);
|
|
MODULE_SOFTDEP("pre: simatic-ipc-leds-gpio-core gpio_f7188x");
|
|
MODULE_AUTHOR("Henning Schild <henning.schild@siemens.com>");
|