Junxiao Bi 69e63b49dd ocfs2: don't clear bh uptodate for block read ... [ Upstream commit 70306d9dce ] For sync io read in ocfs2_read_blocks_sync(), first clear bh uptodate flag and submit the io, second wait io done, last check whether bh uptodate, if not return io error. If two sync io for the same bh were issued, it could be the first io done and set uptodate flag, but just before check that flag, the second io came in and cleared uptodate, then ocfs2_read_blocks_sync() for the first io will return IO error. Indeed it's not necessary to clear uptodate flag, as the io end handler end_buffer_read_sync() will set or clear it based on io succeed or failed. The following message was found from a nfs server but the underlying storage returned no error. [4106438.567376] (nfsd,7146,3):ocfs2_get_suballoc_slot_bit:2780 ERROR: read block 1238823695 failed -5 [4106438.567569] (nfsd,7146,3):ocfs2_get_suballoc_slot_bit:2812 ERROR: status = -5 [4106438.567611] (nfsd,7146,3):ocfs2_test_inode_bit:2894 ERROR: get alloc slot and bit failed -5 [4106438.567643] (nfsd,7146,3):ocfs2_test_inode_bit:2932 ERROR: status = -5 [4106438.567675] (nfsd,7146,3):ocfs2_get_dentry:94 ERROR: test inode bit failed -5 Same issue in non sync read ocfs2_read_blocks(), fixed it as well. Link: http://lkml.kernel.org/r/20181121020023.3034-4-junxiao.bi@oracle.com Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com> Reviewed-by: Changwei Ge <ge.changwei@h3c.com> Reviewed-by: Yiwen Jiang <jiangyiwen@huawei.com> Cc: Joel Becker <jlbec@evilplan.org> Cc: Joseph Qi <jiangqi903@gmail.com> Cc: Jun Piao <piaojun@huawei.com> Cc: Mark Fasheh <mfasheh@versity.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2019-02-12 19:47:18 +01:00
..
9p	v9fs_dir_readdir: fix double-free on p9stat_read error	2018-12-01 09:37:27 +01:00
adfs	adfs: use timespec64 for time conversion	2018-08-22 10:52:51 -07:00
affs
afs	afs: Fix validation/callback interaction	2018-12-17 09:24:40 +01:00
autofs	Merge branch 'akpm' (patches from Andrew)	2018-08-22 12:34:08 -07:00
befs
bfs	bfs: add sanity check at bfs_fill_super()	2018-12-01 09:37:27 +01:00
btrfs	btrfs: use tagged writepage to mitigate livelock of snapshot	2019-02-12 19:47:11 +01:00
cachefiles	fscache, cachefiles: remove redundant variable 'cache'	2018-12-17 09:24:40 +01:00
ceph	ceph: clear inode pointer when snap realm gets dropped by its inode	2019-01-31 08:14:34 +01:00
cifs	cifs: check ntwrk_buf_start for NULL before dereferencing it	2019-02-12 19:47:17 +01:00
coda
configfs	configfs: fix registered group removal	2018-07-17 06:14:07 -07:00
cramfs	Cramfs: fix abad comparison when wrap-arounds occur	2018-11-13 11:08:55 -08:00
crypto	crypto: speck - remove Speck	2018-11-13 11:08:46 -08:00
debugfs
devpts	devpts: Convert to new IDA API	2018-08-21 23:54:17 -04:00
dlm	dlm: Don't swamp the CPU with callbacks queued during recovery	2019-02-12 19:46:58 +01:00
ecryptfs
efivarfs	efivars: Call guid_parse() against guid_t type of variable	2018-07-22 14:13:44 +02:00
efs
exofs	fs/exofs: fix potential memory leak in mount option parsing	2018-11-27 16:13:00 +01:00
exportfs	exportfs: do not read dentry after free	2018-12-17 09:24:35 +01:00
ext2	ext2: fix potential use after free	2018-12-05 19:32:11 +01:00
ext4	ext4: fix special inode number checks in __ext4_iget()	2019-01-16 22:04:36 +01:00
f2fs	f2fs: fix sbi->extent_list corruption issue	2019-02-12 19:47:17 +01:00
fat	fs/fat/fatent.c: add cond_resched() to fat_count_free_clusters()	2018-10-13 09:31:03 +02:00
freevxfs
fscache	fscache: fix race between enablement and dropping of object	2018-12-17 09:24:40 +01:00
fuse	fuse: continue to send FUSE_RELEASEDIR when FUSE_OPEN returns ENOSYS	2018-12-19 19:19:51 +01:00
gfs2	gfs2: Revert "Fix loop in gfs2_rbm_find"	2019-02-06 17:30:13 +01:00
hfs	hfs: do not free node before using	2018-12-17 09:24:41 +01:00
hfsplus	hfsplus: do not free node before using	2018-12-17 09:24:41 +01:00
hostfs	vfs: discard ATTR_ATTR_FLAG	2018-08-17 16:20:28 -07:00
hpfs	hpfs: remove unnecessary checks on the value of r when assigning error code	2018-08-25 12:42:33 -07:00
hugetlbfs	mm: zero out the vma in vma_init()	2018-08-22 10:52:44 -07:00
isofs	isofs: reject hardware sector size > 2048 bytes	2018-08-21 11:37:41 +02:00
jbd2	jbd2: fix use after free in jbd2_log_do_checkpoint()	2018-11-13 11:08:43 -08:00
jffs2	jffs2: Fix use of uninitialized delayed_work, lockdep breakage	2019-01-26 09:32:37 +01:00
jfs	Just one jfs patch for 4.19	2018-08-15 22:47:23 -07:00
kernfs	Driver core patches for 4.19-rc1	2018-08-18 11:44:53 -07:00
lockd	lockd: Show pid of lockd for remote locks	2019-01-13 09:51:08 +01:00
minix
nfs	NFS: nfs_compare_mount_options always compare auth flavors.	2019-02-12 19:47:16 +01:00
nfs_common
nfsd	nfsd4: fix crash on writing v4_end_grace before nfsd startup	2019-02-12 19:47:03 +01:00
nilfs2	nilfs2: convert to SPDX license tags	2018-09-04 16:45:02 -07:00
nls
notify	inotify: Fix fd refcount leak in inotify_add_watch().	2019-01-31 08:14:34 +01:00
ntfs	ntfs: mft: remove VLA usage	2018-08-17 16:20:27 -07:00
ocfs2	ocfs2: don't clear bh uptodate for block read	2019-02-12 19:47:18 +01:00
omfs
openpromfs
orangefs	orangefs: remove redundant pointer orangefs_inode	2018-08-14 12:07:14 -04:00
overlayfs	ovl: fix missing override creds in link of a metacopy upper	2018-12-19 19:19:51 +01:00
proc	proc/sysctl: don't return ENOMEM on lookup when a table is unregistering	2018-12-29 13:37:59 +01:00
pstore	pstore/ram: Do not treat empty buffers as valid	2019-01-26 09:32:37 +01:00
qnx4
qnx6
quota	quota: Lock s_umount in exclusive mode for Q_XQUOTA{ON,OFF} quotactls.	2019-01-26 09:32:42 +01:00
ramfs
reiserfs	reiserfs: propagate errors from fill_with_dentries() properly	2018-11-27 16:12:59 +01:00
romfs
squashfs	Squashfs: Compute expected length from inode size rather than block length	2018-08-02 09:34:02 -07:00
sysfs	Driver core patches for 4.19-rc1	2018-08-18 11:44:53 -07:00
sysv	sysv: return 'err' instead of 0 in __sysv_write_inode	2018-12-17 09:24:30 +01:00
tracefs	tracefs: Annotate tracefs_ops with __ro_after_init	2018-07-31 11:32:44 -04:00
ubifs	ubifs: Handle re-linking of inodes correctly while recovery	2018-12-29 13:37:55 +01:00
udf	udf: Fix BUG on corrupted inode	2019-02-12 19:47:09 +01:00
ufs	fs/ufs: use ktime_get_real_seconds for sb and cg timestamps	2018-08-17 16:20:27 -07:00
xfs	xfs: fix data corruption w/ unaligned reflink ranges	2018-10-06 11:44:39 +10:00
aio.c	aio: fix spectre gadget in lookup_ioctx	2018-12-19 19:19:50 +01:00
anon_inodes.c	anon_inode_getfile(): switch to alloc_file_pseudo()	2018-07-12 10:04:27 -04:00
attr.c
bad_inode.c	get rid of 'opened' argument of ->atomic_open() - part 3	2018-07-12 10:04:20 -04:00
binfmt_aout.c
binfmt_elf.c	Here are the main MIPS changes for 4.19.	2018-08-13 19:24:32 -07:00
binfmt_elf_fdpic.c
binfmt_em86.c
binfmt_flat.c
binfmt_misc.c
binfmt_script.c
block_dev.c	blockdev: Fix livelocks on loop device	2019-01-22 21:40:36 +01:00
buffer.c	notifier: Remove notifier header file wherever not used	2018-08-30 12:56:40 +02:00
char_dev.c
compat.c
compat_binfmt_elf.c
compat_ioctl.c	media: dvb/audio.h: get rid of unused APIs	2018-07-30 16:21:49 -04:00
coredump.c
d_path.c
dax.c	dax: Use non-exclusive wait in wait_entry_unlocked()	2019-01-09 17:38:46 +01:00
dcache.c	fs/dcache: Fix incorrect nr_dentry_unused accounting in shrink_dcache_sb()	2019-02-06 17:30:11 +01:00
dcookies.c
direct-io.c	fs: fix lost error code in dio_complete	2018-12-05 19:32:08 +01:00
drop_caches.c
eventfd.c
eventpoll.c	fs/eventpoll.c: simplify ep_is_linked() callers	2018-08-22 10:52:49 -07:00
exec.c	Merge branch 'siginfo-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2018-08-21 13:47:29 -07:00
fcntl.c	signal: Don't send signals to tasks that don't exist	2018-08-15 23:03:20 -05:00
fhandle.c
file.c
file_table.c	overlayfs update for 4.19	2018-08-21 18:19:09 -07:00
filesystems.c
fs-writeback.c
fs_pin.c
fs_struct.c
inode.c	mm: don't reclaim inodes with many attached pages	2018-11-21 09:19:25 +01:00
internal.h	overlayfs update for 4.19	2018-08-21 18:19:09 -07:00
ioctl.c	vfs: fix FIGETBSZ ioctl on an overlayfs file	2018-11-21 09:19:14 +01:00
iomap.c	iomap: don't search past page end in iomap_is_partially_uptodate	2019-01-26 09:32:43 +01:00
Kconfig
Kconfig.binfmt	kconfig: move the "Executable file formats" menu to fs/Kconfig.binfmt	2018-08-02 08:06:55 +09:00
libfs.c
locks.c	overlayfs update for 4.19	2018-08-21 18:19:09 -07:00
Makefile
mbcache.c
mount.h
mpage.c	mpage: mpage_readpages() should submit IO as read-ahead	2018-08-17 16:20:29 -07:00
namei.c	Revert "vfs: Allow userns root to call mknod on owned filesystems."	2018-12-29 13:37:54 +01:00
namespace.c	mnt: fix __detach_mounts infinite loop	2018-11-21 09:19:22 +01:00
no-block.c
nsfs.c
open.c	overlayfs update for 4.19	2018-08-21 18:19:09 -07:00
pipe.c	Merge branch 'work.open3' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-08-13 19:58:36 -07:00
pnode.c
pnode.h
posix_acl.c
proc_namespace.c
read_write.c	vfs: swap names of {do,vfs}_clone_file_range()	2018-09-24 10:54:01 +02:00
readdir.c
select.c
seq_file.c	fs/seq_file.c: simplify seq_file iteration code and interface	2018-08-17 16:20:28 -07:00
signalfd.c
splice.c
stack.c
stat.c
statfs.c	kernel: add kcompat_sys_{f,}statfs64()	2018-07-12 14:49:48 +01:00
super.c	Merge branch 'ida-4.19' of git://git.infradead.org/users/willy/linux-dax	2018-08-26 11:48:42 -07:00
sync.c
timerfd.c	Merge branch 'work.aio' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-08-13 20:56:23 -07:00
userfaultfd.c	userfaultfd: clear flag if remap event not enabled	2019-01-26 09:32:43 +01:00
utimes.c
xattr.c	sysfs: Do not return POSIX ACL xattrs via listxattr	2018-09-18 07:30:48 -04:00