Yi Yang cbb7d8a4b4 ipmi_si: fix a memleak in try_smi_init() ... commit 6cf1a126de upstream. Kmemleak reported the following leak info in try_smi_init(): unreferenced object 0xffff00018ecf9400 (size 1024): comm "modprobe", pid 2707763, jiffies 4300851415 (age 773.308s) backtrace: [<000000004ca5b312>] __kmalloc+0x4b8/0x7b0 [<00000000953b1072>] try_smi_init+0x148/0x5dc [ipmi_si] [<000000006460d325>] 0xffff800081b10148 [<0000000039206ea5>] do_one_initcall+0x64/0x2a4 [<00000000601399ce>] do_init_module+0x50/0x300 [<000000003c12ba3c>] load_module+0x7a8/0x9e0 [<00000000c246fffe>] __se_sys_init_module+0x104/0x180 [<00000000eea99093>] __arm64_sys_init_module+0x24/0x30 [<0000000021b1ef87>] el0_svc_common.constprop.0+0x94/0x250 [<0000000070f4f8b7>] do_el0_svc+0x48/0xe0 [<000000005a05337f>] el0_svc+0x24/0x3c [<000000005eb248d6>] el0_sync_handler+0x160/0x164 [<0000000030a59039>] el0_sync+0x160/0x180 The problem was that when an error occurred before handlers registration and after allocating `new_smi->si_sm`, the variable wouldn't be freed in the error handling afterwards since `shutdown_smi()` hadn't been registered yet. Fix it by adding a `kfree()` in the error handling path in `try_smi_init()`. Cc: stable@vger.kernel.org # 4.19+ Fixes: 7960f18a56 ("ipmi_si: Convert over to a shutdown handler") Signed-off-by: Yi Yang <yiyang13@huawei.com> Co-developed-by: GONG, Ruiqi <gongruiqi@huaweicloud.com> Signed-off-by: GONG, Ruiqi <gongruiqi@huaweicloud.com> Message-Id: <20230629123328.2402075-1-gongruiqi@huaweicloud.com> Signed-off-by: Corey Minyard <minyard@acm.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-09-19 12:22:50 +02:00
..
agp	parisc: Flush gatt writes and adjust gatt mask in parisc_agp_mask_memory()	2023-06-21 15:59:13 +02:00
hw_random	hwrng: iproc-rng200 - Implement suspend and resume calls	2023-09-19 12:22:33 +02:00
ipmi	ipmi_si: fix a memleak in try_smi_init()	2023-09-19 12:22:50 +02:00
mwave
pcmcia	Revert "char: pcmcia: cm4000_cs: Replace mdelay with usleep_range in set_protocol"	2023-03-10 09:39:38 +01:00
tpm	tpm_tis: Explicitly check for error code	2023-08-03 10:22:44 +02:00
xilinx_hwicap
xillybus	char: xillybus: fix a refcount leak in cleanup_dev()	2022-06-14 18:36:21 +02:00
adi.c
apm-emulation.c
applicom.c	applicom: Fix PCI device refcount leak in applicom_init()	2023-03-10 09:39:38 +01:00
applicom.h
bsr.c
ds1620.c
dsp56k.c
dtlk.c
hangcheck-timer.c
hpet.c
Kconfig	random: credit cpu and bootloader seeds by default	2022-06-22 14:21:58 +02:00
lp.c
Makefile
mem.c	random: restore O_NONBLOCK support	2022-10-15 07:59:01 +02:00
misc.c
mspec.c
nsc_gpio.c
nvram.c
nwbutton.c
nwbutton.h
nwflash.c
pc8736x_gpio.c
powernv-op-panel.c
ppdev.c
ps3flash.c
random.c	random: use expired timer rather than wq for mixing fast pool	2022-10-15 07:59:02 +02:00
scx200_gpio.c
sonypi.c
tb0219.c
tlclk.c
toshiba.c
ttyprintk.c
uv_mmtimer.c
virtio_console.c