mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-05 02:19:51 +00:00
45413bf759
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() is renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Pavel Pisa <pisa@cmp.felk.cvut.cz> Link: https://lore.kernel.org/r/20230512212725.143824-7-u.kleine-koenig@pengutronix.de Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
126 lines
3.4 KiB
C
126 lines
3.4 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*******************************************************************************
|
|
*
|
|
* CTU CAN FD IP Core
|
|
*
|
|
* Copyright (C) 2015-2018 Ondrej Ille <ondrej.ille@gmail.com> FEE CTU
|
|
* Copyright (C) 2018-2021 Ondrej Ille <ondrej.ille@gmail.com> self-funded
|
|
* Copyright (C) 2018-2019 Martin Jerabek <martin.jerabek01@gmail.com> FEE CTU
|
|
* Copyright (C) 2018-2022 Pavel Pisa <pisa@cmp.felk.cvut.cz> FEE CTU/self-funded
|
|
*
|
|
* Project advisors:
|
|
* Jiri Novak <jnovak@fel.cvut.cz>
|
|
* Pavel Pisa <pisa@cmp.felk.cvut.cz>
|
|
*
|
|
* Department of Measurement (http://meas.fel.cvut.cz/)
|
|
* Faculty of Electrical Engineering (http://www.fel.cvut.cz)
|
|
* Czech Technical University (http://www.cvut.cz/)
|
|
******************************************************************************/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/netdevice.h>
|
|
#include <linux/of.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/pm_runtime.h>
|
|
|
|
#include "ctucanfd.h"
|
|
|
|
#define DRV_NAME "ctucanfd"
|
|
|
|
static void ctucan_platform_set_drvdata(struct device *dev,
|
|
struct net_device *ndev)
|
|
{
|
|
struct platform_device *pdev = container_of(dev, struct platform_device,
|
|
dev);
|
|
|
|
platform_set_drvdata(pdev, ndev);
|
|
}
|
|
|
|
/**
|
|
* ctucan_platform_probe - Platform registration call
|
|
* @pdev: Handle to the platform device structure
|
|
*
|
|
* This function does all the memory allocation and registration for the CAN
|
|
* device.
|
|
*
|
|
* Return: 0 on success and failure value on error
|
|
*/
|
|
static int ctucan_platform_probe(struct platform_device *pdev)
|
|
{
|
|
struct device *dev = &pdev->dev;
|
|
void __iomem *addr;
|
|
int ret;
|
|
unsigned int ntxbufs;
|
|
int irq;
|
|
|
|
/* Get the virtual base address for the device */
|
|
addr = devm_platform_ioremap_resource(pdev, 0);
|
|
if (IS_ERR(addr)) {
|
|
ret = PTR_ERR(addr);
|
|
goto err;
|
|
}
|
|
irq = platform_get_irq(pdev, 0);
|
|
if (irq < 0) {
|
|
ret = irq;
|
|
goto err;
|
|
}
|
|
|
|
/* Number of tx bufs might be change in HW for future. If so,
|
|
* it will be passed as property via device tree
|
|
*/
|
|
ntxbufs = 4;
|
|
ret = ctucan_probe_common(dev, addr, irq, ntxbufs, 0,
|
|
1, ctucan_platform_set_drvdata);
|
|
|
|
if (ret < 0)
|
|
platform_set_drvdata(pdev, NULL);
|
|
|
|
err:
|
|
return ret;
|
|
}
|
|
|
|
/**
|
|
* ctucan_platform_remove - Unregister the device after releasing the resources
|
|
* @pdev: Handle to the platform device structure
|
|
*
|
|
* This function frees all the resources allocated to the device.
|
|
* Return: 0 always
|
|
*/
|
|
static void ctucan_platform_remove(struct platform_device *pdev)
|
|
{
|
|
struct net_device *ndev = platform_get_drvdata(pdev);
|
|
struct ctucan_priv *priv = netdev_priv(ndev);
|
|
|
|
netdev_dbg(ndev, "ctucan_remove");
|
|
|
|
unregister_candev(ndev);
|
|
pm_runtime_disable(&pdev->dev);
|
|
netif_napi_del(&priv->napi);
|
|
free_candev(ndev);
|
|
}
|
|
|
|
static SIMPLE_DEV_PM_OPS(ctucan_platform_pm_ops, ctucan_suspend, ctucan_resume);
|
|
|
|
/* Match table for OF platform binding */
|
|
static const struct of_device_id ctucan_of_match[] = {
|
|
{ .compatible = "ctu,ctucanfd-2", },
|
|
{ .compatible = "ctu,ctucanfd", },
|
|
{ /* end of list */ },
|
|
};
|
|
MODULE_DEVICE_TABLE(of, ctucan_of_match);
|
|
|
|
static struct platform_driver ctucanfd_driver = {
|
|
.probe = ctucan_platform_probe,
|
|
.remove_new = ctucan_platform_remove,
|
|
.driver = {
|
|
.name = DRV_NAME,
|
|
.pm = &ctucan_platform_pm_ops,
|
|
.of_match_table = ctucan_of_match,
|
|
},
|
|
};
|
|
|
|
module_platform_driver(ctucanfd_driver);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_AUTHOR("Martin Jerabek");
|
|
MODULE_DESCRIPTION("CTU CAN FD for platform");
|