Krzysztof Kozlowski 6e4a2a83f9 dmaengine: pl330: Fix NULL pointer dereference on driver unbind ... Fix a NULL pointer dereference after unbinding the driver, if channel resources were not yet allocated (no call to pl330_alloc_chan_resources()): $ echo 12850000.mdma > /sys/bus/amba/drivers/dma-pl330/unbind [ 13.606533] DMA pl330_control: removing pch: eeab6800, chan: eeab6814, thread: (null) [ 13.614472] Unable to handle kernel NULL pointer dereference at virtual address 0000000c [ 13.622537] pgd = ee284000 [ 13.625228] [0000000c] *pgd=6e1e4831, *pte=00000000, *ppte=00000000 [ 13.631482] Internal error: Oops: 17 [#1] PREEMPT SMP ARM [ 13.636859] Modules linked in: [ 13.639903] CPU: 0 PID: 1 Comm: sh Not tainted 3.17.0-rc3-next-20140904-00004-g7020ffc33ca3-dirty #420 [ 13.649187] task: ee80a800 ti: ee888000 task.ti: ee888000 [ 13.654589] PC is at _stop+0x8/0x2c8 [ 13.658131] LR is at pl330_control+0x70/0x2e8 [ 13.662468] pc : [<c0206028>] lr : [<c020649c>] psr: 60000093 [ 13.662468] sp : ee889e58 ip : 00000001 fp : 000bab70 [ 13.673922] r10: eeab6814 r9 : ee16debc r8 : 00000000 [ 13.679131] r7 : eeab685c r6 : 60000013 r5 : ee16de10 r4 : eeab6800 [ 13.685641] r3 : 00000002 r2 : 00000000 r1 : 00010000 r0 : 00000000 [ 13.692153] Flags: nZCv IRQs off FIQs on Mode SVC_32 ISA ARM Segment user [ 13.699357] Control: 10c5387d Table: 6e28404a DAC: 00000015 [ 13.705085] Process sh (pid: 1, stack limit = 0xee888240) [ 13.710466] Stack: (0xee889e58 to 0xee88a000) [ 13.714808] 9e40: 00000002 eeab6800 [ 13.722969] 9e60: ee16de10 eeab6800 ee16de10 60000013 eeab685c c020649c 00000000 c040280c [ 13.731128] 9e80: ee889e80 ee889e80 ee16de18 ee16de10 eeab6880 eeab6814 00200200 eeab68a8 [ 13.739287] 9ea0: 00100100 c0208048 00000000 c0409fc4 eea80800 eea808f8 c0605c44 0000000e [ 13.747446] 9ec0: 0000000e eeb3960c eeb39600 c0203c48 eea80800 c0605c44 c0605a8c c023f694 [ 13.755605] 9ee0: ee80a800 eea80834 eea80800 c023f704 ee80a800 eea80800 c0605c44 c023e8ec [ 13.763764] 9f00: 0000000e ee149780 ee29e580 ee889f80 ee29e580 c023e19c 0000000e c01167e4 [ 13.771923] 9f20: c01167a0 00000000 00000000 c0115e88 00000000 00000000 ee0b1a00 0000000e [ 13.780082] 9f40: b6f48000 ee889f80 0000000e ee888000 b6f48000 c00bfadc 00000000 00000003 [ 13.788241] 9f60: 00000000 00000000 00000000 ee0b1a00 ee0b1a00 0000000e b6f48000 c00bfdf4 [ 13.796401] 9f80: 00000000 00000000 ffffffff 0000000e b6f48000 b6edc5d0 00000004 c000e7a4 [ 13.804560] 9fa0: 00000000 c000e620 0000000e b6f48000 00000001 b6f48000 0000000e 00000000 [ 13.812719] 9fc0: 0000000e b6f48000 b6edc5d0 00000004 0000000e b6f4c8c0 000c3470 000bab70 [ 13.820879] 9fe0: 00000000 bed2aa50 b6e18bdc b6e6b52c 60000010 00000001 c0c0c0c0 c0c0c0c0 [ 13.829058] [<c0206028>] (_stop) from [<c020649c>] (pl330_control+0x70/0x2e8) [ 13.836165] [<c020649c>] (pl330_control) from [<c0208048>] (pl330_remove+0xb0/0xdc) [ 13.843800] [<c0208048>] (pl330_remove) from [<c0203c48>] (amba_remove+0x24/0xc0) [ 13.851272] [<c0203c48>] (amba_remove) from [<c023f694>] (__device_release_driver+0x70/0xc4) [ 13.859685] [<c023f694>] (__device_release_driver) from [<c023f704>] (device_release_driver+0x1c/0x28) [ 13.868971] [<c023f704>] (device_release_driver) from [<c023e8ec>] (unbind_store+0x58/0x90) [ 13.877303] [<c023e8ec>] (unbind_store) from [<c023e19c>] (drv_attr_store+0x20/0x2c) [ 13.885036] [<c023e19c>] (drv_attr_store) from [<c01167e4>] (sysfs_kf_write+0x44/0x48) [ 13.892928] [<c01167e4>] (sysfs_kf_write) from [<c0115e88>] (kernfs_fop_write+0xc0/0x17c) [ 13.901090] [<c0115e88>] (kernfs_fop_write) from [<c00bfadc>] (vfs_write+0xa0/0x1a8) [ 13.908812] [<c00bfadc>] (vfs_write) from [<c00bfdf4>] (SyS_write+0x40/0x8c) [ 13.915850] [<c00bfdf4>] (SyS_write) from [<c000e620>] (ret_fast_syscall+0x0/0x30) [ 13.923392] Code: e5813010 e12fff1e e92d40f0 e24dd00c (e590200c) [ 13.929467] ---[ end trace 10064e15a5929cf8 ]--- Terminate the thread and free channel resource only if channel resources were allocated (thread is not NULL). Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Cc: <stable@vger.kernel.org> Fixes: b3040e4067 ("DMA: PL330: Add dma api driver") Reviewed-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Vinod Koul <vinod.koul@intel.com>		2014-10-15 13:30:09 +05:30
..
accessibility
acpi	More ACPI and power management updates for 3.17-rc1	2014-08-14 18:13:46 -06:00
amba
ata	Merge branch 'akpm' (patchbomb from Andrew Morton)	2014-08-06 21:14:42 -07:00
atm	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2014-08-13 18:27:40 -06:00
auxdisplay
base	Merge branch 'akpm' (patchbomb from Andrew Morton)	2014-08-06 21:14:42 -07:00
bcma	bcma: use NS prefix for names of Northstar specific cores	2014-07-31 13:45:32 -04:00
block	PCI changes for the v3.17 merge window (part 2):	2014-08-14 18:10:33 -06:00
bluetooth	Bluetooth: Fix crash in the Marvell driver initialization codepath	2014-07-31 01:07:28 +02:00
bus	ARM: SoC driver changes for 3.17	2014-08-08 11:34:32 -07:00
cdrom
char	virtio: rng: add derating factor for use by hwrng core	2014-08-15 10:26:01 +05:30
clk	ARM: SoC platform changes for 3.17	2014-08-08 11:14:29 -07:00
clocksource	ARM: SoC platform changes for 3.17	2014-08-08 11:14:29 -07:00
connector
cpufreq	More ACPI and power management updates for 3.17-rc1	2014-08-14 18:13:46 -06:00
cpuidle	More ACPI and power management updates for 3.17-rc1	2014-08-14 18:13:46 -06:00
crypto	PCI changes for the v3.17 merge window (part 2):	2014-08-14 18:10:33 -06:00
dca
devfreq
dio
dma	dmaengine: pl330: Fix NULL pointer dereference on driver unbind	2014-10-15 13:30:09 +05:30
dma-buf
edac	Merge branch 'linux_next' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-edac	2014-08-15 17:56:45 -06:00
eisa
extcon
firewire	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2014-08-06 09:38:14 -07:00
firmware	kexec: support kexec/kdump on EFI systems	2014-08-08 15:57:33 -07:00
fmc
gpio	This is the bulk of GPIO changes for the v3.17 development	2014-08-08 18:00:35 -07:00
gpu	Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux	2014-08-15 17:57:49 -06:00
hid	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2014-08-15 18:16:28 -06:00
hsi	HSI changes for the v3.17 series	2014-08-06 20:06:14 -07:00
hv	Char / Misc driver patches for 3.17-rc1	2014-08-04 17:32:24 -07:00
hwmon	Several bug fixes in various drivers, plus a minor cleanup	2014-08-14 09:55:13 -06:00
hwspinlock
i2c	Merge branch 'i2c/for-3.17' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux	2014-08-09 09:15:07 -07:00
ide	ide: use module_platform_driver()	2014-08-05 21:16:46 -07:00
idle	intel_idle: Broadwell support	2014-08-15 17:06:40 -04:00
iio	Staging driver patches for 3.17-rc1	2014-08-04 18:36:12 -07:00
infiniband	PCI changes for the v3.17 merge window (part 2):	2014-08-14 18:10:33 -06:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2014-08-15 18:16:28 -06:00
iommu	ARM: SoC cleanups for 3.17	2014-08-08 11:00:26 -07:00
ipack
irqchip	ARM: SoC platform changes for 3.17	2014-08-08 11:14:29 -07:00
isdn	net: filter: split 'struct sk_filter' into socket and bpf parts	2014-08-02 15:03:58 -07:00
leds	ARM: SoC driver changes for 3.17	2014-08-08 11:34:32 -07:00
lguest	mm/vmalloc.c: clean up map_vm_area third argument	2014-08-06 18:01:19 -07:00
macintosh	== Changes to existing drivers ==	2014-08-07 17:23:16 -07:00
mailbox
mcb
md	. Allow the thin target to paired with any size external origin; also	2014-08-14 09:17:56 -06:00
media	media: use pci_zalloc_consistent	2014-08-08 15:57:28 -07:00
memory
memstick
message
mfd	drivers/mfd/rtsx_usb.c: export device table	2014-08-14 10:56:15 -06:00
misc	ARM: SoC driver changes for 3.17	2014-08-08 11:34:32 -07:00
mmc	PCI changes for the v3.17 merge window (part 2):	2014-08-14 18:10:33 -06:00
mtd	No significant changes, mostly small fixes here and there. The more important	2014-08-13 17:42:11 -06:00
net	PCI changes for the v3.17 merge window (part 2):	2014-08-14 18:10:33 -06:00
nfc
ntb
nubus
of	The branch contains the following device tree changes the v3.17 merge	2014-08-14 09:53:39 -06:00
oprofile
parisc
parport	drivers/parport/parport_ip32.c: use PTR_ERR_OR_ZERO	2014-08-08 15:57:25 -07:00
pci	PCI changes for the v3.17 merge window (part 2):	2014-08-14 18:10:33 -06:00
pcmcia	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc	2014-08-07 08:50:34 -07:00
phy	ARM: SoC driver changes for 3.17	2014-08-08 11:34:32 -07:00
pinctrl	ARM: SoC driver changes for 3.17	2014-08-08 11:34:32 -07:00
platform	platform/x86: Enable build support for toshiba_haps	2014-08-16 01:23:56 -07:00
pnp
power	ARM: SoC platform changes for 3.17	2014-08-08 11:14:29 -07:00
powercap
pps
ps3
ptp	PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use	2014-08-12 12:15:14 -06:00
pwm	pwm: Changes for v3.17-rc1	2014-08-08 18:06:29 -07:00
rapidio	PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use	2014-08-12 12:15:14 -06:00
ras
regulator	== Changes to existing drivers ==	2014-08-07 17:17:39 -07:00
remoteproc
reset
rpmsg
rtc	Merge branch 'akpm' (second patchbomb from Andrew Morton)	2014-08-08 15:57:47 -07:00
s390	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux	2014-08-07 08:41:00 -07:00
sbus	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc	2014-08-05 18:57:18 -07:00
scsi	SCSI misc on 20140815	2014-08-15 18:28:58 -06:00
sfi
sh
sn
soc
spi	spi/pxa2xx-pci: Add support for Intel Braswell	2014-09-18 11:54:07 +05:30
spmi
ssb
staging	Merge branch 'akpm' (second patchbomb from Andrew Morton)	2014-08-08 15:57:47 -07:00
target	SCSI misc on 20140806	2014-08-06 20:10:32 -07:00
tc
thermal
thunderbolt
tty	serial: 8250_pci: Add PCI IDs for Intel Braswell	2014-09-11 11:48:36 +05:30
uio
usb	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2014-08-06 21:03:53 -07:00
uwb	uwb/whci: use correct structure type name in sizeof	2014-08-01 15:48:08 -07:00
vfio	drivers/vfio: Enable VFIO if EEH is not supported	2014-08-08 10:39:16 -06:00
vhost
video	PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use	2014-08-12 12:15:14 -06:00
virt
virtio
vlynq
vme	vme: bridges: use pci_zalloc_consistent	2014-08-08 15:57:30 -07:00
w1
watchdog	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2014-08-07 08:47:00 -07:00
xen	PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use	2014-08-12 12:15:14 -06:00
zorro
Kconfig	Char / Misc driver patches for 3.17-rc1	2014-08-04 17:32:24 -07:00
Makefile	Driver core patches for 3.17-rc1	2014-08-04 18:34:04 -07:00