Damien Le Moal 24eca2dce0 scsi: sd: Introduce manage_shutdown device flag ... Commit aa3998dbeb ("ata: libata-scsi: Disable scsi device manage_system_start_stop") change setting the manage_system_start_stop flag to false for libata managed disks to enable libata internal management of disk suspend/resume. However, a side effect of this change is that on system shutdown, disks are no longer being stopped (set to standby mode with the heads unloaded). While this is not a critical issue, this unclean shutdown is not recommended and shows up with increased smart counters (e.g. the unexpected power loss counter "Unexpect_Power_Loss_Ct"). Instead of defining a shutdown driver method for all ATA adapter drivers (not all of them define that operation), this patch resolves this issue by further refining the sd driver start/stop control of disks using the new flag manage_shutdown. If this new flag is set to true by a low level driver, the function sd_shutdown() will issue a START STOP UNIT command with the start argument set to 0 when a disk needs to be powered off (suspended) on system power off, that is, when system_state is equal to SYSTEM_POWER_OFF. Similarly to the other manage_xxx flags, the new manage_shutdown flag is exposed through sysfs as a read-write device attribute. To avoid any confusion between manage_shutdown and manage_system_start_stop, the comments describing these flags in include/scsi/scsi.h are also improved. Fixes: aa3998dbeb ("ata: libata-scsi: Disable scsi device manage_system_start_stop") Cc: stable@vger.kernel.org Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218038 Link: https://lore.kernel.org/all/cd397c88-bf53-4768-9ab8-9d107df9e613@gmail.com/ Signed-off-by: Damien Le Moal <dlemoal@kernel.org> Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com> Reviewed-by: Hannes Reinecke <hare@suse.de> Reviewed-by: James Bottomley <James.Bottomley@HansenPartnership.com> Acked-by: Martin K. Petersen <martin.petersen@oracle.com>		2023-10-27 10:00:19 +09:00
..
pata_parport	ata: pata_parport: fit3: implement IDE command set registers	2023-10-10 14:42:22 +09:00
acard-ahci.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
ahci.c	ata: libata: disallow dev-initiated LPM transitions to unsupported states	2023-09-11 15:09:11 +09:00
ahci.h	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
ahci_brcm.c	ata: libata: Make ata_platform_remove_one return void	2023-05-15 06:49:39 +09:00
ahci_ceva.c	ata: Explicitly include correct DT includes	2023-08-02 17:37:05 +09:00
ahci_da850.c	ata: libata: Make ata_platform_remove_one return void	2023-05-15 06:49:39 +09:00
ahci_dm816.c	ata: libata: Make ata_platform_remove_one return void	2023-05-15 06:49:39 +09:00
ahci_dwc.c	ata: Explicitly include correct DT includes	2023-08-02 17:37:05 +09:00
ahci_imx.c	ata: libata: Make ata_platform_remove_one return void	2023-05-15 06:49:39 +09:00
ahci_mtk.c	ata: Explicitly include correct DT includes	2023-08-02 17:37:05 +09:00
ahci_mvebu.c	ata: Explicitly include correct DT includes	2023-08-02 17:37:05 +09:00
ahci_octeon.c	ata: ahci_octeon: Convert to devm_platform_ioremap_resource()	2023-08-02 17:37:06 +09:00
ahci_platform.c	driver core changes for 6.5-rc1	2023-07-03 12:56:23 -07:00
ahci_qoriq.c	ata: fix debounce timings type	2023-08-02 17:37:06 +09:00
ahci_seattle.c	ata: ahci_seattle: Convert to devm_platform_ioremap_resource()	2023-08-02 17:37:06 +09:00
ahci_st.c	ata: libata: Make ata_platform_remove_one return void	2023-05-15 06:49:39 +09:00
ahci_sunxi.c	ata: Explicitly include correct DT includes	2023-08-02 17:37:05 +09:00
ahci_tegra.c	ata: ahci_tegra: Convert to devm_platform_ioremap_resource()	2023-08-02 17:37:06 +09:00
ahci_xgene.c	ata: ahci_xgene: fix parameter types of xgene_ahci_poll_reg_val()	2023-08-02 17:37:07 +09:00
ata_generic.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
ata_piix.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
Kconfig	ahci: qoriq: Add platform dependencies	2023-03-23 10:29:26 +09:00
libahci.c	ata: libahci: clear pending interrupt status	2023-09-15 11:34:31 +09:00
libahci_platform.c	ata: Explicitly include correct DT includes	2023-08-02 17:37:05 +09:00
libata-acpi.c	ata: make use of ata_port_is_frozen() helper	2022-10-18 13:53:27 +09:00
libata-core.c	ata: libata-core: Fix compilation warning in ata_dev_config_ncq()	2023-09-28 21:24:10 +09:00
libata-eh.c	ata: libata-eh: Fix compilation warning in ata_eh_link_report()	2023-09-28 21:24:18 +09:00
libata-pata-timings.c	ata: separate PATA timings code from libata-core.c	2020-03-26 10:28:19 -06:00
libata-pmp.c	ata: libata: add tracepoints for ATA error handling	2022-01-05 19:33:01 +09:00
libata-sata.c	ata: libata: disallow dev-initiated LPM transitions to unsupported states	2023-09-11 15:09:11 +09:00
libata-scsi.c	scsi: sd: Introduce manage_shutdown device flag	2023-10-27 10:00:19 +09:00
libata-sff.c	ata: libata: remove references to non-existing error_handler()	2023-08-02 17:45:10 +09:00
libata-trace.c	ata: scsi: rename flag ATA_QCFLAG_FAILED to ATA_QCFLAG_EH	2023-01-04 13:36:26 +09:00
libata-transport.c	ata: libata-core: Do not register PM operations for SAS ports	2023-09-28 21:23:14 +09:00
libata-transport.h
libata-zpodd.c	libata: zpodd: Fix small read overflow in zpodd_get_mech_type()	2019-07-29 16:00:14 -06:00
libata.h	ata: libata-core: Do not register PM operations for SAS ports	2023-09-28 21:23:14 +09:00
Makefile	ATA changes for 6.3-rc1	2023-02-22 13:35:51 -08:00
pata_acpi.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_ali.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_amd.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_arasan_cf.c	ata: pata_arasan_cf: Convert to platform remove callback returning void	2023-08-02 17:53:09 +09:00
pata_artop.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_atiixp.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_atp867x.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_buddha.c	ata: pata_buddha: Remove #include <asm/ide.h>	2023-08-24 08:09:59 +09:00
pata_cmd64x.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_cmd640.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_cs5520.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_cs5530.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_cs5535.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_cs5536.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_cypress.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_efar.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_ep93xx.c	ata: pata_ep93xx: use soc_device_match for UDMA modes	2023-08-25 22:09:43 +09:00
pata_falcon.c	ata: pata_falcon: add data_swab option to byte-swap disk data	2023-08-28 19:14:41 +09:00
pata_ftide010.c	ata: pata_ftide010: Add missing MODULE_DESCRIPTION	2023-08-25 08:21:03 +09:00
pata_gayle.c	ata: pata_gayle: Remove #include <asm/ide.h>	2023-08-24 08:09:59 +09:00
pata_hpt3x2n.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_hpt3x3.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_hpt37x.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_hpt366.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_icside.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_imx.c	ata: pata_imx: Use helper function devm_clk_get_enabled()	2023-08-17 07:45:32 +09:00
pata_isapnp.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_it821x.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_it8213.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_ixp4xx_cf.c	ata: pata_ixp4xx: Remove unnecessary return value check	2023-08-02 17:37:06 +09:00
pata_jmicron.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_legacy.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_macio.c	SCSI misc on 20230426	2023-04-26 15:39:25 -07:00
pata_marvell.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_mpc52xx.c	ata: pata_mpc52xx: Convert to platform remove callback returning void	2023-08-02 17:55:49 +09:00
pata_mpiix.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_netcell.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_ninja32.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_ns87410.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_ns87415.c	ata: pata_ns87415: mark ns87560_tf_read static	2023-07-28 08:52:42 +09:00
pata_octeon_cf.c	ata: pata_octeon_cf: fix error return code in octeon_cf_probe()	2023-07-26 08:32:21 +09:00
pata_of_platform.c	ata: libata: Make ata_platform_remove_one return void	2023-05-15 06:49:39 +09:00
pata_oldpiix.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_opti.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_optidma.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_pcmcia.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_pdc202xx_old.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_pdc2027x.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_piccolo.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_platform.c	ata: libata: Make ata_platform_remove_one return void	2023-05-15 06:49:39 +09:00
pata_pxa.c	ata: pata_pxa: Convert to platform remove callback returning void	2023-08-02 17:55:52 +09:00
pata_radisys.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_rb532_cf.c	ata: pata_rb532_cf: Convert to platform remove callback returning void	2023-08-02 17:55:52 +09:00
pata_rdc.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_rz1000.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_sc1200.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_sch.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_serverworks.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_sil680.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_sis.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_sl82c105.c	ata: libata: remove deprecated EH callbacks	2023-08-02 17:45:42 +09:00
pata_triflex.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_via.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pdc_adma.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_dwc_460ex.c	ata: sata_dwc_460ex: Convert to platform remove callback returning void	2023-08-02 17:55:52 +09:00
sata_fsl.c	ata: sata_fsl: Convert to platform remove callback returning void	2023-08-02 17:55:52 +09:00
sata_gemini.c	ata: sata_gemini: Add missing MODULE_DESCRIPTION	2023-08-25 08:21:29 +09:00
sata_gemini.h
sata_highbank.c	ata: fix debounce timings type	2023-08-02 17:37:06 +09:00
sata_inic162x.c	ata: fix debounce timings type	2023-08-02 17:37:06 +09:00
sata_mv.c	ata: sata_mv: Fix incorrect string length computation in mv_dump_mem()	2023-09-11 15:13:35 +09:00
sata_nv.c	ata: fix debounce timings type	2023-08-02 17:37:06 +09:00
sata_promise.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_promise.h
sata_qstor.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_rcar.c	ata: sata_rcar: Convert to platform remove callback returning void	2023-08-02 17:55:52 +09:00
sata_sil.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_sil24.c	ata: sata_sil24: fix parameter type of sil24_exec_polled_cmd()	2023-08-02 17:37:07 +09:00
sata_sis.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_svw.c	ata: Use of_property_read_reg() to parse "reg"	2023-06-13 15:38:48 +09:00
sata_sx4.c	ata: sata_sx4: drop already completed TODO	2023-08-02 17:45:33 +09:00
sata_uli.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_via.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_vsc.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sis.h