mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-29 23:53:32 +00:00
f946270d05
We had a number of bugs in the past because developers forgot to fully test dumps, which pass NULL as info to .prepare_data. .prepare_data implementations would try to access info->extack leading to a null-deref. Now that dumps and notifications can access struct genl_info we can pass it in, and remove the info null checks. Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com> Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com> # pause Reviewed-by: Jiri Pirko <jiri@nvidia.com> Link: https://lore.kernel.org/r/20230814214723.2924989-11-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
160 lines
4.1 KiB
C
160 lines
4.1 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
|
|
#include <linux/ethtool.h>
|
|
|
|
#include "netlink.h"
|
|
#include "common.h"
|
|
#include "bitset.h"
|
|
|
|
struct module_req_info {
|
|
struct ethnl_req_info base;
|
|
};
|
|
|
|
struct module_reply_data {
|
|
struct ethnl_reply_data base;
|
|
struct ethtool_module_power_mode_params power;
|
|
};
|
|
|
|
#define MODULE_REPDATA(__reply_base) \
|
|
container_of(__reply_base, struct module_reply_data, base)
|
|
|
|
/* MODULE_GET */
|
|
|
|
const struct nla_policy ethnl_module_get_policy[ETHTOOL_A_MODULE_HEADER + 1] = {
|
|
[ETHTOOL_A_MODULE_HEADER] = NLA_POLICY_NESTED(ethnl_header_policy),
|
|
};
|
|
|
|
static int module_get_power_mode(struct net_device *dev,
|
|
struct module_reply_data *data,
|
|
struct netlink_ext_ack *extack)
|
|
{
|
|
const struct ethtool_ops *ops = dev->ethtool_ops;
|
|
|
|
if (!ops->get_module_power_mode)
|
|
return 0;
|
|
|
|
return ops->get_module_power_mode(dev, &data->power, extack);
|
|
}
|
|
|
|
static int module_prepare_data(const struct ethnl_req_info *req_base,
|
|
struct ethnl_reply_data *reply_base,
|
|
const struct genl_info *info)
|
|
{
|
|
struct module_reply_data *data = MODULE_REPDATA(reply_base);
|
|
struct net_device *dev = reply_base->dev;
|
|
int ret;
|
|
|
|
ret = ethnl_ops_begin(dev);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = module_get_power_mode(dev, data, info->extack);
|
|
if (ret < 0)
|
|
goto out_complete;
|
|
|
|
out_complete:
|
|
ethnl_ops_complete(dev);
|
|
return ret;
|
|
}
|
|
|
|
static int module_reply_size(const struct ethnl_req_info *req_base,
|
|
const struct ethnl_reply_data *reply_base)
|
|
{
|
|
struct module_reply_data *data = MODULE_REPDATA(reply_base);
|
|
int len = 0;
|
|
|
|
if (data->power.policy)
|
|
len += nla_total_size(sizeof(u8)); /* _MODULE_POWER_MODE_POLICY */
|
|
|
|
if (data->power.mode)
|
|
len += nla_total_size(sizeof(u8)); /* _MODULE_POWER_MODE */
|
|
|
|
return len;
|
|
}
|
|
|
|
static int module_fill_reply(struct sk_buff *skb,
|
|
const struct ethnl_req_info *req_base,
|
|
const struct ethnl_reply_data *reply_base)
|
|
{
|
|
const struct module_reply_data *data = MODULE_REPDATA(reply_base);
|
|
|
|
if (data->power.policy &&
|
|
nla_put_u8(skb, ETHTOOL_A_MODULE_POWER_MODE_POLICY,
|
|
data->power.policy))
|
|
return -EMSGSIZE;
|
|
|
|
if (data->power.mode &&
|
|
nla_put_u8(skb, ETHTOOL_A_MODULE_POWER_MODE, data->power.mode))
|
|
return -EMSGSIZE;
|
|
|
|
return 0;
|
|
}
|
|
|
|
/* MODULE_SET */
|
|
|
|
const struct nla_policy ethnl_module_set_policy[ETHTOOL_A_MODULE_POWER_MODE_POLICY + 1] = {
|
|
[ETHTOOL_A_MODULE_HEADER] = NLA_POLICY_NESTED(ethnl_header_policy),
|
|
[ETHTOOL_A_MODULE_POWER_MODE_POLICY] =
|
|
NLA_POLICY_RANGE(NLA_U8, ETHTOOL_MODULE_POWER_MODE_POLICY_HIGH,
|
|
ETHTOOL_MODULE_POWER_MODE_POLICY_AUTO),
|
|
};
|
|
|
|
static int
|
|
ethnl_set_module_validate(struct ethnl_req_info *req_info,
|
|
struct genl_info *info)
|
|
{
|
|
const struct ethtool_ops *ops = req_info->dev->ethtool_ops;
|
|
struct nlattr **tb = info->attrs;
|
|
|
|
if (!tb[ETHTOOL_A_MODULE_POWER_MODE_POLICY])
|
|
return 0;
|
|
|
|
if (!ops->get_module_power_mode || !ops->set_module_power_mode) {
|
|
NL_SET_ERR_MSG_ATTR(info->extack,
|
|
tb[ETHTOOL_A_MODULE_POWER_MODE_POLICY],
|
|
"Setting power mode policy is not supported by this device");
|
|
return -EOPNOTSUPP;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int
|
|
ethnl_set_module(struct ethnl_req_info *req_info, struct genl_info *info)
|
|
{
|
|
struct ethtool_module_power_mode_params power = {};
|
|
struct ethtool_module_power_mode_params power_new;
|
|
const struct ethtool_ops *ops;
|
|
struct net_device *dev = req_info->dev;
|
|
struct nlattr **tb = info->attrs;
|
|
int ret;
|
|
|
|
ops = dev->ethtool_ops;
|
|
|
|
power_new.policy = nla_get_u8(tb[ETHTOOL_A_MODULE_POWER_MODE_POLICY]);
|
|
ret = ops->get_module_power_mode(dev, &power, info->extack);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
if (power_new.policy == power.policy)
|
|
return 0;
|
|
|
|
ret = ops->set_module_power_mode(dev, &power_new, info->extack);
|
|
return ret < 0 ? ret : 1;
|
|
}
|
|
|
|
const struct ethnl_request_ops ethnl_module_request_ops = {
|
|
.request_cmd = ETHTOOL_MSG_MODULE_GET,
|
|
.reply_cmd = ETHTOOL_MSG_MODULE_GET_REPLY,
|
|
.hdr_attr = ETHTOOL_A_MODULE_HEADER,
|
|
.req_info_size = sizeof(struct module_req_info),
|
|
.reply_data_size = sizeof(struct module_reply_data),
|
|
|
|
.prepare_data = module_prepare_data,
|
|
.reply_size = module_reply_size,
|
|
.fill_reply = module_fill_reply,
|
|
|
|
.set_validate = ethnl_set_module_validate,
|
|
.set = ethnl_set_module,
|
|
.set_ntf_cmd = ETHTOOL_MSG_MODULE_NTF,
|
|
};
|