mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-11-01 00:48:50 +00:00
547840bd5a
The test-klp-callbacks script includes a few tests which rely on kernel task timings that may not always execute as expected under system load. These may generate out of sequence kernel log messages that result in test failure. Instead of using sleep timing windows to orchestrate these tests, add a block_transition module parameter to communicate the test purpose and utilize flush_queue() to serialize the test module's task output. Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com> Reviewed-by: Petr Mladek <pmladek@suse.com> Acked-by: Miroslav Benes <mbenes@suse.cz> Signed-off-by: Petr Mladek <pmladek@suse.com> Link: https://lore.kernel.org/r/20200603182058.109470-2-ycote@redhat.com
62 lines
1.5 KiB
C
62 lines
1.5 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
// Copyright (C) 2018 Joe Lawrence <joe.lawrence@redhat.com>
|
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/workqueue.h>
|
|
#include <linux/delay.h>
|
|
|
|
/* load/run-time control from sysfs writer */
|
|
static bool block_transition;
|
|
module_param(block_transition, bool, 0644);
|
|
MODULE_PARM_DESC(block_transition, "block_transition (default=false)");
|
|
|
|
static void busymod_work_func(struct work_struct *work);
|
|
static DECLARE_WORK(work, busymod_work_func);
|
|
|
|
static void busymod_work_func(struct work_struct *work)
|
|
{
|
|
pr_info("%s enter\n", __func__);
|
|
|
|
while (READ_ONCE(block_transition)) {
|
|
/*
|
|
* Busy-wait until the sysfs writer has acknowledged a
|
|
* blocked transition and clears the flag.
|
|
*/
|
|
msleep(20);
|
|
}
|
|
|
|
pr_info("%s exit\n", __func__);
|
|
}
|
|
|
|
static int test_klp_callbacks_busy_init(void)
|
|
{
|
|
pr_info("%s\n", __func__);
|
|
schedule_work(&work);
|
|
|
|
if (!block_transition) {
|
|
/*
|
|
* Serialize output: print all messages from the work
|
|
* function before returning from init().
|
|
*/
|
|
flush_work(&work);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void test_klp_callbacks_busy_exit(void)
|
|
{
|
|
WRITE_ONCE(block_transition, false);
|
|
flush_work(&work);
|
|
pr_info("%s\n", __func__);
|
|
}
|
|
|
|
module_init(test_klp_callbacks_busy_init);
|
|
module_exit(test_klp_callbacks_busy_exit);
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_AUTHOR("Joe Lawrence <joe.lawrence@redhat.com>");
|
|
MODULE_DESCRIPTION("Livepatch test: busy target module");
|