Dmitry Baryshkov 3ec80d52b9 PM: core: keep irq flags in device_pm_check_callbacks() ... [ Upstream commit 524bb1da78 ] The function device_pm_check_callbacks() can be called under the spin lock (in the reported case it happens from genpd_add_device() -> dev_pm_domain_set(), when the genpd uses spinlocks rather than mutexes. However this function uncoditionally uses spin_lock_irq() / spin_unlock_irq(), thus not preserving the CPU flags. Use the irqsave/irqrestore instead. The backtrace for the reference: [ 2.752010] ------------[ cut here ]------------ [ 2.756769] raw_local_irq_restore() called with IRQs enabled [ 2.762596] WARNING: CPU: 4 PID: 1 at kernel/locking/irqflag-debug.c:10 warn_bogus_irq_restore+0x34/0x50 [ 2.772338] Modules linked in: [ 2.775487] CPU: 4 PID: 1 Comm: swapper/0 Tainted: G S 5.17.0-rc6-00384-ge330d0d82eff-dirty #684 [ 2.781384] Freeing initrd memory: 46024K [ 2.785839] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 2.785841] pc : warn_bogus_irq_restore+0x34/0x50 [ 2.785844] lr : warn_bogus_irq_restore+0x34/0x50 [ 2.785846] sp : ffff80000805b7d0 [ 2.785847] x29: ffff80000805b7d0 x28: 0000000000000000 x27: 0000000000000002 [ 2.785850] x26: ffffd40e80930b18 x25: ffff7ee2329192b8 x24: ffff7edfc9f60800 [ 2.785853] x23: ffffd40e80930b18 x22: ffffd40e80930d30 x21: ffff7edfc0dffa00 [ 2.785856] x20: ffff7edfc09e3768 x19: 0000000000000000 x18: ffffffffffffffff [ 2.845775] x17: 6572206f74206465 x16: 6c696166203a3030 x15: ffff80008805b4f7 [ 2.853108] x14: 0000000000000000 x13: ffffd40e809550b0 x12: 00000000000003d8 [ 2.860441] x11: 0000000000000148 x10: ffffd40e809550b0 x9 : ffffd40e809550b0 [ 2.867774] x8 : 00000000ffffefff x7 : ffffd40e809ad0b0 x6 : ffffd40e809ad0b0 [ 2.875107] x5 : 000000000000bff4 x4 : 0000000000000000 x3 : 0000000000000000 [ 2.882440] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff7edfc03a8000 [ 2.889774] Call trace: [ 2.892290] warn_bogus_irq_restore+0x34/0x50 [ 2.896770] _raw_spin_unlock_irqrestore+0x94/0xa0 [ 2.901690] genpd_unlock_spin+0x20/0x30 [ 2.905724] genpd_add_device+0x100/0x2d0 [ 2.909850] __genpd_dev_pm_attach+0xa8/0x23c [ 2.914329] genpd_dev_pm_attach_by_id+0xc4/0x190 [ 2.919167] genpd_dev_pm_attach_by_name+0x3c/0xd0 [ 2.924086] dev_pm_domain_attach_by_name+0x24/0x30 [ 2.929102] psci_dt_attach_cpu+0x24/0x90 [ 2.933230] psci_cpuidle_probe+0x2d4/0x46c [ 2.937534] platform_probe+0x68/0xe0 [ 2.941304] really_probe.part.0+0x9c/0x2fc [ 2.945605] __driver_probe_device+0x98/0x144 [ 2.950085] driver_probe_device+0x44/0x15c [ 2.954385] __device_attach_driver+0xb8/0x120 [ 2.958950] bus_for_each_drv+0x78/0xd0 [ 2.962896] __device_attach+0xd8/0x180 [ 2.966843] device_initial_probe+0x14/0x20 [ 2.971144] bus_probe_device+0x9c/0xa4 [ 2.975092] device_add+0x380/0x88c [ 2.978679] platform_device_add+0x114/0x234 [ 2.983067] platform_device_register_full+0x100/0x190 [ 2.988344] psci_idle_init+0x6c/0xb0 [ 2.992113] do_one_initcall+0x74/0x3a0 [ 2.996060] kernel_init_freeable+0x2fc/0x384 [ 3.000543] kernel_init+0x28/0x130 [ 3.004132] ret_from_fork+0x10/0x20 [ 3.007817] irq event stamp: 319826 [ 3.011404] hardirqs last enabled at (319825): [<ffffd40e7eda0268>] __up_console_sem+0x78/0x84 [ 3.020332] hardirqs last disabled at (319826): [<ffffd40e7fd6d9d8>] el1_dbg+0x24/0x8c [ 3.028458] softirqs last enabled at (318312): [<ffffd40e7ec90410>] _stext+0x410/0x588 [ 3.036678] softirqs last disabled at (318299): [<ffffd40e7ed1bf68>] __irq_exit_rcu+0x158/0x174 [ 3.045607] ---[ end trace 0000000000000000 ]--- Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-04-20 09:06:38 +02:00
..
power	PM: core: keep irq flags in device_pm_check_callbacks()	2022-04-20 09:06:38 +02:00
regmap	regmap: Fix possible double-free in regcache_rbtree_exit()	2021-11-02 17:39:23 +01:00
attribute_container.c	attribute_container: Fix typo	2016-08-31 15:13:56 +02:00
base.h
bus.c	sysfs: Disable lockdep for driver bind/unbind files	2019-01-26 09:38:35 +01:00
cacheinfo.c	drivers: base: cacheinfo: fix boot error message when acpi is enabled	2018-01-31 12:55:51 +01:00
class.c
component.c	component: Silence bind error on -EPROBE_DEFER	2020-05-27 16:41:46 +02:00
container.c
core.c	PCI/MSI: Protect msi_desc::masked for multi-MSI	2021-08-26 08:37:24 -04:00
cpu.c	x86/speculation: Add Special Register Buffer Data Sampling (SRBDS) mitigation	2020-06-11 09:22:23 +02:00
dd.c	driver core: Fix probe_count imbalance in really_probe()	2020-10-14 09:48:15 +02:00
devcoredump.c
devres.c
devtmpfs.c
dma-coherent.c	drivers: dma-coherent: Move spinlock in dma_alloc_from_coherent()	2016-09-28 17:53:16 +02:00
dma-contiguous.c
dma-mapping.c	drivers/base dmam_declare_coherent_memory leaks	2016-08-31 15:19:55 +02:00
driver.c
firmware.c
firmware_class.c	firmware: fix usermode helper fallback loading	2017-01-09 08:32:22 +01:00
hypervisor.c
init.c
isa.c	isa: Prevent NULL dereference in isa_bus driver callbacks	2017-12-14 09:28:11 +01:00
Kconfig	sysfs/cpu: Add vulnerability folder	2018-01-17 09:38:57 +01:00
Makefile
map.c
memory.c	mm/memory_hotplug: Do not unlock when fails to take the device_hotplug_lock	2019-11-28 18:29:02 +01:00
module.c
node.c	treewide: replace obsolete _refok by __ref	2016-08-02 17:31:41 -04:00
pinctrl.c	driver: base: pinctrl: return error from pinctrl_bind_pins()	2016-09-13 23:02:59 +02:00
platform-msi.c	platform-msi: Free descriptors in platform_msi_domain_free()	2019-01-09 16:16:43 +01:00
platform.c	drivers: base: Fix NULL pointer exception in __platform_driver_probe() if a driver developer is foolish	2020-06-30 15:38:24 -04:00
property.c	device property: Track owner device of device property	2017-10-18 09:35:39 +02:00
soc.c	base: soc: Export soc_device_register/unregister APIs	2019-10-05 12:30:20 +02:00
syscore.c
topology.c
transport_class.c