mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 17:30:02 +00:00
![Peter Zijlstra](/assets/img/avatar_default.png)
Rework event_create_dir() to use an array of static data instead of function pointers where possible. The problem is that it would call the function pointer on module load before parse_args(), possibly even before jump_labels were initialized. Luckily the generated functions don't use jump_labels but it still seems fragile. It also gets in the way of changing when we make the module map executable. The generated function are basically calling trace_define_field() with a bunch of static arguments. So instead of a function, capture these arguments in a static array, avoiding the function call. Now there are a number of cases where the fields are dynamic (syscall arguments, kprobes and uprobes), in which case a static array does not work, for these we preserve the function call. Luckily all these cases are not related to modules and so we can retain the function call for them. Also fix up all broken tracepoint definitions that now generate a compile error. Tested-by: Alexei Starovoitov <ast@kernel.org> Tested-by: Steven Rostedt (VMware) <rostedt@goodmis.org> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org> Acked-by: Alexei Starovoitov <ast@kernel.org> Cc: Andy Lutomirski <luto@kernel.org> Cc: Borislav Petkov <bp@alien8.de> Cc: Brian Gerst <brgerst@gmail.com> Cc: Denys Vlasenko <dvlasenk@redhat.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: https://lkml.kernel.org/r/20191111132458.342979914@infradead.org Signed-off-by: Ingo Molnar <mingo@kernel.org>
145 lines
3.3 KiB
C
145 lines
3.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#undef TRACE_SYSTEM
|
|
#define TRACE_SYSTEM pblk
|
|
|
|
#if !defined(_TRACE_PBLK_H) || defined(TRACE_HEADER_MULTI_READ)
|
|
#define _TRACE_PBLK_H
|
|
|
|
#include <linux/tracepoint.h>
|
|
|
|
struct ppa_addr;
|
|
|
|
#define show_chunk_flags(state) __print_flags(state, "", \
|
|
{ NVM_CHK_ST_FREE, "FREE", }, \
|
|
{ NVM_CHK_ST_CLOSED, "CLOSED", }, \
|
|
{ NVM_CHK_ST_OPEN, "OPEN", }, \
|
|
{ NVM_CHK_ST_OFFLINE, "OFFLINE", })
|
|
|
|
#define show_line_state(state) __print_symbolic(state, \
|
|
{ PBLK_LINESTATE_NEW, "NEW", }, \
|
|
{ PBLK_LINESTATE_FREE, "FREE", }, \
|
|
{ PBLK_LINESTATE_OPEN, "OPEN", }, \
|
|
{ PBLK_LINESTATE_CLOSED, "CLOSED", }, \
|
|
{ PBLK_LINESTATE_GC, "GC", }, \
|
|
{ PBLK_LINESTATE_BAD, "BAD", }, \
|
|
{ PBLK_LINESTATE_CORRUPT, "CORRUPT" })
|
|
|
|
|
|
#define show_pblk_state(state) __print_symbolic(state, \
|
|
{ PBLK_STATE_RUNNING, "RUNNING", }, \
|
|
{ PBLK_STATE_STOPPING, "STOPPING", }, \
|
|
{ PBLK_STATE_RECOVERING, "RECOVERING", }, \
|
|
{ PBLK_STATE_STOPPED, "STOPPED" })
|
|
|
|
#define show_chunk_erase_state(state) __print_symbolic(state, \
|
|
{ PBLK_CHUNK_RESET_START, "START", }, \
|
|
{ PBLK_CHUNK_RESET_DONE, "OK", }, \
|
|
{ PBLK_CHUNK_RESET_FAILED, "FAILED" })
|
|
|
|
|
|
TRACE_EVENT(pblk_chunk_reset,
|
|
|
|
TP_PROTO(const char *name, struct ppa_addr *ppa, int state),
|
|
|
|
TP_ARGS(name, ppa, state),
|
|
|
|
TP_STRUCT__entry(
|
|
__string(name, name)
|
|
__field(u64, ppa)
|
|
__field(int, state)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__assign_str(name, name);
|
|
__entry->ppa = ppa->ppa;
|
|
__entry->state = state;
|
|
),
|
|
|
|
TP_printk("dev=%s grp=%llu pu=%llu chk=%llu state=%s", __get_str(name),
|
|
(u64)(((struct ppa_addr *)(&__entry->ppa))->m.grp),
|
|
(u64)(((struct ppa_addr *)(&__entry->ppa))->m.pu),
|
|
(u64)(((struct ppa_addr *)(&__entry->ppa))->m.chk),
|
|
show_chunk_erase_state((int)__entry->state))
|
|
|
|
);
|
|
|
|
TRACE_EVENT(pblk_chunk_state,
|
|
|
|
TP_PROTO(const char *name, struct ppa_addr *ppa, int state),
|
|
|
|
TP_ARGS(name, ppa, state),
|
|
|
|
TP_STRUCT__entry(
|
|
__string(name, name)
|
|
__field(u64, ppa)
|
|
__field(int, state)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__assign_str(name, name);
|
|
__entry->ppa = ppa->ppa;
|
|
__entry->state = state;
|
|
),
|
|
|
|
TP_printk("dev=%s grp=%llu pu=%llu chk=%llu state=%s", __get_str(name),
|
|
(u64)(((struct ppa_addr *)(&__entry->ppa))->m.grp),
|
|
(u64)(((struct ppa_addr *)(&__entry->ppa))->m.pu),
|
|
(u64)(((struct ppa_addr *)(&__entry->ppa))->m.chk),
|
|
show_chunk_flags((int)__entry->state))
|
|
|
|
);
|
|
|
|
TRACE_EVENT(pblk_line_state,
|
|
|
|
TP_PROTO(const char *name, int line, int state),
|
|
|
|
TP_ARGS(name, line, state),
|
|
|
|
TP_STRUCT__entry(
|
|
__string(name, name)
|
|
__field(int, line)
|
|
__field(int, state)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__assign_str(name, name);
|
|
__entry->line = line;
|
|
__entry->state = state;
|
|
),
|
|
|
|
TP_printk("dev=%s line=%d state=%s", __get_str(name),
|
|
(int)__entry->line,
|
|
show_line_state((int)__entry->state))
|
|
|
|
);
|
|
|
|
TRACE_EVENT(pblk_state,
|
|
|
|
TP_PROTO(const char *name, int state),
|
|
|
|
TP_ARGS(name, state),
|
|
|
|
TP_STRUCT__entry(
|
|
__string(name, name)
|
|
__field(int, state)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__assign_str(name, name);
|
|
__entry->state = state;
|
|
),
|
|
|
|
TP_printk("dev=%s state=%s", __get_str(name),
|
|
show_pblk_state((int)__entry->state))
|
|
|
|
);
|
|
|
|
#endif /* !defined(_TRACE_PBLK_H) || defined(TRACE_HEADER_MULTI_READ) */
|
|
|
|
/* This part must be outside protection */
|
|
|
|
#undef TRACE_INCLUDE_PATH
|
|
#define TRACE_INCLUDE_PATH ../../drivers/lightnvm
|
|
#undef TRACE_INCLUDE_FILE
|
|
#define TRACE_INCLUDE_FILE pblk-trace
|
|
#include <trace/define_trace.h>
|