mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-11-01 08:58:07 +00:00
72a9b18629
Ever since commit254d1a3f02("xen/pv-on-hvm kexec: shutdown watches from old kernel") using the INTx interrupt from Xen PCI platform device for event channel notification would just lockup the guest during bootup. postcore_initcall now calls xs_reset_watches which will eventually try to read a value from XenStore and will get stuck on read_reply at XenBus forever since the platform driver is not probed yet and its INTx interrupt handler is not registered yet. That means that the guest can not be notified at this moment of any pending event channels and none of the per-event handlers will ever be invoked (including the XenStore one) and the reply will never be picked up by the kernel. The exact stack where things get stuck during xenbus_init: -xenbus_init -xs_init -xs_reset_watches -xenbus_scanf -xenbus_read -xs_single -xs_single -xs_talkv Vector callbacks have always been the favourite event notification mechanism since their introduction in commit38e20b07ef("x86/xen: event channels delivery on HVM.") and the vector callback feature has always been advertised for quite some time by Xen that's why INTx was broken for several years now without impacting anyone. Luckily this also means that event channel notification through INTx is basically dead-code which can be safely removed without impacting anybody since it has been effectively disabled for more than 4 years with nobody complaining about it (at least as far as I'm aware of). This commit removes event channel notification through Xen PCI platform device. Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> Cc: David Vrabel <david.vrabel@citrix.com> Cc: Juergen Gross <jgross@suse.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: x86@kernel.org Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com> Cc: Julien Grall <julien.grall@citrix.com> Cc: Vitaly Kuznetsov <vkuznets@redhat.com> Cc: Paul Gortmaker <paul.gortmaker@windriver.com> Cc: Ross Lagerwall <ross.lagerwall@citrix.com> Cc: xen-devel@lists.xenproject.org Cc: linux-kernel@vger.kernel.org Cc: linux-pci@vger.kernel.org Cc: Anthony Liguori <aliguori@amazon.com> Signed-off-by: KarimAllah Ahmed <karahmed@amazon.de> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
132 lines
3.2 KiB
C
132 lines
3.2 KiB
C
/******************************************************************************
|
|
* platform-pci.c
|
|
*
|
|
* Xen platform PCI device driver
|
|
*
|
|
* Authors: ssmith@xensource.com and stefano.stabellini@eu.citrix.com
|
|
*
|
|
* Copyright (c) 2005, Intel Corporation.
|
|
* Copyright (c) 2007, XenSource Inc.
|
|
* Copyright (c) 2010, Citrix
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms and conditions of the GNU General Public License,
|
|
* version 2, as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
* more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along with
|
|
* this program; if not, write to the Free Software Foundation, Inc., 59 Temple
|
|
* Place - Suite 330, Boston, MA 02111-1307 USA.
|
|
*
|
|
*/
|
|
|
|
|
|
#include <linux/interrupt.h>
|
|
#include <linux/io.h>
|
|
#include <linux/init.h>
|
|
#include <linux/pci.h>
|
|
|
|
#include <xen/platform_pci.h>
|
|
#include <xen/grant_table.h>
|
|
#include <xen/xenbus.h>
|
|
#include <xen/events.h>
|
|
#include <xen/hvm.h>
|
|
#include <xen/xen-ops.h>
|
|
|
|
#define DRV_NAME "xen-platform-pci"
|
|
|
|
static unsigned long platform_mmio;
|
|
static unsigned long platform_mmio_alloc;
|
|
static unsigned long platform_mmiolen;
|
|
|
|
static unsigned long alloc_xen_mmio(unsigned long len)
|
|
{
|
|
unsigned long addr;
|
|
|
|
addr = platform_mmio + platform_mmio_alloc;
|
|
platform_mmio_alloc += len;
|
|
BUG_ON(platform_mmio_alloc > platform_mmiolen);
|
|
|
|
return addr;
|
|
}
|
|
|
|
static int platform_pci_probe(struct pci_dev *pdev,
|
|
const struct pci_device_id *ent)
|
|
{
|
|
int i, ret;
|
|
long ioaddr;
|
|
long mmio_addr, mmio_len;
|
|
unsigned int max_nr_gframes;
|
|
unsigned long grant_frames;
|
|
|
|
if (!xen_domain())
|
|
return -ENODEV;
|
|
|
|
i = pci_enable_device(pdev);
|
|
if (i)
|
|
return i;
|
|
|
|
ioaddr = pci_resource_start(pdev, 0);
|
|
|
|
mmio_addr = pci_resource_start(pdev, 1);
|
|
mmio_len = pci_resource_len(pdev, 1);
|
|
|
|
if (mmio_addr == 0 || ioaddr == 0) {
|
|
dev_err(&pdev->dev, "no resources found\n");
|
|
ret = -ENOENT;
|
|
goto pci_out;
|
|
}
|
|
|
|
ret = pci_request_region(pdev, 1, DRV_NAME);
|
|
if (ret < 0)
|
|
goto pci_out;
|
|
|
|
ret = pci_request_region(pdev, 0, DRV_NAME);
|
|
if (ret < 0)
|
|
goto mem_out;
|
|
|
|
platform_mmio = mmio_addr;
|
|
platform_mmiolen = mmio_len;
|
|
|
|
max_nr_gframes = gnttab_max_grant_frames();
|
|
grant_frames = alloc_xen_mmio(PAGE_SIZE * max_nr_gframes);
|
|
ret = gnttab_setup_auto_xlat_frames(grant_frames);
|
|
if (ret)
|
|
goto out;
|
|
ret = gnttab_init();
|
|
if (ret)
|
|
goto grant_out;
|
|
xenbus_probe(NULL);
|
|
return 0;
|
|
grant_out:
|
|
gnttab_free_auto_xlat_frames();
|
|
out:
|
|
pci_release_region(pdev, 0);
|
|
mem_out:
|
|
pci_release_region(pdev, 1);
|
|
pci_out:
|
|
pci_disable_device(pdev);
|
|
return ret;
|
|
}
|
|
|
|
static struct pci_device_id platform_pci_tbl[] = {
|
|
{PCI_VENDOR_ID_XEN, PCI_DEVICE_ID_XEN_PLATFORM,
|
|
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
|
|
{0,}
|
|
};
|
|
|
|
static struct pci_driver platform_driver = {
|
|
.name = DRV_NAME,
|
|
.probe = platform_pci_probe,
|
|
.id_table = platform_pci_tbl,
|
|
};
|
|
|
|
static int __init platform_pci_init(void)
|
|
{
|
|
return pci_register_driver(&platform_driver);
|
|
}
|
|
device_initcall(platform_pci_init);
|