mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 02:39:48 +00:00
![Hans de Goede](/assets/img/avatar_default.png)
The Acer Aspire Switch 10E (SW3-016)'s keyboard-dock uses the same USB-ids as the Acer One S1003 keyboard-dock. Yet they are not entirely the same: 1. The S1003 keyboard-dock has the same report descriptors as the S1002 keyboard-dock (which has different USB-ids) 2. The Acer Aspire Switch 10E's keyboard-dock has different report descriptors from the S1002/S1003 keyboard docks and it sends 0x00880078 / 0x00880079 usage events when the touchpad is toggled on/off (which is handled internally). This means that all Acer kbd-docks handled by the hid-ite.c drivers report their touchpad being toggled on/off through these custom usage-codes with the exception of the S1003 dock, which likely is a bug of that dock. Add a QUIRK_TOUCHPAD_ON_OFF_REPORT quirk for the Aspire Switch 10E / S1003 usb-id so that the touchpad toggling will get reported to userspace on the Aspire Switch 10E. Since the Aspire Switch 10E's kbd-dock has different report-descriptors, this also requires adding support for fixing those to ite_report_fixup(). Setting the quirk will also cause ite_report_fixup() to hit the S1002/S1003 descriptors path on the S1003. Since the S1003 kbd-dock never generates any input-reports for the fixed up part of the descriptors this does not matter; and if there are versions out there which do actually send input-reports for the touchpad-toggle then the fixup should actually help to make things work. This was tested on both an Acer Aspire Switch 10E and on an Acer One S1003. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
138 lines
4 KiB
C
138 lines
4 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* HID driver for some ITE "special" devices
|
|
* Copyright (c) 2017 Hans de Goede <hdegoede@redhat.com>
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/input.h>
|
|
#include <linux/hid.h>
|
|
#include <linux/module.h>
|
|
|
|
#include "hid-ids.h"
|
|
|
|
#define QUIRK_TOUCHPAD_ON_OFF_REPORT BIT(0)
|
|
|
|
static __u8 *ite_report_fixup(struct hid_device *hdev, __u8 *rdesc, unsigned int *rsize)
|
|
{
|
|
unsigned long quirks = (unsigned long)hid_get_drvdata(hdev);
|
|
|
|
if (quirks & QUIRK_TOUCHPAD_ON_OFF_REPORT) {
|
|
/* For Acer Aspire Switch 10 SW5-012 keyboard-dock */
|
|
if (*rsize == 188 && rdesc[162] == 0x81 && rdesc[163] == 0x02) {
|
|
hid_info(hdev, "Fixing up Acer Sw5-012 ITE keyboard report descriptor\n");
|
|
rdesc[163] = HID_MAIN_ITEM_RELATIVE;
|
|
}
|
|
/* For Acer One S1002/S1003 keyboard-dock */
|
|
if (*rsize == 188 && rdesc[185] == 0x81 && rdesc[186] == 0x02) {
|
|
hid_info(hdev, "Fixing up Acer S1002/S1003 ITE keyboard report descriptor\n");
|
|
rdesc[186] = HID_MAIN_ITEM_RELATIVE;
|
|
}
|
|
/* For Acer Aspire Switch 10E (SW3-016) keyboard-dock */
|
|
if (*rsize == 210 && rdesc[184] == 0x81 && rdesc[185] == 0x02) {
|
|
hid_info(hdev, "Fixing up Acer Aspire Switch 10E (SW3-016) ITE keyboard report descriptor\n");
|
|
rdesc[185] = HID_MAIN_ITEM_RELATIVE;
|
|
}
|
|
}
|
|
|
|
return rdesc;
|
|
}
|
|
|
|
static int ite_input_mapping(struct hid_device *hdev,
|
|
struct hid_input *hi, struct hid_field *field,
|
|
struct hid_usage *usage, unsigned long **bit,
|
|
int *max)
|
|
{
|
|
|
|
unsigned long quirks = (unsigned long)hid_get_drvdata(hdev);
|
|
|
|
if ((quirks & QUIRK_TOUCHPAD_ON_OFF_REPORT) &&
|
|
(usage->hid & HID_USAGE_PAGE) == 0x00880000) {
|
|
if (usage->hid == 0x00880078) {
|
|
/* Touchpad on, userspace expects F22 for this */
|
|
hid_map_usage_clear(hi, usage, bit, max, EV_KEY, KEY_F22);
|
|
return 1;
|
|
}
|
|
if (usage->hid == 0x00880079) {
|
|
/* Touchpad off, userspace expects F23 for this */
|
|
hid_map_usage_clear(hi, usage, bit, max, EV_KEY, KEY_F23);
|
|
return 1;
|
|
}
|
|
return -1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int ite_event(struct hid_device *hdev, struct hid_field *field,
|
|
struct hid_usage *usage, __s32 value)
|
|
{
|
|
struct input_dev *input;
|
|
|
|
if (!(hdev->claimed & HID_CLAIMED_INPUT) || !field->hidinput)
|
|
return 0;
|
|
|
|
input = field->hidinput->input;
|
|
|
|
/*
|
|
* The ITE8595 always reports 0 as value for the rfkill button. Luckily
|
|
* it is the only button in its report, and it sends a report on
|
|
* release only, so receiving a report means the button was pressed.
|
|
*/
|
|
if (usage->hid == HID_GD_RFKILL_BTN) {
|
|
input_event(input, EV_KEY, KEY_RFKILL, 1);
|
|
input_sync(input);
|
|
input_event(input, EV_KEY, KEY_RFKILL, 0);
|
|
input_sync(input);
|
|
return 1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int ite_probe(struct hid_device *hdev, const struct hid_device_id *id)
|
|
{
|
|
int ret;
|
|
|
|
hid_set_drvdata(hdev, (void *)id->driver_data);
|
|
|
|
ret = hid_open_report(hdev);
|
|
if (ret)
|
|
return ret;
|
|
|
|
return hid_hw_start(hdev, HID_CONNECT_DEFAULT);
|
|
}
|
|
|
|
static const struct hid_device_id ite_devices[] = {
|
|
{ HID_USB_DEVICE(USB_VENDOR_ID_ITE, USB_DEVICE_ID_ITE8595) },
|
|
{ HID_USB_DEVICE(USB_VENDOR_ID_258A, USB_DEVICE_ID_258A_6A88) },
|
|
/* ITE8595 USB kbd ctlr, with Synaptics touchpad connected to it. */
|
|
{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
|
|
USB_VENDOR_ID_SYNAPTICS,
|
|
USB_DEVICE_ID_SYNAPTICS_ACER_SWITCH5_012),
|
|
.driver_data = QUIRK_TOUCHPAD_ON_OFF_REPORT },
|
|
/* ITE8910 USB kbd ctlr, with Synaptics touchpad connected to it. */
|
|
{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
|
|
USB_VENDOR_ID_SYNAPTICS,
|
|
USB_DEVICE_ID_SYNAPTICS_ACER_ONE_S1002),
|
|
.driver_data = QUIRK_TOUCHPAD_ON_OFF_REPORT },
|
|
/* ITE8910 USB kbd ctlr, with Synaptics touchpad connected to it. */
|
|
{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
|
|
USB_VENDOR_ID_SYNAPTICS,
|
|
USB_DEVICE_ID_SYNAPTICS_ACER_ONE_S1003),
|
|
.driver_data = QUIRK_TOUCHPAD_ON_OFF_REPORT },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(hid, ite_devices);
|
|
|
|
static struct hid_driver ite_driver = {
|
|
.name = "itetech",
|
|
.id_table = ite_devices,
|
|
.probe = ite_probe,
|
|
.report_fixup = ite_report_fixup,
|
|
.input_mapping = ite_input_mapping,
|
|
.event = ite_event,
|
|
};
|
|
module_hid_driver(ite_driver);
|
|
|
|
MODULE_LICENSE("GPL");
|