mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-27 12:57:53 +00:00
06951c2ee7
Currently scratch PTEs are write-enabled and points to a single scratch page. This has the side effect that buggy applications with out-of-bounds memory accesses may not notice the bad access since what's written may be read back. Instead use NULL PTEs as scratch PTEs. These always return 0 when reading, and writing has no effect. As a slight benefit, we can also use huge NULL PTEs. One drawback pointed out is that debugging may be hampered since previously when inspecting the content of the scratch page, it might be possible to detect writes to out-of-bound addresses and possibly also from where the out-of-bounds address originated. However since the scratch page-table structure is kept, it will be easy to add back the single RW-enabled scratch page under a debug define if needed. Also update the kerneldoc accordingly and move the function to create the scratch page-tables from xe_pt.c to xe_pt.h since it is accessing vm structure internals and this also makes it possible to make it static. v2: - Don't try to encode scratch PTEs larger than 1GiB. - Move xe_pt_create_scratch(), Update kerneldoc. v3: - Rebase. Cc: Brian Welty <brian.welty@intel.com> Cc: Matt Roper <matthew.d.roper@intel.com> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> Acked-by: Lucas De Marchi <lucas.demarchi@intel.com> #for general direction. Reviewed-by: Brian Welty <brian.welty@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20231209151843.7903-3-thomas.hellstrom@linux.intel.com Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
48 lines
1.2 KiB
C
48 lines
1.2 KiB
C
/* SPDX-License-Identifier: MIT */
|
|
/*
|
|
* Copyright © 2022 Intel Corporation
|
|
*/
|
|
#ifndef _XE_PT_H_
|
|
#define _XE_PT_H_
|
|
|
|
#include <linux/types.h>
|
|
|
|
#include "xe_pt_types.h"
|
|
|
|
struct dma_fence;
|
|
struct xe_bo;
|
|
struct xe_device;
|
|
struct xe_exec_queue;
|
|
struct xe_sync_entry;
|
|
struct xe_tile;
|
|
struct xe_vm;
|
|
struct xe_vma;
|
|
|
|
/* Largest huge pte is currently 1GiB. May become device dependent. */
|
|
#define MAX_HUGEPTE_LEVEL 2
|
|
|
|
#define xe_pt_write(xe, map, idx, data) \
|
|
xe_map_wr(xe, map, (idx) * sizeof(u64), u64, data)
|
|
|
|
unsigned int xe_pt_shift(unsigned int level);
|
|
|
|
struct xe_pt *xe_pt_create(struct xe_vm *vm, struct xe_tile *tile,
|
|
unsigned int level);
|
|
|
|
void xe_pt_populate_empty(struct xe_tile *tile, struct xe_vm *vm,
|
|
struct xe_pt *pt);
|
|
|
|
void xe_pt_destroy(struct xe_pt *pt, u32 flags, struct llist_head *deferred);
|
|
|
|
struct dma_fence *
|
|
__xe_pt_bind_vma(struct xe_tile *tile, struct xe_vma *vma, struct xe_exec_queue *q,
|
|
struct xe_sync_entry *syncs, u32 num_syncs,
|
|
bool rebind);
|
|
|
|
struct dma_fence *
|
|
__xe_pt_unbind_vma(struct xe_tile *tile, struct xe_vma *vma, struct xe_exec_queue *q,
|
|
struct xe_sync_entry *syncs, u32 num_syncs);
|
|
|
|
bool xe_pt_zap_ptes(struct xe_tile *tile, struct xe_vma *vma);
|
|
|
|
#endif
|