mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-28 07:13:34 +00:00
Code Issues Releases Wiki Activity
linux-stable/drivers/net/ethernet/realtek
History
Sayanta Pattanayak e9a72f874d r8169: Avoid duplicate sysfs entry creation error 
When registering the MDIO bus for a r8169 device, we use the PCI
bus/device specifier as a (seemingly) unique device identifier.
However the very same BDF number can be used on another PCI segment,
which makes the driver fail probing:

[ 27.544136] r8169 0002:07:00.0: enabling device (0000 -> 0003)
[ 27.559734] sysfs: cannot create duplicate filename '/class/mdio_bus/r8169-700'
....
[ 27.684858] libphy: mii_bus r8169-700 failed to register
[ 27.695602] r8169: probe of 0002:07:00.0 failed with error -22

Add the segment number to the device name to make it more unique.

This fixes operation on ARM N1SDP boards, with two boards connected
together to form an SMP system, and all on-board devices showing up
twice, just on different PCI segments. A similar issue would occur on
large systems with many PCI slots and multiple RTL8169 NICs.

Fixes: f1e911d5d0 ("r8169: add basic phylib support")
Signed-off-by: Sayanta Pattanayak <sayanta.pattanayak@arm.com>
[Andre: expand commit message, use pci_domain_nr()]
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2021-07-21 07:54:30 -07:00
..
8139cp.c net: realtek: remove leading spaces before tabs 2021-05-19 12:17:31 -07:00
8139too.c net: realtek: remove leading spaces before tabs 2021-05-19 12:17:31 -07:00
atp.c net: realtek: remove leading spaces before tabs 2021-05-19 12:17:31 -07:00
atp.h
Kconfig treewide: replace '---help---' in Kconfig files with 'help' 2020-06-14 01:57:21 +09:00
Makefile r8169: factor out PHY configuration to r8169_phy_config.c 2020-01-10 16:41:35 -08:00
r8169.h r8169: Add support for another RTL8168FP 2021-02-02 18:02:55 -08:00
r8169_firmware.c treewide: Use sizeof_field() macro 2019-12-09 10:36:44 -08:00
r8169_firmware.h
r8169_main.c r8169: Avoid duplicate sysfs entry creation error 2021-07-21 07:54:30 -07:00
r8169_phy_config.c r8169: Add support for another RTL8168FP 2021-02-02 18:02:55 -08:00