Mrinal Pandey b7d6cfba23 checkpatch: fix the usage of capture group ( ... ) ... commit 13e45417ce upstream. The usage of "capture group (...)" in the immediate condition after `&&` results in `$1` being uninitialized. This issues a warning "Use of uninitialized value $1 in regexp compilation at ./scripts/checkpatch.pl line 2638". I noticed this bug while running checkpatch on the set of commits from v5.7 to v5.8-rc1 of the kernel on the commits with a diff content in their commit message. This bug was introduced in the script by commit e518e9a59e ("checkpatch: emit an error when there's a diff in a changelog"). It has been in the script since then. The author intended to store the match made by capture group in variable `$1`. This should have contained the name of the file as `[\w/]+` matched. However, this couldn't be accomplished due to usage of capture group and `$1` in the same regular expression. Fix this by placing the capture group in the condition before `&&`. Thus, `$1` can be initialized to the text that capture group matches thereby setting it to the desired and required value. Fixes: e518e9a59e ("checkpatch: emit an error when there's a diff in a changelog") Signed-off-by: Mrinal Pandey <mrinalmni@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Tested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> Reviewed-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> Cc: Joe Perches <joe@perches.com> Link: https://lkml.kernel.org/r/20200714032352.f476hanaj2dlmiot@mrinalpandey Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-09-09 19:03:13 +02:00
..
basic	fixdep: trivial: typo fix and correction	2017-08-10 01:01:03 +09:00
coccinelle	fs: stream_open - opener for stream-like files so that read and write can run simultaneously without deadlock	2019-06-11 12:21:51 +02:00
dtc	scripts/dtc: Remove redundant YYLOC global declaration	2020-04-02 16:34:30 +02:00
gcc-plugins	gcc-common.h: Update for GCC 10	2020-05-27 16:42:53 +02:00
gdb	scripts/gdb: fix debugging modules compiled with hot/cold partitioning	2019-12-05 15:37:04 +01:00
genksyms	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
kconfig	kconfig: fix broken dependency in randconfig-generated .config	2020-02-28 16:35:59 +01:00
ksymoops	Fix dead URLs to ftp.kernel.org	2017-03-28 16:16:52 +02:00
mod	modpost: skip ELF local symbols during section mismatch check	2019-12-17 20:38:30 +01:00
package	builddeb: Fix header package regarding dtc source links	2018-05-30 07:52:21 +02:00
selinux	selinux: use kernel linux/socket.h for genheaders and mdp	2019-05-04 09:15:17 +02:00
tracing	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
.gitignore	Docs: clean up some DocBook loose ends	2017-06-23 14:17:38 -06:00
adjust_autoksyms.sh	kbuild: make scripts/adjust_autoksyms.sh robust against timestamp races	2018-05-30 07:52:17 +02:00
asn1_compiler.c	ASN.1: fix open failure check on headername	2016-04-06 14:06:48 +01:00
bloat-o-meter	scripts/bloat-o-meter: compile .NUMBER regex	2016-12-12 18:55:06 -08:00
bootgraph.pl	scripts: Switch to more portable Perl shebang	2017-05-14 11:20:44 +09:00
check_00index.sh	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
check_extable.sh	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
checkincludes.pl	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
checkkconfigsymbols.py	checkkconfigsymbols.py: support Kconfig's 'imply' statement	2017-02-03 11:49:06 +01:00
checkpatch.pl	checkpatch: fix the usage of capture group ( ... )	2020-09-09 19:03:13 +02:00
checkstack.pl	scripts/checkstack.pl: Fix arm64 wrong or unknown architecture	2019-06-25 11:36:53 +08:00
checksyscalls.sh	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
checkversion.pl	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
cleanfile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
cleanpatch	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
coccicheck	coccinelle: fix parallel build with CHECK=scripts/coccicheck	2017-12-14 09:53:06 +01:00
config	scripts/config: allow colons in option strings for sed	2020-05-10 10:29:01 +02:00
conmakehash.c
const_structs.checkpatch	const_structs.checkpatch: add frequently used from Julia Lawall's list	2016-10-11 15:06:30 -07:00
decode_stacktrace.sh	scripts/decode_stacktrace: strip basepath from all paths	2020-07-29 07:42:54 +02:00
decodecode	scripts/decodecode: fix trapping instruction formatting	2020-05-20 08:17:01 +02:00
depmod.sh	kbuild: make missing $DEPMOD a Warning instead of an Error	2018-09-15 09:45:36 +02:00
diffconfig	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
export_report.pl	scripts: Switch to more portable Perl shebang	2017-05-14 11:20:44 +09:00
extract-cert.c
extract-ikconfig
extract-module-sig.pl	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
extract-sys-certs.pl	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
extract-vmlinux
extract_xc3028.pl	scripts: Switch to more portable Perl shebang	2017-05-14 11:20:44 +09:00
faddr2line	scripts/faddr2line: fix CROSS_COMPILE unset error	2018-02-07 11:12:17 -08:00
gcc-goto.sh	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
gcc-ld	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
gcc-plugin.sh	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
gcc-version.sh	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
gcc-x86_32-has-stack-protector.sh	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
gcc-x86_64-has-stack-protector.sh	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
gen_initramfs_list.sh	Kbuild misc updates for 4.13	2017-07-07 15:09:09 -07:00
get_dvb_firmware	scripts: Switch to more portable Perl shebang	2017-05-14 11:20:44 +09:00
get_maintainer.pl	get_maintainer: Prepare for separate MAINTAINERS files	2017-08-08 11:09:31 -07:00
gfp-translate
headerdep.pl	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
headers.sh	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
headers_check.pl	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
headers_install.sh	linux/compiler.h: Split into compiler.h and compiler_types.h	2017-12-25 14:26:33 +01:00
insert-sys-cert.c	KEYS: Reserve an extra certificate symbol for inserting without recompiling	2016-02-26 15:30:20 +00:00
kallsyms.c	scripts/kallsyms: fix definitely-lost memory leak	2020-01-04 13:59:51 +01:00
Kbuild.include	kbuild: improve cc-option to clean up all temporary files	2020-06-30 15:38:06 -04:00
kernel-doc	scripts/kernel-doc: Don't fail with status != 0 if error encountered with -none	2018-02-25 11:07:58 +01:00
ld-version.sh	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
leaking_addresses.pl	scripts: add leaking_addresses.pl	2017-11-06 11:46:42 -08:00
Lindent	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
link-vmlinux.sh	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Makefile.asm-generic	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Makefile.build	ftrace: Build with CPPFLAGS to get -Qunused-arguments	2019-01-13 10:01:03 +01:00
Makefile.clean	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Makefile.dtbinst	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Makefile.extrawarn	kbuild: Disable -Wpointer-to-enum-cast	2020-04-02 16:34:21 +02:00
Makefile.gcc-plugins	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Makefile.headersinst	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Makefile.help
Makefile.host	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Makefile.kasan	kasan: rework Kconfig settings	2018-02-16 20:23:04 +01:00
Makefile.lib	kbuild: Handle builtin dtb file names containing hyphens	2018-03-15 10:54:33 +01:00
Makefile.modbuiltin	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Makefile.modinst	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Makefile.modpost	kbuild: modpost: handle KBUILD_EXTRA_SYMBOLS only for external modules	2019-08-25 10:50:14 +02:00
Makefile.modsign	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Makefile.ubsan	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
makelst	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
markup_oops.pl	scripts: Switch to more portable Perl shebang	2017-05-14 11:20:44 +09:00
mkcompile_h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mkmakefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mksysmap	mksysmap: Fix the mismatch of '.L' symbols in System.map	2020-06-25 15:41:50 +02:00
mkuboot.sh	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
module-common.lds	module: set .init_array alignment to 8	2017-03-13 09:40:28 -07:00
namespace.pl	namespace: fix namespace.pl script to support relative paths	2019-10-29 09:16:59 +01:00
objdiff	scripts: objdiff: Ignore debug info when comparing	2017-03-11 11:13:38 +09:00
parse-maintainers.pl	parse-maintainers: Mark as executable	2020-04-02 16:34:15 +02:00
patch-kernel	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
pnmtologo.c
profile2linkerlist.pl	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
prune-kernel	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
recordmcount.c	ARM: 8950/1: ftrace/recordmcount: filter relocation types	2020-01-29 15:02:37 +01:00
recordmcount.h	recordmcount: Fix spurious mcount entries on powerpc	2019-07-31 07:28:53 +02:00
recordmcount.pl	scripts: Switch to more portable Perl shebang	2017-05-14 11:20:44 +09:00
setlocalversion	scripts/setlocalversion: Improve -dirty check with git-status --no-optional-locks	2019-11-06 12:42:55 +01:00
show_delta
sign-file.c	sign-file: fix build error in sign-file.c with libressl	2017-02-10 12:43:47 +11:00
sortextable.c	powerpc: Build-time sort the exception table	2016-11-14 11:11:51 +11:00
sortextable.h
spelling.txt	scripts/spelling.txt: add more spelling mistakes to spelling.txt	2017-10-03 17:54:23 -07:00
sphinx-pre-install	scripts/sphinx-pre-install: fix script for RHEL/CentOS	2019-08-16 10:13:51 +02:00
stackdelta	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
stackusage	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
tags.sh	tags: honor COMPILED_SOURCE with apart output directory	2017-06-06 08:42:34 +09:00
unifdef.c	unifdef: use memcpy instead of strncpy	2018-12-08 13:03:35 +01:00
ver_linux	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xen-hypercalls.sh	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xz_wrap.sh