mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-28 20:02:17 +00:00
![Dave Chinner](/assets/img/avatar_default.png)
Running a CONFIG_XFS_DEBUG kernel in production environments is not the best idea as it introduces significant overhead, can change the behaviour of algorithms (such as allocation) to improve test coverage, and (most importantly) panic the machine on non-fatal errors. There are many cases where all we want to do is run a kernel with more bounds checking enabled, such as is provided by the ASSERT() statements throughout the code, but without all the potential overhead and drawbacks. This patch converts all the ASSERT statements to evaluate as WARN_ON(1) statements and hence if they fail dump a warning and a stack trace to the log. This has minimal overhead and does not change any algorithms, and will allow us to find strange "out of bounds" problems more easily on production machines. There are a few places where assert statements contain debug only code. These are converted to be debug-or-warn only code so that we still get all the assert checks in the code. Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Brian Foster <bfoster@redhat.com> Signed-off-by: Ben Myers <bpm@sgi.com>
64 lines
2.3 KiB
C
64 lines
2.3 KiB
C
#ifndef __XFS_MESSAGE_H
|
|
#define __XFS_MESSAGE_H 1
|
|
|
|
struct xfs_mount;
|
|
|
|
extern __printf(2, 3)
|
|
void xfs_emerg(const struct xfs_mount *mp, const char *fmt, ...);
|
|
extern __printf(2, 3)
|
|
void xfs_alert(const struct xfs_mount *mp, const char *fmt, ...);
|
|
extern __printf(3, 4)
|
|
void xfs_alert_tag(const struct xfs_mount *mp, int tag, const char *fmt, ...);
|
|
extern __printf(2, 3)
|
|
void xfs_crit(const struct xfs_mount *mp, const char *fmt, ...);
|
|
extern __printf(2, 3)
|
|
void xfs_err(const struct xfs_mount *mp, const char *fmt, ...);
|
|
extern __printf(2, 3)
|
|
void xfs_warn(const struct xfs_mount *mp, const char *fmt, ...);
|
|
extern __printf(2, 3)
|
|
void xfs_notice(const struct xfs_mount *mp, const char *fmt, ...);
|
|
extern __printf(2, 3)
|
|
void xfs_info(const struct xfs_mount *mp, const char *fmt, ...);
|
|
|
|
#ifdef DEBUG
|
|
extern __printf(2, 3)
|
|
void xfs_debug(const struct xfs_mount *mp, const char *fmt, ...);
|
|
#else
|
|
static inline __printf(2, 3)
|
|
void xfs_debug(const struct xfs_mount *mp, const char *fmt, ...)
|
|
{
|
|
}
|
|
#endif
|
|
|
|
#define xfs_printk_ratelimited(func, dev, fmt, ...) \
|
|
do { \
|
|
static DEFINE_RATELIMIT_STATE(_rs, \
|
|
DEFAULT_RATELIMIT_INTERVAL, \
|
|
DEFAULT_RATELIMIT_BURST); \
|
|
if (__ratelimit(&_rs)) \
|
|
func(dev, fmt, ##__VA_ARGS__); \
|
|
} while (0)
|
|
|
|
#define xfs_emerg_ratelimited(dev, fmt, ...) \
|
|
xfs_printk_ratelimited(xfs_emerg, dev, fmt, ##__VA_ARGS__)
|
|
#define xfs_alert_ratelimited(dev, fmt, ...) \
|
|
xfs_printk_ratelimited(xfs_alert, dev, fmt, ##__VA_ARGS__)
|
|
#define xfs_crit_ratelimited(dev, fmt, ...) \
|
|
xfs_printk_ratelimited(xfs_crit, dev, fmt, ##__VA_ARGS__)
|
|
#define xfs_err_ratelimited(dev, fmt, ...) \
|
|
xfs_printk_ratelimited(xfs_err, dev, fmt, ##__VA_ARGS__)
|
|
#define xfs_warn_ratelimited(dev, fmt, ...) \
|
|
xfs_printk_ratelimited(xfs_warn, dev, fmt, ##__VA_ARGS__)
|
|
#define xfs_notice_ratelimited(dev, fmt, ...) \
|
|
xfs_printk_ratelimited(xfs_notice, dev, fmt, ##__VA_ARGS__)
|
|
#define xfs_info_ratelimited(dev, fmt, ...) \
|
|
xfs_printk_ratelimited(xfs_info, dev, fmt, ##__VA_ARGS__)
|
|
#define xfs_debug_ratelimited(dev, fmt, ...) \
|
|
xfs_printk_ratelimited(xfs_debug, dev, fmt, ##__VA_ARGS__)
|
|
|
|
extern void assfail(char *expr, char *f, int l);
|
|
extern void asswarn(char *expr, char *f, int l);
|
|
|
|
extern void xfs_hex_dump(void *p, int length);
|
|
|
|
#endif /* __XFS_MESSAGE_H */
|