Steven Rostedt (VMware) 81f9662354 tracing/fgraph: Fix set_graph_function from showing interrupts ... commit 5cf99a0f31 upstream. The tracefs file set_graph_function is used to only function graph functions that are listed in that file (or all functions if the file is empty). The way this is implemented is that the function graph tracer looks at every function, and if the current depth is zero and the function matches something in the file then it will trace that function. When other functions are called, the depth will be greater than zero (because the original function will be at depth zero), and all functions will be traced where the depth is greater than zero. The issue is that when a function is first entered, and the handler that checks this logic is called, the depth is set to zero. If an interrupt comes in and a function in the interrupt handler is traced, its depth will be greater than zero and it will automatically be traced, even if the original function was not. But because the logic only looks at depth it may trace interrupts when it should not be. The recent design change of the function graph tracer to fix other bugs caused the depth to be zero while the function graph callback handler is being called for a longer time, widening the race of this happening. This bug was actually there for a longer time, but because the race window was so small it seldom happened. The Fixes tag below is for the commit that widen the race window, because that commit belongs to a series that will also help fix the original bug. Cc: stable@kernel.org Fixes: 39eb456dac ("function_graph: Use new curr_ret_depth to manage depth instead of curr_ret_stack") Reported-by: Joe Lawrence <joe.lawrence@redhat.com> Tested-by: Joe Lawrence <joe.lawrence@redhat.com> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-12-08 12:59:07 +01:00
..
bpf	bpf: fix bpf_prog_get_info_by_fd to return 0 func_lens for unpriv	2018-11-27 16:13:03 +01:00
cgroup	cgroup: Fix dom_cgrp propagation when enabling threaded mode	2018-10-04 13:28:08 -07:00
configs	kconfig: tinyconfig: remove stale stack protector fixups	2018-06-15 07:15:28 +09:00
debug	kdb: Use strscpy with destination buffer size	2018-12-01 09:37:33 +01:00
dma	dma-mapping: fix panic caused by passing empty cma command line argument	2018-11-13 11:08:17 -08:00
events	uprobes: Fix handle_swbp() vs. unregister() + register() race once more	2018-12-08 12:59:06 +01:00
gcov	gcov: remove CONFIG_GCOV_FORMAT_AUTODETECT	2018-06-08 18:56:02 +09:00
irq	genirq: Fix race on spurious interrupt detection	2018-11-13 11:08:48 -08:00
livepatch	Merge branch 'for-4.19/upstream' into for-linus	2018-08-20 18:33:50 +02:00
locking	locking/lockdep: Fix debug_locks off performance problem	2018-11-13 11:08:20 -08:00
power	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2018-10-12 12:35:02 +02:00
printk	printk: Fix panic caused by passing log_buf_len to command line	2018-11-13 11:08:48 -08:00
rcu	rcu: Make need_resched() respond to urgent RCU-QS needs	2018-12-01 09:37:34 +01:00
sched	sched/smt: Expose sched_smt_present static key	2018-12-05 19:32:02 +01:00
time	clocksource: Revert "Remove kthread"	2018-09-06 23:38:35 +02:00
trace	tracing/fgraph: Fix set_graph_function from showing interrupts	2018-12-08 12:59:07 +01:00
.gitignore
acct.c
async.c
audit.c	audit: use ktime_get_coarse_real_ts64() for timestamps	2018-07-17 14:45:08 -04:00
audit.h	audit: track the owner of the command mutex ourselves	2018-02-23 11:22:22 -05:00
audit_fsnotify.c	fsnotify: add fsnotify_add_inode_mark() wrappers	2018-05-18 14:58:22 +02:00
audit_tree.c	\n	2018-08-17 09:41:28 -07:00
audit_watch.c	audit: fix use-after-free in audit_add_watch	2018-07-18 11:43:36 -04:00
auditfilter.c	audit: rename FILTER_TYPE to FILTER_EXCLUDE	2018-06-19 10:39:54 -04:00
auditsc.c	audit/stable-4.18 PR 20180814	2018-08-15 10:46:54 -07:00
backtracetest.c
bounds.c	kbuild: fix kernel/bounds.c 'W=1' warning	2018-11-13 11:08:47 -08:00
capability.c
compat.c	time: Enable get/put_compat_itimerspec64 always	2018-06-24 14:39:47 +02:00
configs.c
context_tracking.c
cpu.c	x86/speculation: Rework SMT state change	2018-12-05 19:32:02 +01:00
cpu_pm.c
crash_core.c	kernel/crash_core.c: print timestamp using time64_t	2018-08-22 10:52:47 -07:00
crash_dump.c
cred.c
delayacct.c	delayacct: Use raw_spinlocks	2018-04-27 14:34:51 +02:00
dma.c	proc: introduce proc_create_single{,_data}	2018-05-16 07:23:35 +02:00
elfcore.c
exec_domain.c	proc: introduce proc_create_single{,_data}	2018-05-16 07:23:35 +02:00
exit.c	signal: Pass pid type into group_send_sig_info	2018-07-21 12:57:35 -05:00
extable.c	extable: Make init_kernel_text() global	2018-02-21 16:54:06 +01:00
fail_function.c	bpf/error-inject/kprobes: Clear current_kprobe and enable preempt in kprobe	2018-06-21 12:33:19 +02:00
fork.c	mm: respect arch_dup_mmap() return value	2018-09-04 16:45:02 -07:00
freezer.c	PM / reboot: Eliminate race between reboot and suspend	2018-08-06 12:35:20 +02:00
futex.c	futex: Mark expected switch fall-throughs	2018-08-20 18:23:00 +02:00
futex_compat.c
groups.c
hung_task.c	kernel/hung_task.c: allow to set checking interval separately from timeout	2018-08-22 10:52:47 -07:00
iomem.c	memremap: split devm_memremap_pages() and memremap() infrastructure	2018-05-15 23:08:33 -07:00
irq_work.c
jump_label.c	jump_label: Fix typo in warning message	2018-09-10 10:15:48 +02:00
kallsyms.c	kallsyms, x86: Export addresses of PTI entry trampolines	2018-08-14 19:12:29 -03:00
kcmp.c
Kconfig.freezer
Kconfig.hz
Kconfig.locks
Kconfig.preempt	kconfig: include kernel/Kconfig.preempt from init/Kconfig	2018-08-02 08:06:54 +09:00
kcov.c	sched/core / kcov: avoid kcov_area during task switch	2018-06-15 07:55:24 +09:00
kexec.c	kexec: add call to LSM hook in original kexec_load syscall	2018-07-16 12:31:57 -07:00
kexec_core.c	kexec: yield to scheduler when loading kimage segments	2018-06-15 07:55:24 +09:00
kexec_file.c	treewide: Use array_size() in vzalloc()	2018-06-12 16:19:22 -07:00
kexec_internal.h
kmod.c
kprobes.c	kprobes: Return error if we fail to reuse kprobe instead of BUG_ON()	2018-11-13 11:08:28 -08:00
ksysfs.c
kthread.c	Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-08-13 11:25:07 -07:00
latencytop.c
Makefile	kbuild: move bin2c back to scripts/ from scripts/basic/	2018-07-18 01:18:05 +09:00
memremap.c	libnvdimm-for-4.19_dax-memory-failure	2018-08-25 18:43:59 -07:00
module-internal.h	modsign: log module name in the event of an error	2018-07-02 11:36:17 +02:00
module.c	module: use relative references for __ksymtab entries	2018-08-22 10:52:47 -07:00
module_signing.c	modsign: log module name in the event of an error	2018-07-02 11:36:17 +02:00
notifier.c
nsproxy.c
padata.c
panic.c	Kbuild: rename CC_STACKPROTECTOR[_STRONG] config variables	2018-06-14 12:21:18 +09:00
params.c	kernel/params.c: downgrade warning for unsafe parameters	2018-04-11 10:28:37 -07:00
pid.c	fork: report pid exhaustion correctly	2018-09-20 22:01:11 +02:00
pid_namespace.c	Merge branch 'userns-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2018-04-03 19:15:32 -07:00
profile.c
ptrace.c	ptrace: Remove unused ptrace_may_access_sched() and MODE_IBRS	2018-12-05 19:32:03 +01:00
range.c
reboot.c	PM / reboot: Eliminate race between reboot and suspend	2018-08-06 12:35:20 +02:00
relay.c	kernel/relay.c: change return type to vm_fault_t	2018-06-15 07:55:24 +09:00
resource.c	libnvdimm for 4.18	2018-06-08 17:21:52 -07:00
rseq.c	rseq: uapi: Declare rseq_cs field as union, update includes	2018-07-10 22:18:52 +02:00
seccomp.c	audit/stable-4.18 PR 20180605	2018-06-06 16:34:00 -07:00
signal.c	signal: Guard against negative signal numbers in copy_siginfo_from_user32	2018-11-13 11:08:45 -08:00
smp.c	cpu/hotplug: Fix SMT supported evaluation	2018-08-07 12:25:30 +02:00
smpboot.c	smpboot: Remove cpumask from the API	2018-07-03 09:20:44 +02:00
smpboot.h
softirq.c	nohz: Fix missing tick reprogram when interrupting an inline softirq	2018-08-03 15:52:10 +02:00
stacktrace.c
stop_machine.c	Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-08-13 11:25:07 -07:00
sys.c	kernel/sys.c: remove duplicated include	2018-09-20 22:01:11 +02:00
sys_ni.c	Merge branch 'core-rseq-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-06-10 10:17:09 -07:00
sysctl.c	namei: allow restricted O_CREAT of FIFOs and regular files	2018-08-23 18:48:43 -07:00
sysctl_binary.c	staging: irda: remove remaining remants of irda code removal	2018-04-16 11:26:49 +02:00
task_work.c
taskstats.c
test_kprobes.c	kprobes: Remove jprobe API implementation	2018-06-21 12:33:05 +02:00
torture.c	torture: Keep old-school dmesg format	2018-06-25 11:30:10 -07:00
tracepoint.c	tracepoint: Fix tracepoint array element size mismatch	2018-10-17 15:35:29 -04:00
tsacct.c
ucount.c	headers: untangle kmemleak.h from mm.h	2018-04-05 21:36:27 -07:00
uid16.c	fs: add do_fchownat(), ksys_fchown() helpers and ksys_{,l}chown() wrappers	2018-04-02 20:15:59 +02:00
uid16.h	kernel: provide ksys_*() wrappers for syscalls called by kernel/uid16.c	2018-04-02 20:15:30 +02:00
umh.c	umh: fix race condition	2018-06-07 16:56:28 -04:00
up.c
user-return-notifier.c
user.c	userns: use irqsave variant of refcount_dec_and_lock()	2018-08-22 10:52:47 -07:00
user_namespace.c	userns: also map extents in the reverse map to kernel IDs	2018-11-13 11:09:00 -08:00
utsname.c	uts: create "struct uts_namespace" from kmem_cache	2018-04-11 10:28:35 -07:00
utsname_sysctl.c	sys: don't hold uts_sem while accessing userspace memory	2018-08-11 02:05:53 -05:00
watchdog.c	watchdog: Mark watchdog touch functions as notrace	2018-08-30 12:56:40 +02:00
watchdog_hld.c	watchdog: Mark watchdog touch functions as notrace	2018-08-30 12:56:40 +02:00
workqueue.c	watchdog: Mark watchdog touch functions as notrace	2018-08-30 12:56:40 +02:00
workqueue_internal.h	workqueue: Set worker->desc to workqueue name by default	2018-05-18 08:47:13 -07:00