Alexander Kuznetsov 74d3b20b1b cgroup1: don't allow '\n' in renaming ... commit b7e24eb1ca upstream. cgroup_mkdir() have restriction on newline usage in names: $ mkdir $'/sys/fs/cgroup/cpu/test\ntest2' mkdir: cannot create directory '/sys/fs/cgroup/cpu/test\ntest2': Invalid argument But in cgroup1_rename() such check is missed. This allows us to make /proc/<pid>/cgroup unparsable: $ mkdir /sys/fs/cgroup/cpu/test $ mv /sys/fs/cgroup/cpu/test $'/sys/fs/cgroup/cpu/test\ntest2' $ echo $$ > $'/sys/fs/cgroup/cpu/test\ntest2' $ cat /proc/self/cgroup 11:pids:/ 10:freezer:/ 9:hugetlb:/ 8:cpuset:/ 7:blkio:/user.slice 6:memory:/user.slice 5:net_cls,net_prio:/ 4:perf_event:/ 3:devices:/user.slice 2:cpu,cpuacct:/test test2 1:name=systemd:/ 0::/ Signed-off-by: Alexander Kuznetsov <wwfq@yandex-team.ru> Reported-by: Andrey Krasichkov <buglloc@yandex-team.ru> Acked-by: Dmitry Yakunin <zeil@yandex-team.ru> Cc: stable@vger.kernel.org Signed-off-by: Tejun Heo <tj@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-06-16 12:01:40 +02:00
..
cgroup-internal.h	fs_parse: fold fs_parameter_desc/fs_parameter_spec	2020-02-07 14:48:37 -05:00
cgroup-v1.c	cgroup1: don't allow '\n' in renaming	2021-06-16 12:01:40 +02:00
cgroup.c	cgroup: disable controllers at parse time	2021-06-16 12:01:36 +02:00
cpuset.c	cpuset: fix race between hotplug work and later CPU offline	2020-12-30 11:54:11 +01:00
debug.c	kernel: cgroup: fix misuse of %x	2019-05-06 08:47:48 -07:00
freezer.c	cgroup: freezer: don't change task and cgroups status unnecessarily	2019-11-07 07:38:41 -08:00
legacy_freezer.c	cgroup: rename freezer.c into legacy_freezer.c	2019-04-19 11:26:48 -07:00
Makefile	cgroup: cgroup v2 freezer	2019-04-19 11:26:48 -07:00
namespace.c	nsproxy: add struct nsset	2020-05-09 13:57:12 +02:00
pids.c	clone3: allow spawning processes into cgroups	2020-02-12 17:57:51 -05:00
rdma.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 451	2019-06-19 17:09:08 +02:00
rstat.c	cgroup: unexport cgroup_rstat_updated	2020-06-29 09:09:08 -06:00