mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 13:55:32 +00:00
![Tejun Heo](/assets/img/avatar_default.png)
The intention of using port_mask in SFF init helpers was to eventually support exoctic configurations such as combination of legacy and native port on the same controller. This never became actually necessary and the related code always has been subtly broken one way or the other. Now that new init model is in place, there is no reason to make common helpers capable of handling all corner cases. Exotic cases can simply dealt within LLDs as necessary. This patch removes port_mask handling in SFF init helpers. SFF init helpers don't take n_ports argument and interpret it into port_mask anymore. All information is carried via port_info. n_ports argument is dropped and always two ports are allocated. LLD can tell SFF to skip certain port by marking it dummy. Note that SFF code has been treating unuvailable ports this way for a long time until recent breakage fix from Linus and is consistent with how other drivers handle with unavailable ports. This fixes 1-port legacy host handling still broken after the recent native mode fix and simplifies SFF init logic. The following changes are made... * ata_pci_init_native_host() and ata_init_legacy_host() both now try to initialized whatever they can and mark failed ports dummy. They return 0 if any port is successfully initialized. * ata_pci_prepare_native_host() and ata_pci_init_one() now doesn't take n_ports argument. All info should be specified via port_info array. Always two ports are allocated. * ata_pci_init_bmdma() exported to be used by LLDs in exotic cases. * port_info handling in all LLDs are standardized - all port_info arrays are const stack variable named ppi. Unless the second port is different from the first, its port_info is specified as NULL (tells libata that it's identical to the last non-NULL port_info). * pata_hpt37x/hpt3x2n: don't modify static variable directly. Make an on-stack copy instead as ata_piix does. * pata_uli: It has 4 ports instead of 2. Don't use ata_pci_prepare_native_host(). Allocate the host explicitly and use init helpers. It's simple enough. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
286 lines
7.5 KiB
C
286 lines
7.5 KiB
C
/*
|
|
* pata_triflex.c - Compaq PATA for new ATA layer
|
|
* (C) 2005 Red Hat Inc
|
|
* Alan Cox <alan@redhat.com>
|
|
*
|
|
* based upon
|
|
*
|
|
* triflex.c
|
|
*
|
|
* IDE Chipset driver for the Compaq TriFlex IDE controller.
|
|
*
|
|
* Known to work with the Compaq Workstation 5x00 series.
|
|
*
|
|
* Copyright (C) 2002 Hewlett-Packard Development Group, L.P.
|
|
* Author: Torben Mathiasen <torben.mathiasen@hp.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*
|
|
* Loosely based on the piix & svwks drivers.
|
|
*
|
|
* Documentation:
|
|
* Not publically available.
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/pci.h>
|
|
#include <linux/init.h>
|
|
#include <linux/blkdev.h>
|
|
#include <linux/delay.h>
|
|
#include <scsi/scsi_host.h>
|
|
#include <linux/libata.h>
|
|
|
|
#define DRV_NAME "pata_triflex"
|
|
#define DRV_VERSION "0.2.8"
|
|
|
|
/**
|
|
* triflex_prereset - probe begin
|
|
* @ap: ATA port
|
|
* @deadline: deadline jiffies for the operation
|
|
*
|
|
* Set up cable type and use generic probe init
|
|
*/
|
|
|
|
static int triflex_prereset(struct ata_port *ap, unsigned long deadline)
|
|
{
|
|
static const struct pci_bits triflex_enable_bits[] = {
|
|
{ 0x80, 1, 0x01, 0x01 },
|
|
{ 0x80, 1, 0x02, 0x02 }
|
|
};
|
|
|
|
struct pci_dev *pdev = to_pci_dev(ap->host->dev);
|
|
|
|
if (!pci_test_config_bits(pdev, &triflex_enable_bits[ap->port_no]))
|
|
return -ENOENT;
|
|
|
|
return ata_std_prereset(ap, deadline);
|
|
}
|
|
|
|
|
|
|
|
static void triflex_error_handler(struct ata_port *ap)
|
|
{
|
|
ata_bmdma_drive_eh(ap, triflex_prereset, ata_std_softreset, NULL, ata_std_postreset);
|
|
}
|
|
|
|
/**
|
|
* triflex_load_timing - timing configuration
|
|
* @ap: ATA interface
|
|
* @adev: Device on the bus
|
|
* @speed: speed to configure
|
|
*
|
|
* The Triflex has one set of timings per device per channel. This
|
|
* means we must do some switching. As the PIO and DMA timings don't
|
|
* match we have to do some reloading unlike PIIX devices where tuning
|
|
* tricks can avoid it.
|
|
*/
|
|
|
|
static void triflex_load_timing(struct ata_port *ap, struct ata_device *adev, int speed)
|
|
{
|
|
struct pci_dev *pdev = to_pci_dev(ap->host->dev);
|
|
u32 timing = 0;
|
|
u32 triflex_timing, old_triflex_timing;
|
|
int channel_offset = ap->port_no ? 0x74: 0x70;
|
|
unsigned int is_slave = (adev->devno != 0);
|
|
|
|
|
|
pci_read_config_dword(pdev, channel_offset, &old_triflex_timing);
|
|
triflex_timing = old_triflex_timing;
|
|
|
|
switch(speed)
|
|
{
|
|
case XFER_MW_DMA_2:
|
|
timing = 0x0103;break;
|
|
case XFER_MW_DMA_1:
|
|
timing = 0x0203;break;
|
|
case XFER_MW_DMA_0:
|
|
timing = 0x0808;break;
|
|
case XFER_SW_DMA_2:
|
|
case XFER_SW_DMA_1:
|
|
case XFER_SW_DMA_0:
|
|
timing = 0x0F0F;break;
|
|
case XFER_PIO_4:
|
|
timing = 0x0202;break;
|
|
case XFER_PIO_3:
|
|
timing = 0x0204;break;
|
|
case XFER_PIO_2:
|
|
timing = 0x0404;break;
|
|
case XFER_PIO_1:
|
|
timing = 0x0508;break;
|
|
case XFER_PIO_0:
|
|
timing = 0x0808;break;
|
|
default:
|
|
BUG();
|
|
}
|
|
triflex_timing &= ~ (0xFFFF << (16 * is_slave));
|
|
triflex_timing |= (timing << (16 * is_slave));
|
|
|
|
if (triflex_timing != old_triflex_timing)
|
|
pci_write_config_dword(pdev, channel_offset, triflex_timing);
|
|
}
|
|
|
|
/**
|
|
* triflex_set_piomode - set initial PIO mode data
|
|
* @ap: ATA interface
|
|
* @adev: ATA device
|
|
*
|
|
* Use the timing loader to set up the PIO mode. We have to do this
|
|
* because DMA start/stop will only be called once DMA occurs. If there
|
|
* has been no DMA then the PIO timings are still needed.
|
|
*/
|
|
static void triflex_set_piomode(struct ata_port *ap, struct ata_device *adev)
|
|
{
|
|
triflex_load_timing(ap, adev, adev->pio_mode);
|
|
}
|
|
|
|
/**
|
|
* triflex_dma_start - DMA start callback
|
|
* @qc: Command in progress
|
|
*
|
|
* Usually drivers set the DMA timing at the point the set_dmamode call
|
|
* is made. Triflex however requires we load new timings on the
|
|
* transition or keep matching PIO/DMA pairs (ie MWDMA2/PIO4 etc).
|
|
* We load the DMA timings just before starting DMA and then restore
|
|
* the PIO timing when the DMA is finished.
|
|
*/
|
|
|
|
static void triflex_bmdma_start(struct ata_queued_cmd *qc)
|
|
{
|
|
triflex_load_timing(qc->ap, qc->dev, qc->dev->dma_mode);
|
|
ata_bmdma_start(qc);
|
|
}
|
|
|
|
/**
|
|
* triflex_dma_stop - DMA stop callback
|
|
* @ap: ATA interface
|
|
* @adev: ATA device
|
|
*
|
|
* We loaded new timings in dma_start, as a result we need to restore
|
|
* the PIO timings in dma_stop so that the next command issue gets the
|
|
* right clock values.
|
|
*/
|
|
|
|
static void triflex_bmdma_stop(struct ata_queued_cmd *qc)
|
|
{
|
|
ata_bmdma_stop(qc);
|
|
triflex_load_timing(qc->ap, qc->dev, qc->dev->pio_mode);
|
|
}
|
|
|
|
static struct scsi_host_template triflex_sht = {
|
|
.module = THIS_MODULE,
|
|
.name = DRV_NAME,
|
|
.ioctl = ata_scsi_ioctl,
|
|
.queuecommand = ata_scsi_queuecmd,
|
|
.can_queue = ATA_DEF_QUEUE,
|
|
.this_id = ATA_SHT_THIS_ID,
|
|
.sg_tablesize = LIBATA_MAX_PRD,
|
|
.cmd_per_lun = ATA_SHT_CMD_PER_LUN,
|
|
.emulated = ATA_SHT_EMULATED,
|
|
.use_clustering = ATA_SHT_USE_CLUSTERING,
|
|
.proc_name = DRV_NAME,
|
|
.dma_boundary = ATA_DMA_BOUNDARY,
|
|
.slave_configure = ata_scsi_slave_config,
|
|
.slave_destroy = ata_scsi_slave_destroy,
|
|
.bios_param = ata_std_bios_param,
|
|
};
|
|
|
|
static struct ata_port_operations triflex_port_ops = {
|
|
.port_disable = ata_port_disable,
|
|
.set_piomode = triflex_set_piomode,
|
|
.mode_filter = ata_pci_default_filter,
|
|
|
|
.tf_load = ata_tf_load,
|
|
.tf_read = ata_tf_read,
|
|
.check_status = ata_check_status,
|
|
.exec_command = ata_exec_command,
|
|
.dev_select = ata_std_dev_select,
|
|
|
|
.freeze = ata_bmdma_freeze,
|
|
.thaw = ata_bmdma_thaw,
|
|
.error_handler = triflex_error_handler,
|
|
.post_internal_cmd = ata_bmdma_post_internal_cmd,
|
|
.cable_detect = ata_cable_40wire,
|
|
|
|
.bmdma_setup = ata_bmdma_setup,
|
|
.bmdma_start = triflex_bmdma_start,
|
|
.bmdma_stop = triflex_bmdma_stop,
|
|
.bmdma_status = ata_bmdma_status,
|
|
|
|
.qc_prep = ata_qc_prep,
|
|
.qc_issue = ata_qc_issue_prot,
|
|
|
|
.data_xfer = ata_data_xfer,
|
|
|
|
.irq_handler = ata_interrupt,
|
|
.irq_clear = ata_bmdma_irq_clear,
|
|
.irq_on = ata_irq_on,
|
|
.irq_ack = ata_irq_ack,
|
|
|
|
.port_start = ata_port_start,
|
|
};
|
|
|
|
static int triflex_init_one(struct pci_dev *dev, const struct pci_device_id *id)
|
|
{
|
|
static const struct ata_port_info info = {
|
|
.sht = &triflex_sht,
|
|
.flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_SRST,
|
|
.pio_mask = 0x1f,
|
|
.mwdma_mask = 0x07,
|
|
.port_ops = &triflex_port_ops
|
|
};
|
|
const struct ata_port_info *ppi[] = { &info, NULL };
|
|
static int printed_version;
|
|
|
|
if (!printed_version++)
|
|
dev_printk(KERN_DEBUG, &dev->dev, "version " DRV_VERSION "\n");
|
|
|
|
return ata_pci_init_one(dev, ppi);
|
|
}
|
|
|
|
static const struct pci_device_id triflex[] = {
|
|
{ PCI_VDEVICE(COMPAQ, PCI_DEVICE_ID_COMPAQ_TRIFLEX_IDE), },
|
|
|
|
{ },
|
|
};
|
|
|
|
static struct pci_driver triflex_pci_driver = {
|
|
.name = DRV_NAME,
|
|
.id_table = triflex,
|
|
.probe = triflex_init_one,
|
|
.remove = ata_pci_remove_one,
|
|
#ifdef CONFIG_PM
|
|
.suspend = ata_pci_device_suspend,
|
|
.resume = ata_pci_device_resume,
|
|
#endif
|
|
};
|
|
|
|
static int __init triflex_init(void)
|
|
{
|
|
return pci_register_driver(&triflex_pci_driver);
|
|
}
|
|
|
|
static void __exit triflex_exit(void)
|
|
{
|
|
pci_unregister_driver(&triflex_pci_driver);
|
|
}
|
|
|
|
MODULE_AUTHOR("Alan Cox");
|
|
MODULE_DESCRIPTION("low-level driver for Compaq Triflex");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_DEVICE_TABLE(pci, triflex);
|
|
MODULE_VERSION(DRV_VERSION);
|
|
|
|
module_init(triflex_init);
|
|
module_exit(triflex_exit);
|