mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-05 18:39:59 +00:00
a1a5482a2c
On Fri, Jun 17, 2022 at 02:08:52PM +0300, Stephane Eranian wrote: > Some changes to the way invalid MSR accesses are reported by the > kernel is causing some problems with messages printed on the > console. > > We have seen several cases of ex_handler_msr() printing invalid MSR > accesses once but the callstack multiple times causing confusion on > the console. > The problem here is that another earlier commit (5.13): > >a358f40600("once: implement DO_ONCE_LITE for non-fast-path "do once" functionality") > > Modifies all the pr_*_once() calls to always return true claiming > that no caller is ever checking the return value of the functions. > > This is why we are seeing the callstack printed without the > associated printk() msg. Extract the ONCE_IF(cond) part into __ONCE_LTE_IF() and use that to implement DO_ONCE_LITE_IF() and fix the extable code. Fixes:a358f40600("once: implement DO_ONCE_LITE for non-fast-path "do once" functionality") Reported-by: Stephane Eranian <eranian@google.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Tested-by: Stephane Eranian <eranian@google.com> Link: https://lkml.kernel.org/r/YqyVFsbviKjVGGZ9@worktop.programming.kicks-ass.net
36 lines
925 B
C
36 lines
925 B
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _LINUX_ONCE_LITE_H
|
|
#define _LINUX_ONCE_LITE_H
|
|
|
|
#include <linux/types.h>
|
|
|
|
/* Call a function once. Similar to DO_ONCE(), but does not use jump label
|
|
* patching via static keys.
|
|
*/
|
|
#define DO_ONCE_LITE(func, ...) \
|
|
DO_ONCE_LITE_IF(true, func, ##__VA_ARGS__)
|
|
|
|
#define __ONCE_LITE_IF(condition) \
|
|
({ \
|
|
static bool __section(".data.once") __already_done; \
|
|
bool __ret_cond = !!(condition); \
|
|
bool __ret_once = false; \
|
|
\
|
|
if (unlikely(__ret_cond && !__already_done)) { \
|
|
__already_done = true; \
|
|
__ret_once = true; \
|
|
} \
|
|
unlikely(__ret_once); \
|
|
})
|
|
|
|
#define DO_ONCE_LITE_IF(condition, func, ...) \
|
|
({ \
|
|
bool __ret_do_once = !!(condition); \
|
|
\
|
|
if (__ONCE_LITE_IF(__ret_do_once)) \
|
|
func(__VA_ARGS__); \
|
|
\
|
|
unlikely(__ret_do_once); \
|
|
})
|
|
|
|
#endif /* _LINUX_ONCE_LITE_H */
|